From a848d5677ffcf96646fafce898f6eb4ff7d6eb06 Mon Sep 17 00:00:00 2001
From: Niclas Overby <niclas@overby.me>
Date: Wed, 12 Aug 2026 09:29:45 +0200
Subject: [PATCH] fix(cider): eighteen ported checks were not executable, and
 the suite is what found it

buck-test.nu invokes several checks as ./scripts/<name>.nu, and nushell answers a file
without the executable bit with

    Command `./scripts/buck-argv-roundtrip-check.nu` not found
    help: refers to a file that is not executable. Did you forget to set execute permissions?

which reads like a MISSING SCRIPT rather than a missing mode. The full suite run died there,
at the first such check it reached, having got as far as the static tier.

EIGHTEEN files were in that state, every one of them a python-to-nushell port where the new
file was written and the caller swapped but the mode never set. The ones invoked as
`nu <script>` were unaffected, which is exactly why it went unnoticed: the checks I ran by
hand all took that path.

SO THE REFS CHECK NOW CHECKS THE MODE TOO. It already walks scripts/ to prove every
scripts/<name> written down still exists; existing and being runnable are the same claim as
far as a caller is concerned. Controlled both ways: with the bit removed from one file it
names that file and fails, with it restored it passes.

THE LESSON FOR THE REST OF THIS PORT: chmod +x is part of landing a port, not a detail, and
the suite is the thing that says so. Running each check by hand proves the check works and
proves nothing about how the suite calls it.
---
 scripts/buck-argv-roundtrip-check.nu    |  0
 scripts/buck-bridge-generality-check.nu |  0
 scripts/buck-coverage.nu                |  0
 scripts/buck-darwin-rust-run.nu         |  0
 scripts/buck-env-names-check.nu         |  0
 scripts/buck-env.nu                     |  0
 scripts/buck-escape-check.nu            |  0
 scripts/buck-escape-roots-check.nu      |  0
 scripts/buck-first-party-paths-check.nu |  0
 scripts/buck-hosttools-parity.nu        |  0
 scripts/buck-include-closure-check.nu   |  0
 scripts/buck-labels-check.nu            |  0
 scripts/buck-pin-patches-check.nu       |  0
 scripts/buck-pin-paths-check.nu         |  0
 scripts/buck-pin-rev-check.nu           |  0
 scripts/buck-prefix-consistency.nu      |  0
 scripts/buck-script-refs-check.nu       | 17 +++++++++++++++--
 scripts/buck-src-normalise-check.nu     |  0
 scripts/buck-upstream-names-check.nu    |  0
 19 files changed, 15 insertions(+), 2 deletions(-)
 mode change 100644 => 100755 scripts/buck-argv-roundtrip-check.nu
 mode change 100644 => 100755 scripts/buck-bridge-generality-check.nu
 mode change 100644 => 100755 scripts/buck-coverage.nu
 mode change 100644 => 100755 scripts/buck-darwin-rust-run.nu
 mode change 100644 => 100755 scripts/buck-env-names-check.nu
 mode change 100644 => 100755 scripts/buck-env.nu
 mode change 100644 => 100755 scripts/buck-escape-check.nu
 mode change 100644 => 100755 scripts/buck-escape-roots-check.nu
 mode change 100644 => 100755 scripts/buck-first-party-paths-check.nu
 mode change 100644 => 100755 scripts/buck-hosttools-parity.nu
 mode change 100644 => 100755 scripts/buck-include-closure-check.nu
 mode change 100644 => 100755 scripts/buck-labels-check.nu
 mode change 100644 => 100755 scripts/buck-pin-patches-check.nu
 mode change 100644 => 100755 scripts/buck-pin-paths-check.nu
 mode change 100644 => 100755 scripts/buck-pin-rev-check.nu
 mode change 100644 => 100755 scripts/buck-prefix-consistency.nu
 mode change 100644 => 100755 scripts/buck-src-normalise-check.nu
 mode change 100644 => 100755 scripts/buck-upstream-names-check.nu

diff --git a/scripts/buck-argv-roundtrip-check.nu b/scripts/buck-argv-roundtrip-check.nu
old mode 100644
new mode 100755
diff --git a/scripts/buck-bridge-generality-check.nu b/scripts/buck-bridge-generality-check.nu
old mode 100644
new mode 100755
diff --git a/scripts/buck-coverage.nu b/scripts/buck-coverage.nu
old mode 100644
new mode 100755
diff --git a/scripts/buck-darwin-rust-run.nu b/scripts/buck-darwin-rust-run.nu
old mode 100644
new mode 100755
diff --git a/scripts/buck-env-names-check.nu b/scripts/buck-env-names-check.nu
old mode 100644
new mode 100755
diff --git a/scripts/buck-env.nu b/scripts/buck-env.nu
old mode 100644
new mode 100755
diff --git a/scripts/buck-escape-check.nu b/scripts/buck-escape-check.nu
old mode 100644
new mode 100755
diff --git a/scripts/buck-escape-roots-check.nu b/scripts/buck-escape-roots-check.nu
old mode 100644
new mode 100755
diff --git a/scripts/buck-first-party-paths-check.nu b/scripts/buck-first-party-paths-check.nu
old mode 100644
new mode 100755
diff --git a/scripts/buck-hosttools-parity.nu b/scripts/buck-hosttools-parity.nu
old mode 100644
new mode 100755
diff --git a/scripts/buck-include-closure-check.nu b/scripts/buck-include-closure-check.nu
old mode 100644
new mode 100755
diff --git a/scripts/buck-labels-check.nu b/scripts/buck-labels-check.nu
old mode 100644
new mode 100755
diff --git a/scripts/buck-pin-patches-check.nu b/scripts/buck-pin-patches-check.nu
old mode 100644
new mode 100755
diff --git a/scripts/buck-pin-paths-check.nu b/scripts/buck-pin-paths-check.nu
old mode 100644
new mode 100755
diff --git a/scripts/buck-pin-rev-check.nu b/scripts/buck-pin-rev-check.nu
old mode 100644
new mode 100755
diff --git a/scripts/buck-prefix-consistency.nu b/scripts/buck-prefix-consistency.nu
old mode 100644
new mode 100755
diff --git a/scripts/buck-script-refs-check.nu b/scripts/buck-script-refs-check.nu
index 409977581..cc9e22cc4 100755
--- a/scripts/buck-script-refs-check.nu
+++ b/scripts/buck-script-refs-check.nu
@@ -103,10 +103,23 @@ def main [--scan: string = ""] {
         say $"   plus ($named | length) check\(s) named by ($driver)"
     }
 
-    if ($bad | is-empty) and ($missing_checks | is-empty) {
-        say "PASS: every scripts/<name> written down still exists"
+    # AND IT HAS TO BE RUNNABLE, not merely present. buck-test.nu invokes several checks as
+    # ./scripts/<name>.nu, and a file without the executable bit fails there with
+    # "Command not found ... refers to a file that is not executable", which reads like a
+    # missing script rather than a missing mode. EIGHTEEN of them were in that state after the
+    # python ports, and the suite died on the first one it reached.
+    let not_exec = (^find scripts -name "*.nu" ! -perm -u+x | complete | get stdout | lines
+        | where {|l| $l != "" } | sort)
+
+    if ($bad | is-empty) and ($missing_checks | is-empty) and ($not_exec | is-empty) {
+        say "PASS: every scripts/<name> written down still exists and is executable"
         exit 0
     }
+    if ($not_exec | is-not-empty) {
+        say $"FAIL: ($not_exec | length) nushell script\(s) are not executable, so a caller that"
+        say "      runs them by path gets a confusing not-found error:"
+        for f in $not_exec { say $"  ($f)" }
+    }
     for m in $missing_checks {
         say $"FAIL: ($driver) runs ($m), and neither scripts/($m).nu nor .sh is there"
     }
diff --git a/scripts/buck-src-normalise-check.nu b/scripts/buck-src-normalise-check.nu
old mode 100644
new mode 100755
diff --git a/scripts/buck-upstream-names-check.nu b/scripts/buck-upstream-names-check.nu
old mode 100644
new mode 100755
-- 
2.51.2