From 5d926b7fc342a09bc07405b150ae34dbd8575ca3 Mon Sep 17 00:00:00 2001 From: "Shahar \"Dawn\" Or" Date: Sat, 30 Aug 2025 21:32:13 +0700 Subject: [PATCH] refactor(repeated_keys): an early non-match return --- lib/src/lints/repeated_keys.rs | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/lib/src/lints/repeated_keys.rs b/lib/src/lints/repeated_keys.rs index 0dbc1eb..658e7d3 100644 --- a/lib/src/lints/repeated_keys.rs +++ b/lib/src/lints/repeated_keys.rs @@ -72,17 +72,18 @@ impl Rule for RepeatedKeys { let mut kv_scrutinee_components = scrutinee_key.path(); let kv_scrutinee_first_component = kv_scrutinee_components.next()?; let kv_scrutinee_ident = Ident::cast(kv_scrutinee_first_component)?; - if kv_scrutinee_ident.as_str() == first_component_ident.as_str() { - Some(( - kv_scrutinee.key()?.node().text_range(), - kv_scrutinee_components - .map(|n| n.to_string()) - .collect::>() - .join("."), - )) - } else { - None + + if kv_scrutinee_ident.as_str() != first_component_ident.as_str() { + return None; } + + Some(( + kv_scrutinee.key()?.node().text_range(), + kv_scrutinee_components + .map(|n| n.to_string()) + .collect::>() + .join("."), + )) }) .collect::>(); -- 2.51.2