diff --git a/docs-ai/002-custom-commands/006-visibility-gates-and-scope-ordering.md b/docs-ai/002-custom-commands/006-visibility-gates-and-scope-ordering.md index e5ff3b4f..1edca81b 100644 --- a/docs-ai/002-custom-commands/006-visibility-gates-and-scope-ordering.md +++ b/docs-ai/002-custom-commands/006-visibility-gates-and-scope-ordering.md @@ -65,7 +65,8 @@ repository settings cannot show the effective command list that drives the toolb enabled for a repository. - `EffectiveCustomCommand.resolve` now filters disabled commands, preserves source-qualified IDs, retains duplicate titles, and orders repository commands before Global commands. -- The shared editor presents enable toggles and drag handles. Repository settings append read-only +- The shared editor presents compact standard checkboxes and drag handles. It accepts only known + local-command drag payloads, supports an unconditional append drop target, and appends read-only Global rows with a Global marker and This Repo gate; a globally disabled row stays configurable. - The manual documents visibility, ordering, duplicate titles, gates, shortcut behavior, and the updated settings entry points. @@ -73,4 +74,14 @@ repository settings cannot show the effective command list that drives the toolb ## Amendments -(append follow-up notes here) +### 2026-07-19 — Review follow-up + +- **No same-title migration**: the clean cutover remains intentional. A one-time opt-out would + incorrectly keep a Global command hidden after its matching local command is later deleted; the + release note instead calls out that both commands now appear. +- **No eager dead-ID cleanup**: repository settings cannot validate Global IDs in isolation. + Deleting a Global command therefore leaves harmless historical opt-outs rather than triggering + cross-repository writes. +- **Settings refinements**: the trailing reorder target is always available, drop destinations + reject unknown IDs, enable controls use compact standard checkboxes, and Global opt-outs encode + in sorted order to avoid configuration churn. diff --git a/docs/.sync-meta.json b/docs/.sync-meta.json index 08954b13..caa4cd7e 100644 --- a/docs/.sync-meta.json +++ b/docs/.sync-meta.json @@ -1,6 +1,6 @@ { "_comment": "Metadata for the docs/ manual. The last_synced_commit is the commit at which docs/ was last verified against the implementation; the sync-docs skill (.claude/skills/sync-docs/SKILL.md) diffs HEAD against it and updates this file. Committed to git on purpose so the baseline persists across sessions and machines. A dotfile + .json so a future docs website does not render it as a page.", - "last_synced_commit": "c876fe33fe7e8f2940e5e05320d79565c8b34165", + "last_synced_commit": "9611a12d1437e6c44bb9c6f393bf2352b487373d", "last_synced_date": "2026-07-19", - "note": "Custom Command visibility gates: verified enabled ordering, Global per-repository opt-outs, source-aware settings controls, command surfaces, and shortcut registration." + "note": "Custom Command follow-up: verified compact checkbox controls, valid drag targets, append reorder target, and deterministic Global opt-out encoding." } diff --git a/docs/components/custom-actions.md b/docs/components/custom-actions.md index 746fcc16..25a09d70 100644 --- a/docs/components/custom-actions.md +++ b/docs/components/custom-actions.md @@ -72,7 +72,7 @@ Command Palette, and hotkey dispatch until re-enabled. globally and enabled for that repository. New Global commands are enabled in every repository by default; Repo Settings can turn an individual Global command off without changing its definition. Global command fields and order are edited only in -Settings → Global Commands. +Settings → Commands. **Shortcut precedence:** a repo command wins a collision with a Global command's shortcut. Custom Command hotkeys take **precedence over app shortcuts**; conflicts @@ -96,7 +96,7 @@ menu, and the [Command Palette](command-palette.md). Global commands are stored - Per repo (Repo Settings): `runScript`, `setupScript`, `archiveScript`, local Custom Commands, and per-repository visibility of Global Commands. -- Global (Settings → Global Commands): Global Custom Commands and their order. +- Global (Settings → Commands): Global Custom Commands and their order. - Global: `showRunButtonInToolbar`, `showDefaultEditorInToolbar`. ## Gotchas for agents