native macOS codings agent orchestrator prowl.onev.cat
Something went wrong. Try again.
Swift
123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756import CustomDumpimport Foundationimport Testing
@testable import Prowl
// MARK: - Behavior matrix tests for the keybinding resolver pipeline.// Dimensions: scope × conflict-policy × state (default / override / disable / migrate / reset).
struct KeybindingBehaviorMatrixTests {
// MARK: - Defaults
@Test func defaultsResolveToAppDefaultForAllScopes() { let schema = matrixSchema() let resolved = KeybindingResolver.resolve(schema: schema)
for command in schema.commands { let result = resolved.binding(for: command.id) #expect(result?.binding == command.defaultBinding) #expect(result?.source == .appDefault) } }
@Test func defaultsResolveToNilBindingWhenSchemaHasNoDefault() { let command = makeCommand( id: "cmd.no_default", scope: .customCommand, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: nil ) let schema = KeybindingSchemaDocument(commands: [command]) let resolved = KeybindingResolver.resolve(schema: schema)
#expect(resolved.binding(for: "cmd.no_default")?.binding == nil) #expect(resolved.binding(for: "cmd.no_default")?.source == .appDefault) }
// MARK: - Override enforcement by scope
@Test func configurableAppActionAcceptsUserOverride() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.configurable", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("a") ) ]) let overrides = overrideStore(["cmd.configurable": .init(binding: binding("z"))]) let resolved = KeybindingResolver.resolve(schema: schema, userOverrides: overrides)
#expect(resolved.binding(for: "cmd.configurable")?.binding == binding("z")) #expect(resolved.binding(for: "cmd.configurable")?.source == .userOverride) }
@Test func systemFixedAppActionIgnoresUserOverride() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.fixed", scope: .systemFixedAppAction, policy: .disallowUserOverride, allowOverride: false, defaultBinding: binding("q") ) ]) let overrides = overrideStore(["cmd.fixed": .init(binding: binding("z"))]) let resolved = KeybindingResolver.resolve(schema: schema, userOverrides: overrides)
#expect(resolved.binding(for: "cmd.fixed")?.binding == binding("q")) #expect(resolved.binding(for: "cmd.fixed")?.source == .appDefault) }
@Test func systemFixedAppActionIgnoresMigratedOverride() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.fixed", scope: .systemFixedAppAction, policy: .disallowUserOverride, allowOverride: false, defaultBinding: binding("q") ) ]) let migrated = ["cmd.fixed": KeybindingUserOverride(binding: binding("z"))] let resolved = KeybindingResolver.resolve(schema: schema, migratedOverrides: migrated)
#expect(resolved.binding(for: "cmd.fixed")?.binding == binding("q")) #expect(resolved.binding(for: "cmd.fixed")?.source == .appDefault) }
@Test func localInteractionAcceptsUserOverride() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.local", scope: .localInteraction, policy: .localOnly, allowOverride: true, defaultBinding: binding("r") ) ]) let overrides = overrideStore(["cmd.local": .init(binding: binding("t"))]) let resolved = KeybindingResolver.resolve(schema: schema, userOverrides: overrides)
#expect(resolved.binding(for: "cmd.local")?.binding == binding("t")) #expect(resolved.binding(for: "cmd.local")?.source == .userOverride) }
@Test func customCommandAcceptsUserOverride() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "custom_command.build", scope: .customCommand, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: nil ) ]) let overrides = overrideStore(["custom_command.build": .init(binding: binding("b", shift: true))]) let resolved = KeybindingResolver.resolve(schema: schema, userOverrides: overrides)
#expect(resolved.binding(for: "custom_command.build")?.binding == binding("b", shift: true)) #expect(resolved.binding(for: "custom_command.build")?.source == .userOverride) }
// MARK: - Disable behavior
@Test func disableOverrideClearsBindingForConfigurableCommand() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.configurable", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("a") ) ]) let overrides = overrideStore(["cmd.configurable": .init(binding: nil, isEnabled: false)]) let resolved = KeybindingResolver.resolve(schema: schema, userOverrides: overrides)
#expect(resolved.binding(for: "cmd.configurable")?.binding == nil) #expect(resolved.binding(for: "cmd.configurable")?.source == .userOverride) }
@Test func disableOverrideHasNoEffectOnFixedCommand() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.fixed", scope: .systemFixedAppAction, policy: .disallowUserOverride, allowOverride: false, defaultBinding: binding("q") ) ]) let overrides = overrideStore(["cmd.fixed": .init(binding: nil, isEnabled: false)]) let resolved = KeybindingResolver.resolve(schema: schema, userOverrides: overrides)
#expect(resolved.binding(for: "cmd.fixed")?.binding == binding("q")) #expect(resolved.binding(for: "cmd.fixed")?.source == .appDefault) }
@Test func disableOverrideClearsBindingForLocalInteraction() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.local", scope: .localInteraction, policy: .localOnly, allowOverride: true, defaultBinding: binding("r") ) ]) let overrides = overrideStore(["cmd.local": .init(binding: nil, isEnabled: false)]) let resolved = KeybindingResolver.resolve(schema: schema, userOverrides: overrides)
#expect(resolved.binding(for: "cmd.local")?.binding == nil) #expect(resolved.binding(for: "cmd.local")?.source == .userOverride) }
// MARK: - Migration precedence
@Test func migratedOverrideAppliesWhenNoUserOverride() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.alpha", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("a") ) ]) let migrated = ["cmd.alpha": KeybindingUserOverride(binding: binding("m"))] let resolved = KeybindingResolver.resolve(schema: schema, migratedOverrides: migrated)
#expect(resolved.binding(for: "cmd.alpha")?.binding == binding("m")) #expect(resolved.binding(for: "cmd.alpha")?.source == .migratedLegacy) }
@Test func userOverrideTakesPrecedenceOverMigratedOverride() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.alpha", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("a") ) ]) let migrated = ["cmd.alpha": KeybindingUserOverride(binding: binding("m"))] let overrides = overrideStore(["cmd.alpha": .init(binding: binding("u"))]) let resolved = KeybindingResolver.resolve( schema: schema, userOverrides: overrides, migratedOverrides: migrated )
#expect(resolved.binding(for: "cmd.alpha")?.binding == binding("u")) #expect(resolved.binding(for: "cmd.alpha")?.source == .userOverride) }
@Test func userDisableOverridesMigratedBinding() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.alpha", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("a") ) ]) let migrated = ["cmd.alpha": KeybindingUserOverride(binding: binding("m"))] let overrides = overrideStore(["cmd.alpha": .init(binding: nil, isEnabled: false)]) let resolved = KeybindingResolver.resolve( schema: schema, userOverrides: overrides, migratedOverrides: migrated )
#expect(resolved.binding(for: "cmd.alpha")?.binding == nil) #expect(resolved.binding(for: "cmd.alpha")?.source == .userOverride) }
@Test func migratedOverrideDoesNotApplyToFixedScope() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.fixed", scope: .systemFixedAppAction, policy: .disallowUserOverride, allowOverride: false, defaultBinding: binding("q") ) ]) let migrated = ["cmd.fixed": KeybindingUserOverride(binding: binding("m"))] let resolved = KeybindingResolver.resolve(schema: schema, migratedOverrides: migrated)
#expect(resolved.binding(for: "cmd.fixed")?.binding == binding("q")) #expect(resolved.binding(for: "cmd.fixed")?.source == .appDefault) }
@Test func migratedSourcePreservedWhenIdenticalToDefault() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.alpha", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("a") ) ]) // Migrated binding is identical to default — source stays appDefault because didChange is false let migrated = ["cmd.alpha": KeybindingUserOverride(binding: binding("a"))] let resolved = KeybindingResolver.resolve(schema: schema, migratedOverrides: migrated)
#expect(resolved.binding(for: "cmd.alpha")?.binding == binding("a")) #expect(resolved.binding(for: "cmd.alpha")?.source == .appDefault) }
// MARK: - Conflict detection across policies
@Test func warnPolicyDetectsConflictWithExistingBinding() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.one", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("a") ), makeCommand( id: "cmd.two", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("b") ), ])
let conflict = ShortcutConflictDetector.firstConflictCommandID( commandID: "cmd.two", binding: binding("a"), policy: .warnAndPreferUserOverride, schema: schema, userOverrides: .empty )
#expect(conflict == "cmd.one") }
@Test func disallowPolicySkipsConflictDetection() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.one", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("a") ), makeCommand( id: "cmd.fixed", scope: .systemFixedAppAction, policy: .disallowUserOverride, allowOverride: false, defaultBinding: binding("x") ), ])
let conflict = ShortcutConflictDetector.firstConflictCommandID( commandID: "cmd.fixed", binding: binding("a"), policy: .disallowUserOverride, schema: schema, userOverrides: .empty )
#expect(conflict == nil) }
@Test func localOnlyPolicyDetectsConflictWithAppAction() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.global", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("a") ), makeCommand( id: "cmd.local", scope: .localInteraction, policy: .localOnly, allowOverride: true, defaultBinding: binding("b") ), ])
let conflict = ShortcutConflictDetector.firstConflictCommandID( commandID: "cmd.local", binding: binding("a"), policy: .localOnly, schema: schema, userOverrides: .empty )
#expect(conflict == "cmd.global") }
@Test func noConflictWhenBindingsAreDifferent() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.one", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("a") ), makeCommand( id: "cmd.two", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("b") ), ])
let conflict = ShortcutConflictDetector.firstConflictCommandID( commandID: "cmd.two", binding: binding("c"), policy: .warnAndPreferUserOverride, schema: schema, userOverrides: .empty )
#expect(conflict == nil) }
@Test func conflictDetectionConsidersUserOverridesNotJustDefaults() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.one", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("a") ), makeCommand( id: "cmd.two", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("b") ), ]) // cmd.one was overridden to "z" — so assigning "z" to cmd.two should conflict let overrides = overrideStore(["cmd.one": .init(binding: binding("z"))])
let conflict = ShortcutConflictDetector.firstConflictCommandID( commandID: "cmd.two", binding: binding("z"), policy: .warnAndPreferUserOverride, schema: schema, userOverrides: overrides )
#expect(conflict == "cmd.one") }
@Test func noConflictWithDisabledCommand() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.one", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("a") ), makeCommand( id: "cmd.two", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("b") ), ]) // cmd.one was disabled — its binding is gone, so "a" is now free let overrides = overrideStore(["cmd.one": .init(binding: nil, isEnabled: false)])
let conflict = ShortcutConflictDetector.firstConflictCommandID( commandID: "cmd.two", binding: binding("a"), policy: .warnAndPreferUserOverride, schema: schema, userOverrides: overrides )
#expect(conflict == nil) }
// MARK: - Reset behavior
@Test func resetSingleCommandRestoresDefault() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.one", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("a") ) ]) let overrides = overrideStore(["cmd.one": .init(binding: binding("z"))])
let plan = ShortcutResetPlanner.makePlan( commandID: "cmd.one", schema: schema, userOverrides: overrides )
#expect(plan.commandIDsToReset == ["cmd.one"]) #expect(plan.conflictingCommandIDs.isEmpty) #expect(plan.restoredBinding == binding("a"))
let resolved = resolvedAfterReset(plan: plan, overrides: overrides, schema: schema) #expect(resolved.binding(for: "cmd.one")?.binding == binding("a")) #expect(resolved.binding(for: "cmd.one")?.source == .appDefault) }
@Test func resetCascadesWhenRestoredDefaultConflicts() { // cmd.one default=a, overridden to b // cmd.two default=b, disabled (because cmd.one took b) // Resetting cmd.two restores b, which conflicts with cmd.one's override → cascade let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.one", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("a") ), makeCommand( id: "cmd.two", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("b") ), ]) let overrides = overrideStore([ "cmd.one": .init(binding: binding("b")), "cmd.two": .init(binding: nil, isEnabled: false), ])
let plan = ShortcutResetPlanner.makePlan( commandID: "cmd.two", schema: schema, userOverrides: overrides )
#expect(plan.commandIDsToReset.contains("cmd.one")) #expect(plan.commandIDsToReset.contains("cmd.two")) #expect(plan.conflictingCommandIDs == ["cmd.one"])
let resolved = resolvedAfterReset(plan: plan, overrides: overrides, schema: schema) #expect(resolved.binding(for: "cmd.one")?.binding == binding("a")) #expect(resolved.binding(for: "cmd.two")?.binding == binding("b")) }
@Test func resetAllCommandsInSectionCascadesOutside() { // Section contains cmd.two and cmd.three // cmd.one (outside section) overrides to cmd.two's default let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.one", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("a") ), makeCommand( id: "cmd.two", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("b") ), makeCommand( id: "cmd.three", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("c") ), ]) let overrides = overrideStore([ "cmd.one": .init(binding: binding("b")), "cmd.two": .init(binding: nil, isEnabled: false), "cmd.three": .init(binding: binding("x")), ])
let plan = ShortcutResetPlanner.makePlan( commandIDs: ["cmd.two", "cmd.three"], schema: schema, userOverrides: overrides )
#expect(plan.commandIDsToReset.contains("cmd.one")) #expect(plan.conflictingCommandIDs == ["cmd.one"])
let resolved = resolvedAfterReset(plan: plan, overrides: overrides, schema: schema) #expect(resolved.binding(for: "cmd.one")?.binding == binding("a")) #expect(resolved.binding(for: "cmd.two")?.binding == binding("b")) #expect(resolved.binding(for: "cmd.three")?.binding == binding("c")) }
// MARK: - Persistence round-trip
@Test func userOverrideStoreEncodeDecodeRoundTrip() throws { let store = KeybindingUserOverrideStore( version: 1, overrides: [ "cmd.alpha": KeybindingUserOverride(binding: binding("x"), isEnabled: true), "cmd.beta": KeybindingUserOverride(binding: nil, isEnabled: false), "cmd.gamma": KeybindingUserOverride( binding: Keybinding( key: "arrow_up", modifiers: KeybindingModifiers(command: true, shift: true) ) ), ] )
let data = try JSONEncoder().encode(store) let decoded = try JSONDecoder().decode(KeybindingUserOverrideStore.self, from: data)
expectNoDifference(decoded, store) }
@Test func resolvedStateIsIdenticalAfterPersistenceRoundTrip() throws { let schema = matrixSchema() let overrides = KeybindingUserOverrideStore( version: 1, overrides: [ "cmd.configurable": KeybindingUserOverride(binding: binding("z")), "cmd.local": KeybindingUserOverride(binding: nil, isEnabled: false), ] )
let resolvedBefore = KeybindingResolver.resolve(schema: schema, userOverrides: overrides)
let data = try JSONEncoder().encode(overrides) let restored = try JSONDecoder().decode(KeybindingUserOverrideStore.self, from: data) let resolvedAfter = KeybindingResolver.resolve(schema: schema, userOverrides: restored)
expectNoDifference(resolvedAfter, resolvedBefore) }
// MARK: - Edge cases
@Test func overrideForUnknownCommandIDIsIgnored() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.one", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("a") ) ]) let overrides = overrideStore(["cmd.nonexistent": .init(binding: binding("z"))]) let resolved = KeybindingResolver.resolve(schema: schema, userOverrides: overrides)
#expect(resolved.binding(for: "cmd.one")?.binding == binding("a")) #expect(resolved.binding(for: "cmd.one")?.source == .appDefault) #expect(resolved.binding(for: "cmd.nonexistent") == nil) }
@Test func enabledOverrideWithNilBindingPreservesDefault() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.one", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("a") ) ]) // isEnabled=true but binding=nil → no change, preserves default let overrides = overrideStore(["cmd.one": .init(binding: nil, isEnabled: true)]) let resolved = KeybindingResolver.resolve(schema: schema, userOverrides: overrides)
#expect(resolved.binding(for: "cmd.one")?.binding == binding("a")) #expect(resolved.binding(for: "cmd.one")?.source == .appDefault) }
@Test func multipleCommandsWithSameDefaultBindingResolveIndependently() { let schema = KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.one", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("a") ), makeCommand( id: "cmd.two", scope: .localInteraction, policy: .localOnly, allowOverride: true, defaultBinding: binding("a") ), ]) let resolved = KeybindingResolver.resolve(schema: schema)
#expect(resolved.binding(for: "cmd.one")?.binding == binding("a")) #expect(resolved.binding(for: "cmd.two")?.binding == binding("a")) #expect(resolved.binding(for: "cmd.one")?.source == .appDefault) #expect(resolved.binding(for: "cmd.two")?.source == .appDefault) }}
// MARK: - Helpers
extension KeybindingBehaviorMatrixTests {
/// A schema covering all four scopes with representative conflict policies. private func matrixSchema() -> KeybindingSchemaDocument { KeybindingSchemaDocument(commands: [ makeCommand( id: "cmd.configurable", scope: .configurableAppAction, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: binding("a") ), makeCommand( id: "cmd.fixed", scope: .systemFixedAppAction, policy: .disallowUserOverride, allowOverride: false, defaultBinding: binding("q") ), makeCommand( id: "cmd.local", scope: .localInteraction, policy: .localOnly, allowOverride: true, defaultBinding: binding("r") ), makeCommand( id: "custom_command.build", scope: .customCommand, policy: .warnAndPreferUserOverride, allowOverride: true, defaultBinding: nil ), ]) }
private func makeCommand( id: String, scope: KeybindingScope, policy: KeybindingConflictPolicy, allowOverride: Bool, defaultBinding: Keybinding? ) -> KeybindingCommandSchema { KeybindingCommandSchema( id: id, title: id, scope: scope, platform: .macOS, allowUserOverride: allowOverride, conflictPolicy: policy, defaultBinding: defaultBinding ) }
private func binding(_ key: String, shift: Bool = false) -> Keybinding { Keybinding(key: key, modifiers: KeybindingModifiers(command: true, shift: shift)) }
private func overrideStore(_ overrides: [String: KeybindingUserOverride]) -> KeybindingUserOverrideStore { KeybindingUserOverrideStore(overrides: overrides) }
private func resolvedAfterReset( plan: ShortcutResetPlan, overrides: KeybindingUserOverrideStore, schema: KeybindingSchemaDocument ) -> ResolvedKeybindingMap { var updated = overrides for commandID in plan.commandIDsToReset { updated.overrides.removeValue(forKey: commandID) } return KeybindingResolver.resolve(schema: schema, userOverrides: updated) }}