diff --git a/spindle/db/events.go b/spindle/db/events.go --- a/spindle/db/events.go +++ b/spindle/db/events.go @@ -18,7 +18,7 @@ Created int64 `json:"created"` EventJson string `json:"event"` } -func (d *DB) InsertEvent(event Event, notifier *notifier.Notifier) error { +func (d *DB) insertEvent(event Event, notifier *notifier.Notifier) error { _, err := d.Exec( `insert into events (rkey, nsid, event, created) values (?, ?, ?, ?)`, event.Rkey, @@ -70,22 +70,6 @@ return evts, nil } -func (d *DB) CreateStatusEvent(rkey string, s tangled.PipelineStatus, n *notifier.Notifier) error { - eventJson, err := json.Marshal(s) - if err != nil { - return err - } - - event := Event{ - Rkey: rkey, - Nsid: tangled.PipelineStatusNSID, - Created: time.Now().UnixNano(), - EventJson: string(eventJson), - } - - return d.InsertEvent(event, n) -} - func (d *DB) createStatusEvent( workflowId models.WorkflowId, statusKind models.StatusKind, @@ -116,7 +100,7 @@ Created: now.UnixNano(), EventJson: string(eventJson), } - return d.InsertEvent(event, n) + return d.insertEvent(event, n) } diff --git a/spindle/engines/nixery/engine.go b/spindle/engines/nixery/engine.go --- a/spindle/engines/nixery/engine.go +++ b/spindle/engines/nixery/engine.go @@ -179,7 +179,10 @@ if err != nil { return err } e.registerCleanup(wid, func(ctx context.Context) error { - return e.docker.NetworkRemove(ctx, networkName(wid)) + if err := e.docker.NetworkRemove(ctx, networkName(wid)); err != nil { + return fmt.Errorf("removing network: %w", err) + } + return nil }) addl := wf.Data.(addlFields) @@ -229,20 +232,22 @@ if err != nil { return fmt.Errorf("creating container: %w", err) } e.registerCleanup(wid, func(ctx context.Context) error { - err = e.docker.ContainerStop(ctx, resp.ID, container.StopOptions{}) - if err != nil { - return err + if err := e.docker.ContainerStop(ctx, resp.ID, container.StopOptions{}); err != nil { + return fmt.Errorf("stopping container: %w", err) } - return e.docker.ContainerRemove(ctx, resp.ID, container.RemoveOptions{ + err := e.docker.ContainerRemove(ctx, resp.ID, container.RemoveOptions{ RemoveVolumes: true, RemoveLinks: false, Force: false, }) + if err != nil { + return fmt.Errorf("removing container: %w", err) + } + return nil }) - err = e.docker.ContainerStart(ctx, resp.ID, container.StartOptions{}) - if err != nil { + if err := e.docker.ContainerStart(ctx, resp.ID, container.StartOptions{}); err != nil { return fmt.Errorf("starting container: %w", err) } @@ -394,12 +399,7 @@ return nil } func (e *Engine) DestroyWorkflow(ctx context.Context, wid models.WorkflowId) error { - e.cleanupMu.Lock() - key := wid.String() - - fns := e.cleanup[key] - delete(e.cleanup, key) - e.cleanupMu.Unlock() + fns := e.drainCleanups(wid) for _, fn := range fns { if err := fn(ctx); err != nil { @@ -415,6 +415,17 @@ defer e.cleanupMu.Unlock() key := wid.String() e.cleanup[key] = append(e.cleanup[key], fn) +} + +func (e *Engine) drainCleanups(wid models.WorkflowId) []cleanupFunc { + e.cleanupMu.Lock() + key := wid.String() + + fns := e.cleanup[key] + delete(e.cleanup, key) + e.cleanupMu.Unlock() + + return fns } func networkName(wid models.WorkflowId) string { diff --git a/spindle/server.go b/spindle/server.go --- a/spindle/server.go +++ b/spindle/server.go @@ -320,7 +320,7 @@ tpl.TriggerMetadata.Repo.Did, tpl.TriggerMetadata.Repo.Repo, ) if err != nil { - return err + return fmt.Errorf("failed to get repo: %w", err) } pipelineId := models.PipelineId{ @@ -341,7 +341,7 @@ PipelineId: pipelineId, Name: w.Name, }, fmt.Sprintf("unknown engine %#v", w.Engine), -1, s.n) if err != nil { - return err + return fmt.Errorf("db.StatusFailed: %w", err) } continue @@ -355,7 +355,7 @@ } ewf, err := s.engs[w.Engine].InitWorkflow(*w, tpl) if err != nil { - return err + return fmt.Errorf("init workflow: %w", err) } // inject TANGLED_* env vars after InitWorkflow @@ -372,7 +372,7 @@ PipelineId: pipelineId, Name: w.Name, }, s.n) if err != nil { - return err + return fmt.Errorf("db.StatusPending: %w", err) } } }