From e89a5aa1ade85be67fa007315e30d135dd5aef92 Mon Sep 17 00:00:00 2001
From: dawn <90008@gaze.systems>
Date: Wed, 18 Feb 2026 04:05:35 +0300
Subject: [PATCH] [ingest] log errors if we couldnt check in should_process

---
 src/backfill/mod.rs    | 3 +--
 src/ingest/firehose.rs | 8 +++++++-
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/backfill/mod.rs b/src/backfill/mod.rs
index 372daf1..49b07c8 100644
--- a/src/backfill/mod.rs
+++ b/src/backfill/mod.rs
@@ -584,7 +584,7 @@ async fn process_did<'i>(
                     };
                     trace!("{action} {did}/{collection}/{rkey} ({cid})");
 
-                    // Key is did|collection|rkey
+                    // key is did|collection|rkey
                     let db_key = keys::record_key(&did, collection, &rkey);
 
                     batch.insert(&app_state.db.blocks, cid.to_bytes(), val.as_ref());
@@ -684,7 +684,6 @@ async fn process_did<'i>(
         db.next_event_id.load(Ordering::SeqCst) - 1,
     ));
 
-    // buffer processing is handled by BufferProcessor when blocked flag is cleared
     trace!("backfill complete for {did}");
     Ok(previous_state)
 }
diff --git a/src/ingest/firehose.rs b/src/ingest/firehose.rs
index 64d8e68..670da70 100644
--- a/src/ingest/firehose.rs
+++ b/src/ingest/firehose.rs
@@ -98,10 +98,16 @@ impl FirehoseIngestor {
             SubscribeReposMessage::Identity(identity) => &identity.did,
             SubscribeReposMessage::Account(account) => &account.did,
             SubscribeReposMessage::Sync(sync) => &sync.did,
+            // todo: handle info and unknowns
             _ => return,
         };
 
-        if !self.should_process(did).await.unwrap_or(false) {
+        if !self
+            .should_process(did)
+            .await
+            .inspect_err(|e| error!("failed to check if we should process {did}: {e}"))
+            .unwrap_or(false)
+        {
             return;
         }
 
-- 
2.51.2