diff --git a/appview/db/pulls.go b/appview/db/pulls.go index ac35efaf..f2774b7e 100644 --- a/appview/db/pulls.go +++ b/appview/db/pulls.go @@ -654,6 +654,18 @@ func GetPull(e Execer, repoAt syntax.ATURI, pullId int) (*Pull, error) { return nil, err } + var pullSourceRepo *Repo + if pull.PullSource != nil { + if pull.PullSource.RepoAt != nil { + pullSourceRepo, err = GetRepoByAtUri(e, pull.PullSource.RepoAt.String()) + if err != nil { + log.Printf("failed to get repo by at uri: %v", err) + } else { + pull.PullSource.Repo = pullSourceRepo + } + } + } + pull.Submissions = make([]*PullSubmission, len(submissionsMap)) for _, submission := range submissionsMap { pull.Submissions[submission.RoundNumber] = submission diff --git a/appview/pages/pages.go b/appview/pages/pages.go index 93e8117d..14075bd4 100644 --- a/appview/pages/pages.go +++ b/appview/pages/pages.go @@ -679,14 +679,13 @@ func (r ResubmitResult) Unknown() bool { } type RepoSinglePullParams struct { - LoggedInUser *auth.User - RepoInfo RepoInfo - Active string - DidHandleMap map[string]string - Pull *db.Pull - PullSourceRepo *db.Repo - MergeCheck types.MergeCheckResponse - ResubmitCheck ResubmitResult + LoggedInUser *auth.User + RepoInfo RepoInfo + Active string + DidHandleMap map[string]string + Pull *db.Pull + MergeCheck types.MergeCheckResponse + ResubmitCheck ResubmitResult } func (p *Pages) RepoSinglePull(w io.Writer, params RepoSinglePullParams) error { diff --git a/appview/pages/templates/repo/pulls/fragments/pullHeader.html b/appview/pages/templates/repo/pulls/fragments/pullHeader.html index 5dbac400..49a2498a 100644 --- a/appview/pages/templates/repo/pulls/fragments/pullHeader.html +++ b/appview/pages/templates/repo/pulls/fragments/pullHeader.html @@ -43,16 +43,16 @@ {{ if not .Pull.IsPatchBased }} from - {{ if not .Pull.IsBranchBased }} - {{ $owner }}/{{ .PullSourceRepo.Name }} + {{ if .Pull.IsForkBased }} + {{ if .Pull.PullSource.Repo }} + {{ $owner }}/{{ .Pull.PullSource.Repo.Name }} + {{ else }} + [deleted fork] + {{ end }} {{ end }} - {{ $fullRepo := .RepoInfo.FullName }} - {{ if not .Pull.IsBranchBased }} - {{ $fullRepo = printf "%s/%s" $owner .PullSourceRepo.Name }} - {{ end }} - {{ .Pull.PullSource.Branch }} + {{ .Pull.PullSource.Branch }} {{ end }} @@ -67,4 +67,4 @@ -{{ end }} \ No newline at end of file +{{ end }} diff --git a/appview/pages/templates/repo/pulls/pull.html b/appview/pages/templates/repo/pulls/pull.html index d692e3b7..1b2f5596 100644 --- a/appview/pages/templates/repo/pulls/pull.html +++ b/appview/pages/templates/repo/pulls/pull.html @@ -90,10 +90,14 @@