{"entries":[{"lastCommit":{"author":{"email":"rogpeppe@gmail.com","name":"Roger Peppe","when":"2024-04-18T08:11:47.000000+01:00"},"committer":{"email":"rogpeppe@gmail.com","name":"Roger Peppe","when":"2024-04-18T16:48:57.000000Z"},"hash":"73b3df24ebc845d6181273e3faec577686295553","message":"mod/modfile: parse module.cue according to language.version\n\nThis change makes it possible to make changes to the\nmodule.cue schema while still using a closed schema\nfor earlier versions. We refuse module.cue files that\ndeclare a version newer than the current CUE version.\n\nThe language.version field is now mandatory in modules\nmode because otherwise we cannot tell which schema\nwe should be using.\n\nAlso remove the unimplemented features from the schema\nfor now: they're always there in the history and the proposal\nwhen we come to implement them, but they complicate\nthe schema for no good reason.\n\nOne unfortunate thing is that the error message when a field\nis defined that's explicitly unimplemented is not good.\nIn the absence of an `error` CUE builtin, we should be able to\nfix that in a subsequent CL by inspecting the error to see\nwhether any of the lines include the `unimplemented`\nidentifier.\n\nSigned-off-by: Roger Peppe \nChange-Id: I7bfef3b37e5b66bdbd8fe0614c1b815c7d9f1285\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1193275\nTryBot-Result: CUEcueckoo \nReviewed-by: Daniel Martí \nUnity-Result: CUE porcuepine \n","tree":"15ba058f41b4f8afff0df4208d33d945bdfccfaf"},"mode":"0100644","name":"add-latest.txtar","size":632},{"lastCommit":{"author":{"email":"rogpeppe@gmail.com","name":"Roger Peppe","when":"2024-04-18T08:11:47.000000+01:00"},"committer":{"email":"rogpeppe@gmail.com","name":"Roger Peppe","when":"2024-04-18T16:48:57.000000Z"},"hash":"73b3df24ebc845d6181273e3faec577686295553","message":"mod/modfile: parse module.cue according to language.version\n\nThis change makes it possible to make changes to the\nmodule.cue schema while still using a closed schema\nfor earlier versions. We refuse module.cue files that\ndeclare a version newer than the current CUE version.\n\nThe language.version field is now mandatory in modules\nmode because otherwise we cannot tell which schema\nwe should be using.\n\nAlso remove the unimplemented features from the schema\nfor now: they're always there in the history and the proposal\nwhen we come to implement them, but they complicate\nthe schema for no good reason.\n\nOne unfortunate thing is that the error message when a field\nis defined that's explicitly unimplemented is not good.\nIn the absence of an `error` CUE builtin, we should be able to\nfix that in a subsequent CL by inspecting the error to see\nwhether any of the lines include the `unimplemented`\nidentifier.\n\nSigned-off-by: Roger Peppe \nChange-Id: I7bfef3b37e5b66bdbd8fe0614c1b815c7d9f1285\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1193275\nTryBot-Result: CUEcueckoo \nReviewed-by: Daniel Martí \nUnity-Result: CUE porcuepine \n","tree":"15ba058f41b4f8afff0df4208d33d945bdfccfaf"},"mode":"0100644","name":"cannot-downgrade.txtar","size":1621},{"lastCommit":{"author":{"email":"rogpeppe@gmail.com","name":"Roger Peppe","when":"2024-04-18T08:11:47.000000+01:00"},"committer":{"email":"rogpeppe@gmail.com","name":"Roger Peppe","when":"2024-04-18T16:48:57.000000Z"},"hash":"73b3df24ebc845d6181273e3faec577686295553","message":"mod/modfile: parse module.cue according to language.version\n\nThis change makes it possible to make changes to the\nmodule.cue schema while still using a closed schema\nfor earlier versions. We refuse module.cue files that\ndeclare a version newer than the current CUE version.\n\nThe language.version field is now mandatory in modules\nmode because otherwise we cannot tell which schema\nwe should be using.\n\nAlso remove the unimplemented features from the schema\nfor now: they're always there in the history and the proposal\nwhen we come to implement them, but they complicate\nthe schema for no good reason.\n\nOne unfortunate thing is that the error message when a field\nis defined that's explicitly unimplemented is not good.\nIn the absence of an `error` CUE builtin, we should be able to\nfix that in a subsequent CL by inspecting the error to see\nwhether any of the lines include the `unimplemented`\nidentifier.\n\nSigned-off-by: Roger Peppe \nChange-Id: I7bfef3b37e5b66bdbd8fe0614c1b815c7d9f1285\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1193275\nTryBot-Result: CUEcueckoo \nReviewed-by: Daniel Martí \nUnity-Result: CUE porcuepine \n","tree":"15ba058f41b4f8afff0df4208d33d945bdfccfaf"},"mode":"0100644","name":"downgrade-existing.txtar","size":705},{"lastCommit":{"author":{"email":"mvdan@mvdan.cc","name":"Daniel Martí","when":"2024-12-13T14:49:55.000000Z"},"committer":{"email":"mvdan@mvdan.cc","name":"Daniel Martí","when":"2024-12-13T16:49:52.000000Z"},"hash":"2be40ea317c2abf98a053fad40f8ef121dc3c28a","message":"internal/mod/modload: sort module versions when adding a new dependency\n\nOtherwise, if a module already depends on foo.com@v0.0.1 and we run\n\n cue mod get bar.com@v0.0.1\n\nwe get a panic due to the new module version being out of order:\n\n panic: NewRequirements called with unsorted roots: [foo.com@v0.0.1 bar.com@v0.0.1]\n\nThe test case reproduced the panic without the fix.\nDue to the fact that the test panicked, we could not add it\nin an earlier commit to demonstrate the bug.\n\nAll other callers to modrequirements.NewRequirements obtain module\nversion lists from methods such as modfile.File.DepVersions,\nwhich are already guaranteed to be sorted. newVersions, however,\nis a newly constructed list taking the user's arguments\nand needs to be sorted before being used.\n\nFixes #3499.\n\nSigned-off-by: Daniel Martí \nChange-Id: I1543879981d3fa473aae53fecbffa136178c70bf\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1205761\nUnity-Result: CUE porcuepine \nTryBot-Result: CUEcueckoo \nReviewed-by: Rustam Abdullaev \n","tree":"6bb236f371955e32cad404f27750b567726d465c"},"mode":"0100644","name":"issue3499.txtar","size":753},{"lastCommit":{"author":{"email":"rogpeppe@gmail.com","name":"Roger Peppe","when":"2024-04-18T08:11:47.000000+01:00"},"committer":{"email":"rogpeppe@gmail.com","name":"Roger Peppe","when":"2024-04-18T16:48:57.000000Z"},"hash":"73b3df24ebc845d6181273e3faec577686295553","message":"mod/modfile: parse module.cue according to language.version\n\nThis change makes it possible to make changes to the\nmodule.cue schema while still using a closed schema\nfor earlier versions. We refuse module.cue files that\ndeclare a version newer than the current CUE version.\n\nThe language.version field is now mandatory in modules\nmode because otherwise we cannot tell which schema\nwe should be using.\n\nAlso remove the unimplemented features from the schema\nfor now: they're always there in the history and the proposal\nwhen we come to implement them, but they complicate\nthe schema for no good reason.\n\nOne unfortunate thing is that the error message when a field\nis defined that's explicitly unimplemented is not good.\nIn the absence of an `error` CUE builtin, we should be able to\nfix that in a subsequent CL by inspecting the error to see\nwhether any of the lines include the `unimplemented`\nidentifier.\n\nSigned-off-by: Roger Peppe \nChange-Id: I7bfef3b37e5b66bdbd8fe0614c1b815c7d9f1285\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1193275\nTryBot-Result: CUEcueckoo \nReviewed-by: Daniel Martí \nUnity-Result: CUE porcuepine \n","tree":"15ba058f41b4f8afff0df4208d33d945bdfccfaf"},"mode":"0100644","name":"upgrade-existing.txtar","size":679}],"lastCommit":{"author":{"email":"mvdan@mvdan.cc","name":"Daniel Martí","when":"2024-12-13T14:49:55.000000Z"},"committer":{"email":"mvdan@mvdan.cc","name":"Daniel Martí","when":"2024-12-13T16:49:52.000000Z"},"hash":"2be40ea317c2abf98a053fad40f8ef121dc3c28a","message":"internal/mod/modload: sort module versions when adding a new dependency\n\nOtherwise, if a module already depends on foo.com@v0.0.1 and we run\n\n cue mod get bar.com@v0.0.1\n\nwe get a panic due to the new module version being out of order:\n\n panic: NewRequirements called with unsorted roots: [foo.com@v0.0.1 bar.com@v0.0.1]\n\nThe test case reproduced the panic without the fix.\nDue to the fact that the test panicked, we could not add it\nin an earlier commit to demonstrate the bug.\n\nAll other callers to modrequirements.NewRequirements obtain module\nversion lists from methods such as modfile.File.DepVersions,\nwhich are already guaranteed to be sorted. newVersions, however,\nis a newly constructed list taking the user's arguments\nand needs to be sorted before being used.\n\nFixes #3499.\n\nSigned-off-by: Daniel Martí \nChange-Id: I1543879981d3fa473aae53fecbffa136178c70bf\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1205761\nUnity-Result: CUE porcuepine \nTryBot-Result: CUEcueckoo \nReviewed-by: Rustam Abdullaev \n","tree":"6bb236f371955e32cad404f27750b567726d465c"}}