From 8f8a5811d020fcaae5378b796740d1957bdc5b60 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Wed, 27 May 2026 12:46:29 +0100 Subject: [PATCH] internal/core/adt: remove unused Bottom.Permanent field MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This field stopped being written with https://cuelang.org/cl/1219923, which removed EvalV2-specific code. The sole reader at tools/flow/tasks.go was a conditional that could never fire, so drop it along with the field. Signed-off-by: Daniel Martí Change-Id: I9601aa587e81656e168dd9baa13ca156cf8b2ec6 Reviewed-on: https://cue.gerrithub.io/c/cue-lang/cue/+/1237934 Reviewed-by: Marcel van Lohuizen Unity-Result: CUE porcuepine TryBot-Result: CUEcueckoo --- internal/core/adt/errors.go | 6 +----- tools/flow/tasks.go | 5 ----- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/internal/core/adt/errors.go b/internal/core/adt/errors.go index 7c1ffbcf5..7b53e4f16 100644 --- a/internal/core/adt/errors.go +++ b/internal/core/adt/errors.go @@ -83,11 +83,7 @@ type Bottom struct { Src ast.Node Err errors.Error - Code ErrorCode - // Permanent indicates whether an incomplete error can be - // resolved later without making the configuration more specific. - // This may happen when an arc isn't fully resolved yet. - Permanent bool + Code ErrorCode HasRecursive bool ChildError bool // Err is the error of the child NotExists bool // This error originated from a failed lookup. diff --git a/tools/flow/tasks.go b/tools/flow/tasks.go index a6e74ef41..8b55a13c8 100644 --- a/tools/flow/tasks.go +++ b/tools/flow/tasks.go @@ -147,11 +147,6 @@ func (c *Controller) getTask(scope *Task, v cue.Value) *Task { return t } - if err := w.Err(c.opCtx); err != nil && err.Permanent { - c.addErr(err.Err, "invalid task") - return nil - } - // Look up cached task from previous evaluation. p := v.Path() key := p.String() -- 2.51.2