From 5efefe91b64706fff90ecf5df071d4a6f94e2fd5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Pacana?= Date: Mon, 25 May 2026 22:40:09 +0200 Subject: [PATCH] Rename append retry error - Use a domain-specific error name that describes the actual failure: append retries were exhausted after serialization conflicts. --- lib/en57.rb | 2 +- lib/en57/repository.rb | 2 +- test/test_repository.rb | 2 +- test/test_stress.rb | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/en57.rb b/lib/en57.rb index 8a46d09..8ef0864 100644 --- a/lib/en57.rb +++ b/lib/en57.rb @@ -16,7 +16,7 @@ require_relative "en57/configuration" module En57 Success = Data.define Failure = Data.define - SerializationError = Class.new(StandardError) + AppendRetriesExhausted = Class.new(StandardError) def self.configuration = Configuration.instance diff --git a/lib/en57/repository.rb b/lib/en57/repository.rb index 0c3ccf5..0d4c72e 100644 --- a/lib/en57/repository.rb +++ b/lib/en57/repository.rb @@ -64,7 +64,7 @@ module En57 retry end - raise SerializationError + raise AppendRetriesExhausted end end diff --git a/test/test_repository.rb b/test/test_repository.rb index 79d4957..cf6355a 100644 --- a/test/test_repository.rb +++ b/test/test_repository.rb @@ -563,7 +563,7 @@ module En57 connection.expect(:exec, nil, ["ROLLBACK"]) end - assert_raises(SerializationError) do + assert_raises(AppendRetriesExhausted) do Repository.new( PgAdapter.for_connection(connection), JsonSerializer.new, diff --git a/test/test_stress.rb b/test/test_stress.rb index 2ed88ec..6441ecb 100644 --- a/test/test_stress.rb +++ b/test/test_stress.rb @@ -42,7 +42,7 @@ module En57 ], fail_if: account_scope.of_type("CreditsUsed"), ) - rescue SerializationError => e + rescue AppendRetriesExhausted => e e end end @@ -51,7 +51,7 @@ module En57 assert_equal(1, results.select { Success === it }.size) assert_equal( (concurrency - 1), - results.select { Failure === it || SerializationError === it }.size, + results.select { Failure === it || AppendRetriesExhausted === it }.size, ) assert_equal( 1, -- 2.51.2