From afba377b1528530a14abfeb83459708140f30e18 Mon Sep 17 00:00:00 2001 From: Lubos Date: Wed, 25 Mar 2026 01:42:24 +0100 Subject: [PATCH] refactor: cleaner length syntax --- .../src/client/client/utils.gen.ts | 2 +- packages/codegen-core/src/config/load.ts | 2 +- packages/codegen-core/src/logger.ts | 2 +- packages/json-schema-ref-parser/src/bundle.ts | 4 ++-- packages/json-schema-ref-parser/src/index.ts | 16 ++++++------- .../json-schema-ref-parser/src/pointer.ts | 4 ++-- packages/json-schema-ref-parser/src/ref.ts | 2 +- packages/json-schema-ref-parser/src/refs.ts | 2 +- packages/openapi-python/src/cli/adapter.ts | 4 ++-- packages/openapi-python/src/generate.ts | 2 +- .../src/plugins/@hey-api/sdk/v1/node.ts | 2 +- .../src/plugins/pydantic/shared/export.ts | 2 +- .../src/plugins/pydantic/v2/processor.ts | 6 +++-- .../src/plugins/pydantic/v2/toAst/array.ts | 4 ++-- .../src/plugins/pydantic/v2/toAst/enum.ts | 4 ++-- .../plugins/pydantic/v2/toAst/intersection.ts | 17 +++++++------ .../src/plugins/pydantic/v2/toAst/tuple.ts | 8 +++---- .../src/plugins/pydantic/v2/toAst/union.ts | 9 ++++--- .../openapi-python/src/py-compiler/printer.ts | 4 ++-- .../openapi-python/src/py-dsl/decl/class.ts | 6 ++--- .../openapi-python/src/py-dsl/decl/func.ts | 4 ++-- .../openapi-python/src/py-dsl/decl/param.ts | 4 ++-- .../openapi-python/src/py-dsl/expr/attr.ts | 4 ++-- .../openapi-python/src/py-dsl/expr/binary.ts | 4 ++-- .../openapi-python/src/py-dsl/expr/call.ts | 4 ++-- .../src/py-dsl/mixins/decorator.ts | 2 +- .../src/py-dsl/mixins/modifiers.ts | 4 ++-- .../openapi-python/src/py-dsl/stmt/for.ts | 6 ++--- packages/openapi-python/src/py-dsl/stmt/if.ts | 6 ++--- .../openapi-python/src/py-dsl/stmt/try.ts | 6 ++--- .../openapi-python/src/py-dsl/stmt/var.ts | 4 ++-- .../openapi-python/src/py-dsl/stmt/while.ts | 6 ++--- .../openapi-python/src/py-dsl/stmt/with.ts | 6 ++--- .../src/py-dsl/utils/context.ts | 4 ++-- .../src/py-dsl/utils/render-utils.ts | 2 +- .../openapi-python/src/py-dsl/utils/render.ts | 2 +- .../axios/client/utils.gen.ts | 2 +- .../preact-query/axios/client/utils.gen.ts | 2 +- .../react-query/axios/client/utils.gen.ts | 2 +- .../solid-query/axios/client/utils.gen.ts | 2 +- .../svelte-query/axios/client/utils.gen.ts | 2 +- .../vue-query/axios/client/utils.gen.ts | 2 +- .../3.0.x/content-types/client/utils.gen.ts | 2 +- .../client/utils.gen.ts | 2 +- .../axios/client/utils.gen.ts | 2 +- .../preact-query/axios/client/utils.gen.ts | 2 +- .../react-query/axios/client/utils.gen.ts | 2 +- .../solid-query/axios/client/utils.gen.ts | 2 +- .../svelte-query/axios/client/utils.gen.ts | 2 +- .../vue-query/axios/client/utils.gen.ts | 2 +- .../base-url-false/client/utils.gen.ts | 2 +- .../base-url-number/client/utils.gen.ts | 2 +- .../base-url-strict/client/utils.gen.ts | 2 +- .../base-url-string/client/utils.gen.ts | 2 +- .../clean-false/client/utils.gen.ts | 2 +- .../client-axios/default/client/utils.gen.ts | 2 +- .../client/utils.gen.ts | 2 +- .../sdk-client-optional/client/utils.gen.ts | 2 +- .../sdk-client-required/client/utils.gen.ts | 2 +- .../tsconfig-node16-sdk/client/utils.gen.ts | 2 +- .../tsconfig-nodenext-sdk/client/utils.gen.ts | 2 +- .../3.1.x/content-types/client/utils.gen.ts | 2 +- .../client/utils.gen.ts | 2 +- .../axios/client/utils.gen.ts | 2 +- .../preact-query/axios/client/utils.gen.ts | 2 +- .../react-query/axios/client/utils.gen.ts | 2 +- .../solid-query/axios/client/utils.gen.ts | 2 +- .../svelte-query/axios/client/utils.gen.ts | 2 +- .../vue-query/axios/client/utils.gen.ts | 2 +- .../3.1.x/sse-axios/client/utils.gen.ts | 2 +- packages/openapi-ts/src/cli/adapter.ts | 4 ++-- packages/openapi-ts/src/generate.ts | 2 +- .../@hey-api/client-axios/bundle/utils.ts | 2 +- .../@hey-api/typescript/shared/operation.ts | 2 +- .../plugins/@hey-api/typescript/v1/plugin.ts | 2 +- .../@hey-api/typescript/v1/toAst/enum.ts | 4 ++-- .../@hey-api/typescript/v1/toAst/object.ts | 7 +++--- .../plugins/@hey-api/typescript/v1/walker.ts | 2 +- .../src/plugins/@pinia/colada/queryKey.ts | 2 +- .../src/plugins/@pinia/colada/queryOptions.ts | 2 +- .../plugins/@tanstack/query-core/queryKey.ts | 2 +- .../src/plugins/orpc/contracts/node.ts | 2 +- .../src/plugins/orpc/shared/operation.ts | 8 +++---- .../src/plugins/valibot/shared/pipes.ts | 2 +- .../plugins/valibot/v1/toAst/intersection.ts | 2 +- .../src/plugins/valibot/v1/toAst/union.ts | 2 +- .../src/plugins/zod/mini/toAst/enum.ts | 2 +- .../src/plugins/zod/mini/toAst/number.ts | 2 +- .../src/plugins/zod/mini/toAst/object.ts | 2 +- .../src/plugins/zod/mini/toAst/string.ts | 2 +- .../src/plugins/zod/mini/toAst/tuple.ts | 2 +- .../openapi-ts/src/plugins/zod/mini/walker.ts | 2 +- .../src/plugins/zod/v3/toAst/enum.ts | 2 +- .../src/plugins/zod/v3/toAst/object.ts | 2 +- .../src/plugins/zod/v3/toAst/tuple.ts | 2 +- .../openapi-ts/src/plugins/zod/v3/walker.ts | 2 +- .../src/plugins/zod/v4/toAst/enum.ts | 2 +- .../src/plugins/zod/v4/toAst/intersection.ts | 2 +- .../src/plugins/zod/v4/toAst/object.ts | 2 +- .../src/plugins/zod/v4/toAst/tuple.ts | 2 +- .../src/plugins/zod/v4/toAst/union.ts | 4 ++-- .../openapi-ts/src/plugins/zod/v4/walker.ts | 2 +- packages/openapi-ts/src/ts-dsl/decl/class.ts | 2 +- packages/openapi-ts/src/ts-dsl/decl/func.ts | 4 ++-- packages/openapi-ts/src/ts-dsl/decl/param.ts | 4 ++-- .../openapi-ts/src/ts-dsl/decl/pattern.ts | 4 ++-- packages/openapi-ts/src/ts-dsl/expr/binary.ts | 4 ++-- .../openapi-ts/src/ts-dsl/expr/postfix.ts | 4 ++-- packages/openapi-ts/src/ts-dsl/expr/prefix.ts | 4 ++-- packages/openapi-ts/src/ts-dsl/expr/prop.ts | 4 ++-- .../openapi-ts/src/ts-dsl/expr/template.ts | 4 ++-- .../openapi-ts/src/ts-dsl/expr/ternary.ts | 4 ++-- .../openapi-ts/src/ts-dsl/mixins/modifiers.ts | 24 +++++++++---------- .../openapi-ts/src/ts-dsl/mixins/optional.ts | 4 ++-- packages/openapi-ts/src/ts-dsl/stmt/for.ts | 4 ++-- packages/openapi-ts/src/ts-dsl/stmt/if.ts | 6 ++--- packages/openapi-ts/src/ts-dsl/stmt/try.ts | 6 ++--- packages/openapi-ts/src/ts-dsl/stmt/var.ts | 4 ++-- packages/openapi-ts/src/ts-dsl/token.ts | 4 ++-- packages/openapi-ts/src/ts-dsl/type/alias.ts | 4 ++-- packages/openapi-ts/src/ts-dsl/type/attr.ts | 4 ++-- packages/openapi-ts/src/ts-dsl/type/expr.ts | 4 ++-- packages/openapi-ts/src/ts-dsl/type/func.ts | 4 ++-- .../openapi-ts/src/ts-dsl/type/idx-sig.ts | 4 ++-- packages/openapi-ts/src/ts-dsl/type/idx.ts | 4 ++-- packages/openapi-ts/src/ts-dsl/type/mapped.ts | 4 ++-- .../openapi-ts/src/ts-dsl/type/operator.ts | 2 +- packages/openapi-ts/src/ts-dsl/type/prop.ts | 4 ++-- .../openapi-ts/src/ts-dsl/type/template.ts | 4 ++-- .../openapi-ts/src/ts-dsl/utils/context.ts | 4 ++-- .../openapi-ts/src/ts-dsl/utils/render.ts | 2 +- packages/shared/src/graph/walk.ts | 4 ++-- .../shared/src/openApi/3.0.x/parser/schema.ts | 4 ++-- .../shared/src/openApi/3.1.x/parser/schema.ts | 4 ++-- .../src/openApi/shared/locations/operation.ts | 4 ++-- .../transforms/propertiesRequiredByDefault.ts | 2 +- .../src/openApi/shared/transforms/schemas.ts | 2 +- 137 files changed, 236 insertions(+), 237 deletions(-) diff --git a/examples/openapi-ts-axios/src/client/client/utils.gen.ts b/examples/openapi-ts-axios/src/client/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/examples/openapi-ts-axios/src/client/client/utils.gen.ts +++ b/examples/openapi-ts-axios/src/client/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/codegen-core/src/config/load.ts b/packages/codegen-core/src/config/load.ts index 7af84d4e3..e5d0cebda 100644 --- a/packages/codegen-core/src/config/load.ts +++ b/packages/codegen-core/src/config/load.ts @@ -28,7 +28,7 @@ export async function loadConfigFile({ const fileConfigs = fileConfig instanceof Array ? fileConfig : [fileConfig]; const mergedConfigs = fileConfigs.map((config) => mergeConfigs(config, userConfig)); - const foundConfig = fileConfigs.some((config) => Object.keys(config).length > 0); + const foundConfig = fileConfigs.some((config) => Object.keys(config).length); return { configFile: loadedConfigFile, configs: mergedConfigs, foundConfig }; } diff --git a/packages/codegen-core/src/logger.ts b/packages/codegen-core/src/logger.ts index fec67bf82..4a5d4d49d 100644 --- a/packages/codegen-core/src/logger.ts +++ b/packages/codegen-core/src/logger.ts @@ -77,7 +77,7 @@ export class Logger { if (!event.end) { event.end = performance.mark(idEnd(event.id)); } - if (event.events.length > 0) { + if (event.events.length) { this.endAllEvents(event.events); } } diff --git a/packages/json-schema-ref-parser/src/bundle.ts b/packages/json-schema-ref-parser/src/bundle.ts index 8b7da1dec..2eec6493b 100644 --- a/packages/json-schema-ref-parser/src/bundle.ts +++ b/packages/json-schema-ref-parser/src/bundle.ts @@ -445,8 +445,8 @@ function remap(parser: $RefParser, inventory: Array) { const ensureContainer = ( type: 'schemas' | 'parameters' | 'requestBodies' | 'responses' | 'headers', ) => { - const isOas3 = !!(root && typeof root === 'object' && typeof root.openapi === 'string'); - const isOas2 = !!(root && typeof root === 'object' && typeof root.swagger === 'string'); + const isOas3 = Boolean(root && typeof root === 'object' && typeof root.openapi === 'string'); + const isOas2 = Boolean(root && typeof root === 'object' && typeof root.swagger === 'string'); if (isOas3) { if (!root.components || typeof root.components !== 'object') { diff --git a/packages/json-schema-ref-parser/src/index.ts b/packages/json-schema-ref-parser/src/index.ts index d0f7d5ac9..1471d0822 100644 --- a/packages/json-schema-ref-parser/src/index.ts +++ b/packages/json-schema-ref-parser/src/index.ts @@ -117,12 +117,12 @@ export class $RefParser { await resolveExternal(this, this.options); const errors = JSONParserErrorGroup.getParserErrors(this); - if (errors.length > 0) { + if (errors.length) { throw new JSONParserErrorGroup(this); } _bundle(this, this.options); const errors2 = JSONParserErrorGroup.getParserErrors(this); - if (errors2.length > 0) { + if (errors2.length) { throw new JSONParserErrorGroup(this); } return this.schema!; @@ -148,14 +148,14 @@ export class $RefParser { await resolveExternal(this, this.options); const errors = JSONParserErrorGroup.getParserErrors(this); - if (errors.length > 0) { + if (errors.length) { throw new JSONParserErrorGroup(this); } _bundle(this, this.options); // Merged root is ready for bundling const errors2 = JSONParserErrorGroup.getParserErrors(this); - if (errors2.length > 0) { + if (errors2.length) { throw new JSONParserErrorGroup(this); } return this.schema!; @@ -297,7 +297,7 @@ export class $RefParser { public mergeMany(): JSONSchema { const schemas = this.schemaMany || []; - if (schemas.length === 0) { + if (!schemas.length) { throw ono('mergeMany called with no schemas. Did you run parseMany?'); } @@ -335,7 +335,7 @@ export class $RefParser { } } } - if (Object.keys(infoAccumulator).length > 0) { + if (Object.keys(infoAccumulator).length) { merged.info = infoAccumulator; } @@ -356,7 +356,7 @@ export class $RefParser { } } } - if (servers.length > 0) { + if (servers.length) { merged.servers = servers; } @@ -568,7 +568,7 @@ export class $RefParser { } } - if (tags.length > 0) { + if (tags.length) { merged.tags = tags; } diff --git a/packages/json-schema-ref-parser/src/pointer.ts b/packages/json-schema-ref-parser/src/pointer.ts index b209c6283..1eedfc34f 100644 --- a/packages/json-schema-ref-parser/src/pointer.ts +++ b/packages/json-schema-ref-parser/src/pointer.ts @@ -140,7 +140,7 @@ class Pointer { } } - if (errors.length > 0) { + if (errors.length) { throw errors.length === 1 ? errors[0] : new AggregateError(errors, 'Multiple missing pointer errors'); @@ -171,7 +171,7 @@ class Pointer { const tokens = Pointer.parse(this.path); let token; - if (tokens.length === 0) { + if (!tokens.length) { // There are no tokens, replace the entire object with the new value this.value = value; return value; diff --git a/packages/json-schema-ref-parser/src/ref.ts b/packages/json-schema-ref-parser/src/ref.ts index 153bbb41a..620c70d77 100644 --- a/packages/json-schema-ref-parser/src/ref.ts +++ b/packages/json-schema-ref-parser/src/ref.ts @@ -152,7 +152,7 @@ class $Ref { value !== null && '$ref' in value && typeof value.$ref === 'string' && - value.$ref.length > 0 + Boolean(value.$ref.length) ); } diff --git a/packages/json-schema-ref-parser/src/refs.ts b/packages/json-schema-ref-parser/src/refs.ts index 4058eb13a..89e3fdef8 100644 --- a/packages/json-schema-ref-parser/src/refs.ts +++ b/packages/json-schema-ref-parser/src/refs.ts @@ -224,7 +224,7 @@ function getPaths($refs: $RefsMap, types: stri // Filter the paths by type types = Array.isArray(types[0]) ? types[0] : Array.prototype.slice.call(types); - if (types.length > 0 && types[0]) { + if (types.length && types[0]) { paths = paths.filter((key) => types.includes($refs[key]!.pathType as string)); } diff --git a/packages/openapi-python/src/cli/adapter.ts b/packages/openapi-python/src/cli/adapter.ts index 145b413d9..173c828a9 100644 --- a/packages/openapi-python/src/cli/adapter.ts +++ b/packages/openapi-python/src/cli/adapter.ts @@ -12,11 +12,11 @@ export const cliToConfig = (cli: CliOptions): Partial => { if (cli.dryRun !== undefined) config.dryRun = cli.dryRun; const plugins: ToArray = []; - if (cli.plugins instanceof Array && cli.plugins.length > 0) { + if (cli.plugins instanceof Array && cli.plugins.length) { plugins.push(...cli.plugins); } // if (cli.client) plugins.push(cli.client); - if (plugins.length > 0) config.plugins = plugins; + if (plugins.length) config.plugins = plugins; if (cli.debug || cli.silent || cli.logs || cli.logFile !== undefined) { config.logs = { diff --git a/packages/openapi-python/src/generate.ts b/packages/openapi-python/src/generate.ts index eeecea2a4..eff59fda2 100644 --- a/packages/openapi-python/src/generate.ts +++ b/packages/openapi-python/src/generate.ts @@ -63,7 +63,7 @@ export async function createClient( const configErrors = jobs.flatMap((job) => job.errors.map((error) => ({ error, jobIndex: job.index })), ); - if (configErrors.length > 0) { + if (configErrors.length) { throw new ConfigValidationError(configErrors); } diff --git a/packages/openapi-python/src/plugins/@hey-api/sdk/v1/node.ts b/packages/openapi-python/src/plugins/@hey-api/sdk/v1/node.ts index 79858d29f..89ac44208 100644 --- a/packages/openapi-python/src/plugins/@hey-api/sdk/v1/node.ts +++ b/packages/openapi-python/src/plugins/@hey-api/sdk/v1/node.ts @@ -119,7 +119,7 @@ function implementFn>(args: { const method = operation.method.toLowerCase(); const opParameters = operationParameters({ operation, plugin }); - if (plugin.config.paramsStructure === 'flat' && opParameters.fields.length > 0) { + if (plugin.config.paramsStructure === 'flat' && opParameters.fields.length) { const paramNames = opParameters.parameters.map((parameter) => parameter.name.toString()); const fieldsList = $.list(); diff --git a/packages/openapi-python/src/plugins/pydantic/shared/export.ts b/packages/openapi-python/src/plugins/pydantic/shared/export.ts index e7f75a330..a78a2fc58 100644 --- a/packages/openapi-python/src/plugins/pydantic/shared/export.ts +++ b/packages/openapi-python/src/plugins/pydantic/shared/export.ts @@ -117,7 +117,7 @@ function createFieldStatement( ...(needsAlias && !field.fieldConstraints?.alias && { alias: originalName }), }; - if (Object.keys(constraints).length > 0) { + if (Object.keys(constraints).length) { const fieldCall = createFieldCall(constraints, plugin, { required: !field.isOptional, }); diff --git a/packages/openapi-python/src/plugins/pydantic/v2/processor.ts b/packages/openapi-python/src/plugins/pydantic/v2/processor.ts index 2150856c4..23de6f1a2 100644 --- a/packages/openapi-python/src/plugins/pydantic/v2/processor.ts +++ b/packages/openapi-python/src/plugins/pydantic/v2/processor.ts @@ -15,9 +15,11 @@ export function createProcessor(plugin: PydanticPlugin['Instance']): ProcessorRe (ctx) => ctx.schema.type === 'object' && ctx.schema.properties !== undefined && - Object.keys(ctx.schema.properties).length > 0, + Boolean(Object.keys(ctx.schema.properties).length), (ctx) => - ctx.schema.type === 'enum' && ctx.schema.items !== undefined && ctx.schema.items.length > 0, + ctx.schema.type === 'enum' && + ctx.schema.items !== undefined && + Boolean(ctx.schema.items.length), plugin.config['~hooks']?.schemas?.shouldExtract, plugin.context.config.parser.hooks.schemas?.shouldExtract, ]; diff --git a/packages/openapi-python/src/plugins/pydantic/v2/toAst/array.ts b/packages/openapi-python/src/plugins/pydantic/v2/toAst/array.ts index 9d77e7fca..31984c3f3 100644 --- a/packages/openapi-python/src/plugins/pydantic/v2/toAst/array.ts +++ b/packages/openapi-python/src/plugins/pydantic/v2/toAst/array.ts @@ -11,7 +11,7 @@ function baseNode(ctx: ArrayResolverContext): PydanticType { const { applyModifiers, childResults, plugin } = ctx; const any = plugin.external('typing.Any'); - if (childResults.length === 0) { + if (!childResults.length) { return { type: $('list').slice(any), }; @@ -70,7 +70,7 @@ function arrayResolver(ctx: ArrayResolverContext): PydanticType { return { ...baseResult, - fieldConstraints: Object.keys(fieldConstraints).length > 0 ? fieldConstraints : undefined, + fieldConstraints: Object.keys(fieldConstraints).length ? fieldConstraints : undefined, }; } diff --git a/packages/openapi-python/src/plugins/pydantic/v2/toAst/enum.ts b/packages/openapi-python/src/plugins/pydantic/v2/toAst/enum.ts index be3975c17..c61636ce3 100644 --- a/packages/openapi-python/src/plugins/pydantic/v2/toAst/enum.ts +++ b/packages/openapi-python/src/plugins/pydantic/v2/toAst/enum.ts @@ -50,7 +50,7 @@ function baseNode(ctx: EnumResolverContext): PydanticType { const { plugin } = ctx; const { enumMembers } = ctx.nodes.items(ctx); - if (enumMembers.length === 0) { + if (!enumMembers.length) { return { type: plugin.external('typing.Any'), }; @@ -59,7 +59,7 @@ function baseNode(ctx: EnumResolverContext): PydanticType { const mode = plugin.config.enums ?? 'enum'; if (mode === 'literal') { - if (enumMembers.length === 0) { + if (!enumMembers.length) { return { type: plugin.external('typing.Any'), }; diff --git a/packages/openapi-python/src/plugins/pydantic/v2/toAst/intersection.ts b/packages/openapi-python/src/plugins/pydantic/v2/toAst/intersection.ts index e7e3f192c..9a9a51f35 100644 --- a/packages/openapi-python/src/plugins/pydantic/v2/toAst/intersection.ts +++ b/packages/openapi-python/src/plugins/pydantic/v2/toAst/intersection.ts @@ -14,7 +14,7 @@ import type { FieldConstraints } from '../constants'; function baseNode(ctx: IntersectionResolverContext): PydanticType { const { applyModifiers, childResults, plugin } = ctx; - if (childResults.length === 0) { + if (!childResults.length) { return { type: plugin.external('typing.Any'), }; @@ -60,9 +60,9 @@ function baseNode(ctx: IntersectionResolverContext): PydanticType { let type: VarType; - if (baseClasses.length > 0 && mergedFields.length === 0) { + if (baseClasses.length && !mergedFields.length) { type = baseClasses[0]!; - } else if (mergedFields.length > 0) { + } else if (mergedFields.length) { // TODO: replace type = '__INTERSECTION_PLACEHOLDER__'; } else { @@ -151,12 +151,11 @@ export function intersectionToType({ return { ...resolved, - baseClasses: baseClasses.length > 0 ? baseClasses : undefined, + baseClasses: baseClasses.length ? baseClasses : undefined, childResults, - fieldConstraints: - Object.keys(constraints).length > 0 - ? { ...constraints, ...resolved.fieldConstraints } - : resolved.fieldConstraints, - mergedFields: mergedFields.length > 0 ? mergedFields : undefined, + fieldConstraints: Object.keys(constraints).length + ? { ...constraints, ...resolved.fieldConstraints } + : resolved.fieldConstraints, + mergedFields: mergedFields.length ? mergedFields : undefined, }; } diff --git a/packages/openapi-python/src/plugins/pydantic/v2/toAst/tuple.ts b/packages/openapi-python/src/plugins/pydantic/v2/toAst/tuple.ts index 826af33a9..ebd3a6a2c 100644 --- a/packages/openapi-python/src/plugins/pydantic/v2/toAst/tuple.ts +++ b/packages/openapi-python/src/plugins/pydantic/v2/toAst/tuple.ts @@ -13,7 +13,7 @@ function baseNode(ctx: TupleResolverContext): PydanticType { const tuple = plugin.external('typing.Tuple'); const any = plugin.external('typing.Any'); - if (childResults.length === 0) { + if (!childResults.length) { return { type: $(tuple).slice(), }; @@ -28,7 +28,7 @@ function baseNode(ctx: TupleResolverContext): PydanticType { } } - if (itemTypes.length === 0) { + if (!itemTypes.length) { return { type: $(tuple).slice(any, '...'), }; @@ -57,7 +57,7 @@ function tupleResolver(ctx: TupleResolverContext): PydanticType { return { ...baseResult, - fieldConstraints: Object.keys(fieldConstraints).length > 0 ? fieldConstraints : undefined, + fieldConstraints: Object.keys(fieldConstraints).length ? fieldConstraints : undefined, }; } @@ -76,7 +76,7 @@ export function tupleToType(ctx: { const childResults: Array = []; - if (schema.items && schema.items.length > 0) { + if (schema.items && schema.items.length) { for (let i = 0; i < schema.items.length; i++) { const item = schema.items[i]!; const result = walk(item, childContext(walkerCtx, 'items', i)); diff --git a/packages/openapi-python/src/plugins/pydantic/v2/toAst/union.ts b/packages/openapi-python/src/plugins/pydantic/v2/toAst/union.ts index 83c96608c..16a05a956 100644 --- a/packages/openapi-python/src/plugins/pydantic/v2/toAst/union.ts +++ b/packages/openapi-python/src/plugins/pydantic/v2/toAst/union.ts @@ -22,7 +22,7 @@ function baseNode(ctx: UnionResolverContext): PydanticType { isNullable = isNullable || childResults.some((r) => r.meta.nullable); - if (nonNullResults.length === 0) { + if (!nonNullResults.length) { return { type: 'None', }; @@ -103,10 +103,9 @@ export function unionToType({ return { ...resolved, childResults, - fieldConstraints: - Object.keys(constraints).length > 0 - ? { ...constraints, ...resolved.fieldConstraints } - : resolved.fieldConstraints, + fieldConstraints: Object.keys(constraints).length + ? { ...constraints, ...resolved.fieldConstraints } + : resolved.fieldConstraints, isNullable, }; } diff --git a/packages/openapi-python/src/py-compiler/printer.ts b/packages/openapi-python/src/py-compiler/printer.ts index c1bbb3a6f..c22b996b4 100644 --- a/packages/openapi-python/src/py-compiler/printer.ts +++ b/packages/openapi-python/src/py-compiler/printer.ts @@ -249,7 +249,7 @@ export function createPrinter(options?: PyPrinterOptions) { case PyNodeKind.ImportStatement: { const fromPrefix = node.isFrom ? `from ${node.module} ` : ''; if (fromPrefix) { - if (node.names && node.names.length > 0) { + if (node.names && node.names.length) { const imports = node.names .map(({ alias, name }) => (alias ? `${name} as ${alias}` : name)) .join(', '); @@ -258,7 +258,7 @@ export function createPrinter(options?: PyPrinterOptions) { parts.push(printLine(`${fromPrefix}import *`)); } } else { - if (node.names && node.names.length > 0) { + if (node.names && node.names.length) { const imports = node.names .map(({ alias, name }) => (alias ? `${name} as ${alias}` : name)) .join(', '); diff --git a/packages/openapi-python/src/py-dsl/decl/class.ts b/packages/openapi-python/src/py-dsl/decl/class.ts index 2c36dccd9..c73c76a5a 100644 --- a/packages/openapi-python/src/py-dsl/decl/class.ts +++ b/packages/openapi-python/src/py-dsl/decl/class.ts @@ -47,12 +47,12 @@ export class ClassPyDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } /** Returns true if the class has any members. */ get hasBody(): boolean { - return this.body.length > 0; + return Boolean(this.body.length); } /** Adds one or more class members (fields, methods, etc.). */ @@ -107,7 +107,7 @@ export class ClassPyDsl extends Mixed { $validate(): asserts this { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Class declaration missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-python/src/py-dsl/decl/func.ts b/packages/openapi-python/src/py-dsl/decl/func.ts index ece6e5e88..eeda3aee2 100644 --- a/packages/openapi-python/src/py-dsl/decl/func.ts +++ b/packages/openapi-python/src/py-dsl/decl/func.ts @@ -50,7 +50,7 @@ export class FuncPyDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } override toAst() { @@ -68,7 +68,7 @@ export class FuncPyDsl extends Mixed { $validate(): asserts this { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Function declaration missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-python/src/py-dsl/decl/param.ts b/packages/openapi-python/src/py-dsl/decl/param.ts index 9637d0b05..94aaeaf28 100644 --- a/packages/openapi-python/src/py-dsl/decl/param.ts +++ b/packages/openapi-python/src/py-dsl/decl/param.ts @@ -41,7 +41,7 @@ export class ParamPyDsl extends PyDsl { } get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } /** Sets the parameter type. */ @@ -61,7 +61,7 @@ export class ParamPyDsl extends PyDsl { $validate(): asserts this { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Parameter missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-python/src/py-dsl/expr/attr.ts b/packages/openapi-python/src/py-dsl/expr/attr.ts index fb90ce285..1d95e89f0 100644 --- a/packages/openapi-python/src/py-dsl/expr/attr.ts +++ b/packages/openapi-python/src/py-dsl/expr/attr.ts @@ -31,7 +31,7 @@ export class AttrPyDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } override toAst() { @@ -50,7 +50,7 @@ export class AttrPyDsl extends Mixed { left: MaybePyDsl; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Attribute access missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-python/src/py-dsl/expr/binary.ts b/packages/openapi-python/src/py-dsl/expr/binary.ts index d73828b48..dea9f29e2 100644 --- a/packages/openapi-python/src/py-dsl/expr/binary.ts +++ b/packages/openapi-python/src/py-dsl/expr/binary.ts @@ -54,7 +54,7 @@ export class BinaryPyDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } and(right: MaybePyDsl): this { @@ -149,7 +149,7 @@ export class BinaryPyDsl extends Mixed { _right: MaybePyDsl; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Binary expression missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-python/src/py-dsl/expr/call.ts b/packages/openapi-python/src/py-dsl/expr/call.ts index 3ef051ad9..89a992abe 100644 --- a/packages/openapi-python/src/py-dsl/expr/call.ts +++ b/packages/openapi-python/src/py-dsl/expr/call.ts @@ -32,7 +32,7 @@ export class CallPyDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } override toAst() { @@ -45,7 +45,7 @@ export class CallPyDsl extends Mixed { _callee: MaybePyDsl; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Call expression missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-python/src/py-dsl/mixins/decorator.ts b/packages/openapi-python/src/py-dsl/mixins/decorator.ts index 606f138dc..5d449998d 100644 --- a/packages/openapi-python/src/py-dsl/mixins/decorator.ts +++ b/packages/openapi-python/src/py-dsl/mixins/decorator.ts @@ -40,7 +40,7 @@ export function DecoratorMixin>(Bas protected $decorators(): ReadonlyArray { return this._decorators.map((decorator) => - decorator.args.length > 0 + decorator.args.length ? py.factory.createCallExpression( this.$node(decorator.name), decorator.args.map((arg) => this.$node(arg)), diff --git a/packages/openapi-python/src/py-dsl/mixins/modifiers.ts b/packages/openapi-python/src/py-dsl/mixins/modifiers.ts index ca07bae19..580b479ac 100644 --- a/packages/openapi-python/src/py-dsl/mixins/modifiers.ts +++ b/packages/openapi-python/src/py-dsl/mixins/modifiers.ts @@ -77,7 +77,7 @@ export function AsyncMixin>(Base: T abstract class Async extends Mixed { protected async(condition?: boolean): this { - const cond = arguments.length === 0 ? true : Boolean(condition); + const cond = !arguments.length ? true : Boolean(condition); return this._m('async', cond); } } @@ -109,7 +109,7 @@ export function ExportMixin>(Base: * @returns The target object for chaining. */ protected export(condition?: boolean): this { - const cond = arguments.length === 0 ? true : Boolean(condition); + const cond = !arguments.length ? true : Boolean(condition); this.exported = cond; // TODO: remove this side-effect once planner handles exported flag if (this.symbol) this.symbol.setExported(cond); diff --git a/packages/openapi-python/src/py-dsl/stmt/for.ts b/packages/openapi-python/src/py-dsl/stmt/for.ts index 126c514aa..b10426b33 100644 --- a/packages/openapi-python/src/py-dsl/stmt/for.ts +++ b/packages/openapi-python/src/py-dsl/stmt/for.ts @@ -54,7 +54,7 @@ export class ForPyDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } body(...items: Array): this { @@ -87,7 +87,7 @@ export class ForPyDsl extends Mixed { _target: MaybePyDsl; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`For statement missing ${missing.join(' and ')}`); } @@ -95,7 +95,7 @@ export class ForPyDsl extends Mixed { const missing: Array = []; if (!this._target) missing.push('target'); if (!this._iterable) missing.push('iterable'); - if (!this._body || this._body.length === 0) missing.push('body'); + if (!this._body || !this._body.length) missing.push('body'); return missing; } } diff --git a/packages/openapi-python/src/py-dsl/stmt/if.ts b/packages/openapi-python/src/py-dsl/stmt/if.ts index 33e6c2e3f..91d375275 100644 --- a/packages/openapi-python/src/py-dsl/stmt/if.ts +++ b/packages/openapi-python/src/py-dsl/stmt/if.ts @@ -39,7 +39,7 @@ export class IfPyDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } condition(condition: IfCondition): this { @@ -69,14 +69,14 @@ export class IfPyDsl extends Mixed { _condition: IfCondition; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`If statement missing ${missing.join(' and ')}`); } private missingRequiredCalls(): ReadonlyArray { const missing: Array = []; if (!this._condition) missing.push('.condition()'); - if (this._do.length === 0) missing.push('.do()'); + if (!this._do.length) missing.push('.do()'); return missing; } } diff --git a/packages/openapi-python/src/py-dsl/stmt/try.ts b/packages/openapi-python/src/py-dsl/stmt/try.ts index 6646d5803..082f7ca0d 100644 --- a/packages/openapi-python/src/py-dsl/stmt/try.ts +++ b/packages/openapi-python/src/py-dsl/stmt/try.ts @@ -80,7 +80,7 @@ export class TryPyDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } /** @@ -200,13 +200,13 @@ export class TryPyDsl extends Mixed { _try: Array; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Try statement missing ${missing.join(' and ')}`); } private missingRequiredCalls(): ReadonlyArray { const missing: Array = []; - if (!this._try || this._try.length === 0) missing.push('.try()'); + if (!this._try || !this._try.length) missing.push('.try()'); return missing; } diff --git a/packages/openapi-python/src/py-dsl/stmt/var.ts b/packages/openapi-python/src/py-dsl/stmt/var.ts index 826e76327..c4aafc125 100644 --- a/packages/openapi-python/src/py-dsl/stmt/var.ts +++ b/packages/openapi-python/src/py-dsl/stmt/var.ts @@ -32,7 +32,7 @@ export class VarPyDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } /** Sets the type annotation for the variable. */ @@ -52,7 +52,7 @@ export class VarPyDsl extends Mixed { $validate(): asserts this { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Variable assignment missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-python/src/py-dsl/stmt/while.ts b/packages/openapi-python/src/py-dsl/stmt/while.ts index 8f89ec926..18d2be1aa 100644 --- a/packages/openapi-python/src/py-dsl/stmt/while.ts +++ b/packages/openapi-python/src/py-dsl/stmt/while.ts @@ -47,7 +47,7 @@ export class WhilePyDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } body(...items: Array): this { @@ -78,14 +78,14 @@ export class WhilePyDsl extends Mixed { _condition: MaybePyDsl; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`While statement missing ${missing.join(' and ')}`); } private missingRequiredCalls(): ReadonlyArray { const missing: Array = []; if (!this._condition) missing.push('condition'); - if (!this._body || this._body.length === 0) missing.push('body'); + if (!this._body || !this._body.length) missing.push('body'); return missing; } } diff --git a/packages/openapi-python/src/py-dsl/stmt/with.ts b/packages/openapi-python/src/py-dsl/stmt/with.ts index 7c5cfb50a..57fff35f8 100644 --- a/packages/openapi-python/src/py-dsl/stmt/with.ts +++ b/packages/openapi-python/src/py-dsl/stmt/with.ts @@ -49,7 +49,7 @@ export class WithPyDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } body(...items: Array): this { @@ -95,14 +95,14 @@ export class WithPyDsl extends Mixed { _body: Array; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`With statement missing ${missing.join(' and ')}`); } private missingRequiredCalls(): ReadonlyArray { const missing: Array = []; if (!this._items.length) missing.push('items'); - if (!this._body || this._body.length === 0) missing.push('.body()'); + if (!this._body || !this._body.length) missing.push('.body()'); return missing; } } diff --git a/packages/openapi-python/src/py-dsl/utils/context.ts b/packages/openapi-python/src/py-dsl/utils/context.ts index dfb1651b8..619e2e019 100644 --- a/packages/openapi-python/src/py-dsl/utils/context.ts +++ b/packages/openapi-python/src/py-dsl/utils/context.ts @@ -60,7 +60,7 @@ export interface ExampleOptions { // function getAccessChainForNode(node: PyDsl): NodeChain { // const structuralChain = [...getStructuralChainForNode(node, new Set())]; // const accessChain = structuralToAccessChain(structuralChain); -// if (accessChain.length === 0) { +// if (!accessChain.length) { // // I _think_ this should not happen, but it does and this fix works for now. // // I assume this will cause issues with imports in some cases, investigate // // when it actually happens. @@ -84,7 +84,7 @@ export interface ExampleOptions { // if (getScope(parent) !== getScope(node)) continue; // const chain = getStructuralChainForNode(parent, visited); -// if (chain.length > 0) return [...chain, node]; +// if (chain.length) return [...chain, node]; // } // } diff --git a/packages/openapi-python/src/py-dsl/utils/render-utils.ts b/packages/openapi-python/src/py-dsl/utils/render-utils.ts index d8697851a..aedbf53f7 100644 --- a/packages/openapi-python/src/py-dsl/utils/render-utils.ts +++ b/packages/openapi-python/src/py-dsl/utils/render-utils.ts @@ -82,7 +82,7 @@ export function moduleSortKey({ pathSegments.push(moduleName); } - modulePath = pathSegments.length > 0 ? leadingDots + pathSegments.join('.') : leadingDots; + modulePath = pathSegments.length ? leadingDots + pathSegments.join('.') : leadingDots; return [2, parentCount, modulePath]; } diff --git a/packages/openapi-python/src/py-dsl/utils/render.ts b/packages/openapi-python/src/py-dsl/utils/render.ts index 1aaac5655..88e8d449a 100644 --- a/packages/openapi-python/src/py-dsl/utils/render.ts +++ b/packages/openapi-python/src/py-dsl/utils/render.ts @@ -176,7 +176,7 @@ export class PythonRenderer implements Renderer { alias: imp.localName !== imp.sourceName ? imp.localName : undefined, name: imp.sourceName, })); - return py.factory.createImportStatement(group.modulePath, names, group.imports.length > 0); + return py.factory.createImportStatement(group.modulePath, names, Boolean(group.imports.length)); } private getExports(ctx: RenderContext): Exports { diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/angular-query-experimental/axios/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/angular-query-experimental/axios/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/angular-query-experimental/axios/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/angular-query-experimental/axios/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/preact-query/axios/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/preact-query/axios/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/preact-query/axios/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/preact-query/axios/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/react-query/axios/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/react-query/axios/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/react-query/axios/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/react-query/axios/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/solid-query/axios/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/solid-query/axios/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/solid-query/axios/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/solid-query/axios/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/svelte-query/axios/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/svelte-query/axios/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/svelte-query/axios/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/svelte-query/axios/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/vue-query/axios/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/vue-query/axios/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/vue-query/axios/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/vue-query/axios/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/content-types/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/content-types/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/content-types/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/content-types/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/parameter-explode-false-axios/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/parameter-explode-false-axios/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/parameter-explode-false-axios/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/parameter-explode-false-axios/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/angular-query-experimental/axios/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/angular-query-experimental/axios/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/angular-query-experimental/axios/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/angular-query-experimental/axios/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/preact-query/axios/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/preact-query/axios/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/preact-query/axios/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/preact-query/axios/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/react-query/axios/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/react-query/axios/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/react-query/axios/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/react-query/axios/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/solid-query/axios/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/solid-query/axios/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/solid-query/axios/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/solid-query/axios/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/svelte-query/axios/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/svelte-query/axios/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/svelte-query/axios/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/svelte-query/axios/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/vue-query/axios/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/vue-query/axios/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/vue-query/axios/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/vue-query/axios/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/base-url-false/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/base-url-false/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/base-url-false/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/base-url-false/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/base-url-number/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/base-url-number/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/base-url-number/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/base-url-number/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/base-url-strict/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/base-url-strict/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/base-url-strict/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/base-url-strict/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/base-url-string/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/base-url-string/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/base-url-string/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/base-url-string/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/clean-false/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/clean-false/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/clean-false/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/clean-false/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/default/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/default/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/default/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/default/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/import-file-extension-ts/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/import-file-extension-ts/client/utils.gen.ts index da1fcb9f7..59fb4dcd1 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/import-file-extension-ts/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/import-file-extension-ts/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/sdk-client-optional/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/sdk-client-optional/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/sdk-client-optional/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/sdk-client-optional/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/sdk-client-required/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/sdk-client-required/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/sdk-client-required/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/sdk-client-required/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/tsconfig-node16-sdk/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/tsconfig-node16-sdk/client/utils.gen.ts index 04c8f9916..b17878ca4 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/tsconfig-node16-sdk/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/tsconfig-node16-sdk/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/tsconfig-nodenext-sdk/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/tsconfig-nodenext-sdk/client/utils.gen.ts index 04c8f9916..b17878ca4 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/tsconfig-nodenext-sdk/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-axios/tsconfig-nodenext-sdk/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/content-types/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/content-types/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/content-types/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/content-types/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/parameter-explode-false-axios/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/parameter-explode-false-axios/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/parameter-explode-false-axios/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/parameter-explode-false-axios/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/angular-query-experimental/axios/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/angular-query-experimental/axios/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/angular-query-experimental/axios/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/angular-query-experimental/axios/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/preact-query/axios/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/preact-query/axios/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/preact-query/axios/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/preact-query/axios/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/react-query/axios/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/react-query/axios/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/react-query/axios/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/react-query/axios/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/solid-query/axios/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/solid-query/axios/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/solid-query/axios/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/solid-query/axios/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/svelte-query/axios/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/svelte-query/axios/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/svelte-query/axios/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/svelte-query/axios/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/vue-query/axios/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/vue-query/axios/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/vue-query/axios/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/vue-query/axios/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/sse-axios/client/utils.gen.ts b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/sse-axios/client/utils.gen.ts index 67ded7e4d..ee02336a3 100644 --- a/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/sse-axios/client/utils.gen.ts +++ b/packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/sse-axios/client/utils.gen.ts @@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts/src/cli/adapter.ts b/packages/openapi-ts/src/cli/adapter.ts index e125cfc34..c9b1b7a03 100644 --- a/packages/openapi-ts/src/cli/adapter.ts +++ b/packages/openapi-ts/src/cli/adapter.ts @@ -12,11 +12,11 @@ export function cliToConfig(cli: CliOptions): Partial { if (cli.dryRun !== undefined) config.dryRun = cli.dryRun; const plugins: ToArray = []; - if (cli.plugins instanceof Array && cli.plugins.length > 0) { + if (cli.plugins instanceof Array && cli.plugins.length) { plugins.push(...cli.plugins); } if (cli.client) plugins.push(cli.client); - if (plugins.length > 0) config.plugins = plugins; + if (plugins.length) config.plugins = plugins; if (cli.debug || cli.silent || cli.logs || cli.logFile === false) { config.logs = { diff --git a/packages/openapi-ts/src/generate.ts b/packages/openapi-ts/src/generate.ts index eeecea2a4..eff59fda2 100644 --- a/packages/openapi-ts/src/generate.ts +++ b/packages/openapi-ts/src/generate.ts @@ -63,7 +63,7 @@ export async function createClient( const configErrors = jobs.flatMap((job) => job.errors.map((error) => ({ error, jobIndex: job.index })), ); - if (configErrors.length > 0) { + if (configErrors.length) { throw new ConfigValidationError(configErrors); } diff --git a/packages/openapi-ts/src/plugins/@hey-api/client-axios/bundle/utils.ts b/packages/openapi-ts/src/plugins/@hey-api/client-axios/bundle/utils.ts index 44f05c25a..1fdde0367 100644 --- a/packages/openapi-ts/src/plugins/@hey-api/client-axios/bundle/utils.ts +++ b/packages/openapi-ts/src/plugins/@hey-api/client-axios/bundle/utils.ts @@ -128,7 +128,7 @@ export const buildUrl: Client['buildUrl'] = (options) => { const instanceBaseUrl = options.axios?.defaults?.baseURL; const baseUrl = - !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; + options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl; return getUrl({ baseUrl: baseUrl as string, diff --git a/packages/openapi-ts/src/plugins/@hey-api/typescript/shared/operation.ts b/packages/openapi-ts/src/plugins/@hey-api/typescript/shared/operation.ts index f48c57c98..afef704b0 100644 --- a/packages/openapi-ts/src/plugins/@hey-api/typescript/shared/operation.ts +++ b/packages/openapi-ts/src/plugins/@hey-api/typescript/shared/operation.ts @@ -99,7 +99,7 @@ export const operationToType = ({ dataRequired.push('url'); - if (dataRequired.length > 0) { + if (dataRequired.length) { data.required = dataRequired; } diff --git a/packages/openapi-ts/src/plugins/@hey-api/typescript/v1/plugin.ts b/packages/openapi-ts/src/plugins/@hey-api/typescript/v1/plugin.ts index b277d0d0f..9e40739c9 100644 --- a/packages/openapi-ts/src/plugins/@hey-api/typescript/v1/plugin.ts +++ b/packages/openapi-ts/src/plugins/@hey-api/typescript/v1/plugin.ts @@ -96,7 +96,7 @@ export const handlerV1: HeyApiTypeScriptPlugin['Handler'] = ({ plugin }) => { createClientOptions({ nodeIndex: nodeClientIndex, plugin, servers }); - if (webhooks.length > 0) { + if (webhooks.length) { const symbol = plugin.registerSymbol( buildSymbolIn({ meta: { diff --git a/packages/openapi-ts/src/plugins/@hey-api/typescript/v1/toAst/enum.ts b/packages/openapi-ts/src/plugins/@hey-api/typescript/v1/toAst/enum.ts index a05cd834d..38ca70a5e 100644 --- a/packages/openapi-ts/src/plugins/@hey-api/typescript/v1/toAst/enum.ts +++ b/packages/openapi-ts/src/plugins/@hey-api/typescript/v1/toAst/enum.ts @@ -63,14 +63,14 @@ function baseNode(ctx: EnumResolverContext): Type { const { schema } = ctx; const items = schema.items ?? []; - if (items.length === 0) { + if (!items.length) { return $.type('never'); } const literalTypes = items .filter((item) => item.const !== undefined) .map((item) => $.type.fromValue(item.const)); - return literalTypes.length > 0 ? $.type.or(...literalTypes) : $.type('string'); + return literalTypes.length ? $.type.or(...literalTypes) : $.type('string'); } function enumResolver(ctx: EnumResolverContext): Type { diff --git a/packages/openapi-ts/src/plugins/@hey-api/typescript/v1/toAst/object.ts b/packages/openapi-ts/src/plugins/@hey-api/typescript/v1/toAst/object.ts index 8685379ac..372dc5206 100644 --- a/packages/openapi-ts/src/plugins/@hey-api/typescript/v1/toAst/object.ts +++ b/packages/openapi-ts/src/plugins/@hey-api/typescript/v1/toAst/object.ts @@ -54,14 +54,13 @@ function baseNode(ctx: ObjectResolverContext): Type { } } - const hasPatterns = - !!schema.patternProperties && Object.keys(schema.patternProperties).length > 0; + const hasPatterns = schema.patternProperties && Object.keys(schema.patternProperties).length; const addPropsRaw = schema.additionalProperties; const addPropsObj = addPropsRaw !== false && addPropsRaw ? (addPropsRaw as IR.SchemaObject) : undefined; const shouldCreateIndex = - hasPatterns || (!!addPropsObj && (addPropsObj.type !== 'never' || !indexSchemas.length)); + hasPatterns || (addPropsObj && (addPropsObj.type !== 'never' || !indexSchemas.length)); if (shouldCreateIndex) { const addProps = addPropsObj; @@ -82,7 +81,7 @@ function baseNode(ctx: ObjectResolverContext): Type { indexSchemas.push({ type: 'undefined' }); } - if (indexSchemas.length > 0) { + if (indexSchemas.length) { const unionSchema: IR.SchemaObject = indexSchemas.length === 1 ? indexSchemas[0]! diff --git a/packages/openapi-ts/src/plugins/@hey-api/typescript/v1/walker.ts b/packages/openapi-ts/src/plugins/@hey-api/typescript/v1/walker.ts index c6a9482c3..2f7059574 100644 --- a/packages/openapi-ts/src/plugins/@hey-api/typescript/v1/walker.ts +++ b/packages/openapi-ts/src/plugins/@hey-api/typescript/v1/walker.ts @@ -157,7 +157,7 @@ export function createVisitor( resourceId: $ref, }); - if (schema.omit && schema.omit.length > 0) { + if (schema.omit && schema.omit.length) { const omittedKeys = schema.omit.length === 1 ? $.type.literal(schema.omit[0]!) diff --git a/packages/openapi-ts/src/plugins/@pinia/colada/queryKey.ts b/packages/openapi-ts/src/plugins/@pinia/colada/queryKey.ts index f9ef381e9..645993a36 100644 --- a/packages/openapi-ts/src/plugins/@pinia/colada/queryKey.ts +++ b/packages/openapi-ts/src/plugins/@pinia/colada/queryKey.ts @@ -118,7 +118,7 @@ const createQueryKeyLiteral = ({ }) => { const config = plugin.config.queryKeys; let tagsExpression: ReturnType | undefined; - if (config.tags && operation.tags && operation.tags.length > 0) { + if (config.tags && operation.tags && operation.tags.length) { tagsExpression = $.array(...operation.tags.map((tag) => $.literal(tag))); } diff --git a/packages/openapi-ts/src/plugins/@pinia/colada/queryOptions.ts b/packages/openapi-ts/src/plugins/@pinia/colada/queryOptions.ts index 6f6d914a6..6889a107e 100644 --- a/packages/openapi-ts/src/plugins/@pinia/colada/queryOptions.ts +++ b/packages/openapi-ts/src/plugins/@pinia/colada/queryOptions.ts @@ -62,7 +62,7 @@ export const createQueryOptions = ({ }); // Optionally include tags when configured let tagsExpr: ReturnType | undefined; - if (plugin.config.queryKeys.tags && operation.tags && operation.tags.length > 0) { + if (plugin.config.queryKeys.tags && operation.tags && operation.tags.length) { tagsExpr = $.array(...operation.tags.map((t) => $.literal(t))); } keyExpression = $(symbolCreateQueryKey).call( diff --git a/packages/openapi-ts/src/plugins/@tanstack/query-core/queryKey.ts b/packages/openapi-ts/src/plugins/@tanstack/query-core/queryKey.ts index 319df26e5..f27a483eb 100644 --- a/packages/openapi-ts/src/plugins/@tanstack/query-core/queryKey.ts +++ b/packages/openapi-ts/src/plugins/@tanstack/query-core/queryKey.ts @@ -109,7 +109,7 @@ const createQueryKeyLiteral = ({ }) => { const config = isInfinite ? plugin.config.infiniteQueryKeys : plugin.config.queryKeys; let tagsArray: TsDsl | undefined; - if (config.tags && operation.tags && operation.tags.length > 0) { + if (config.tags && operation.tags && operation.tags.length) { tagsArray = $.array().elements(...operation.tags); } const symbolCreateQueryKey = plugin.referenceSymbol({ diff --git a/packages/openapi-ts/src/plugins/orpc/contracts/node.ts b/packages/openapi-ts/src/plugins/orpc/contracts/node.ts index e83b30458..a19a0590f 100644 --- a/packages/openapi-ts/src/plugins/orpc/contracts/node.ts +++ b/packages/openapi-ts/src/plugins/orpc/contracts/node.ts @@ -73,7 +73,7 @@ function createContractExpression( (o, v) => o.prop('successStatus', $.literal(v)), ) .$if(operation.summary, (o, v) => o.prop('summary', $.literal(v))) - .$if(tags.length > 0 && tags, (o, v) => o.prop('tags', $.fromValue(v))), + .$if(Boolean(tags.length) && tags, (o, v) => o.prop('tags', $.fromValue(v))), ); if (hasInput(operation) && plugin.config.validator.input) { diff --git a/packages/openapi-ts/src/plugins/orpc/shared/operation.ts b/packages/openapi-ts/src/plugins/orpc/shared/operation.ts index b541a304f..3d64eddf1 100644 --- a/packages/openapi-ts/src/plugins/orpc/shared/operation.ts +++ b/packages/openapi-ts/src/plugins/orpc/shared/operation.ts @@ -2,13 +2,13 @@ import type { IR } from '@hey-api/shared'; export function hasInput(operation: IR.OperationObject): boolean { const hasPathParams = Boolean( - operation.parameters?.path && Object.keys(operation.parameters.path).length > 0, + operation.parameters?.path && Object.keys(operation.parameters.path).length, ); const hasQueryParams = Boolean( - operation.parameters?.query && Object.keys(operation.parameters.query).length > 0, + operation.parameters?.query && Object.keys(operation.parameters.query).length, ); const hasHeaderParams = Boolean( - operation.parameters?.header && Object.keys(operation.parameters.header).length > 0, + operation.parameters?.header && Object.keys(operation.parameters.header).length, ); const hasBody = Boolean(operation.body); return hasPathParams || hasQueryParams || hasHeaderParams || hasBody; @@ -34,5 +34,5 @@ export function getSuccessResponse( } export function getTags(operation: IR.OperationObject, defaultTag: string): ReadonlyArray { - return operation.tags && operation.tags.length > 0 ? [...operation.tags] : [defaultTag]; + return operation.tags && operation.tags.length ? [...operation.tags] : [defaultTag]; } diff --git a/packages/openapi-ts/src/plugins/valibot/shared/pipes.ts b/packages/openapi-ts/src/plugins/valibot/shared/pipes.ts index 900dbbbe8..1c8ba9c68 100644 --- a/packages/openapi-ts/src/plugins/valibot/shared/pipes.ts +++ b/packages/openapi-ts/src/plugins/valibot/shared/pipes.ts @@ -35,7 +35,7 @@ function toNode(pipes: Pipes | Pipe, plugin: ValibotPlugin['Instance']): Pipe { if (!(pipes instanceof Array)) { return pipes; } - if (pipes.length === 0) { + if (!pipes.length) { const v = plugin.external('valibot.v'); return $(v).attr(identifiers.schemas.unknown).call(); } diff --git a/packages/openapi-ts/src/plugins/valibot/v1/toAst/intersection.ts b/packages/openapi-ts/src/plugins/valibot/v1/toAst/intersection.ts index 59aa53aaf..f9e88ef80 100644 --- a/packages/openapi-ts/src/plugins/valibot/v1/toAst/intersection.ts +++ b/packages/openapi-ts/src/plugins/valibot/v1/toAst/intersection.ts @@ -12,7 +12,7 @@ function baseNode(ctx: IntersectionResolverContext): PipeResult { const { applyModifiers, childResults, plugin, symbols } = ctx; const { v } = symbols; - if (childResults.length === 0) { + if (!childResults.length) { return $(v).attr(identifiers.schemas.any).call(); } diff --git a/packages/openapi-ts/src/plugins/valibot/v1/toAst/union.ts b/packages/openapi-ts/src/plugins/valibot/v1/toAst/union.ts index 8500cee00..ab85fef82 100644 --- a/packages/openapi-ts/src/plugins/valibot/v1/toAst/union.ts +++ b/packages/openapi-ts/src/plugins/valibot/v1/toAst/union.ts @@ -20,7 +20,7 @@ function baseNode(ctx: UnionResolverContext): PipeResult { } }); - if (nonNullItems.length === 0) { + if (!nonNullItems.length) { return $(v).attr(identifiers.schemas.null).call(); } diff --git a/packages/openapi-ts/src/plugins/zod/mini/toAst/enum.ts b/packages/openapi-ts/src/plugins/zod/mini/toAst/enum.ts index 89f94cd57..715cb9f32 100644 --- a/packages/openapi-ts/src/plugins/zod/mini/toAst/enum.ts +++ b/packages/openapi-ts/src/plugins/zod/mini/toAst/enum.ts @@ -51,7 +51,7 @@ function baseNode(ctx: EnumResolverContext): Chain { const { z } = symbols; const { allStrings, enumMembers, literalMembers } = ctx.nodes.items(ctx); - if (allStrings && enumMembers.length > 0) { + if (allStrings && enumMembers.length) { return $(z) .attr(identifiers.enum) .call($.array(...enumMembers)); diff --git a/packages/openapi-ts/src/plugins/zod/mini/toAst/number.ts b/packages/openapi-ts/src/plugins/zod/mini/toAst/number.ts index 559046b37..736720b1f 100644 --- a/packages/openapi-ts/src/plugins/zod/mini/toAst/number.ts +++ b/packages/openapi-ts/src/plugins/zod/mini/toAst/number.ts @@ -92,7 +92,7 @@ function numberResolver(ctx: NumberResolverContext): Chain { const maxNode = ctx.nodes.max(ctx); if (maxNode) checks.push(maxNode); - if (checks.length > 0) { + if (checks.length) { ctx.chain.current = ctx.chain.current.attr(identifiers.check).call(...checks); } diff --git a/packages/openapi-ts/src/plugins/zod/mini/toAst/object.ts b/packages/openapi-ts/src/plugins/zod/mini/toAst/object.ts index e0a8a74df..1913da739 100644 --- a/packages/openapi-ts/src/plugins/zod/mini/toAst/object.ts +++ b/packages/openapi-ts/src/plugins/zod/mini/toAst/object.ts @@ -29,7 +29,7 @@ function additionalPropertiesNode(ctx: ExtendedContext): Chain | null | undefine if ( !schema.additionalProperties || - (schema.properties && Object.keys(schema.properties).length > 0) + (schema.properties && Object.keys(schema.properties).length) ) { return; } diff --git a/packages/openapi-ts/src/plugins/zod/mini/toAst/string.ts b/packages/openapi-ts/src/plugins/zod/mini/toAst/string.ts index d22e6d11f..be1dda9cc 100644 --- a/packages/openapi-ts/src/plugins/zod/mini/toAst/string.ts +++ b/packages/openapi-ts/src/plugins/zod/mini/toAst/string.ts @@ -111,7 +111,7 @@ function stringResolver(ctx: StringResolverContext): Chain { const patternNode = ctx.nodes.pattern(ctx); if (patternNode) checks.push(patternNode); - if (checks.length > 0) { + if (checks.length) { ctx.chain.current = ctx.chain.current.attr(identifiers.check).call(...checks); } diff --git a/packages/openapi-ts/src/plugins/zod/mini/toAst/tuple.ts b/packages/openapi-ts/src/plugins/zod/mini/toAst/tuple.ts index e8907149d..5d78b4ffc 100644 --- a/packages/openapi-ts/src/plugins/zod/mini/toAst/tuple.ts +++ b/packages/openapi-ts/src/plugins/zod/mini/toAst/tuple.ts @@ -17,7 +17,7 @@ function baseNode(ctx: TupleResolverContext): Chain { const tupleFn = $(z).attr(identifiers.tuple); - if (childResults.length === 0) { + if (!childResults.length) { return tupleFn.call($.array()); } diff --git a/packages/openapi-ts/src/plugins/zod/mini/walker.ts b/packages/openapi-ts/src/plugins/zod/mini/walker.ts index 145f3d63e..b8078643a 100644 --- a/packages/openapi-ts/src/plugins/zod/mini/walker.ts +++ b/packages/openapi-ts/src/plugins/zod/mini/walker.ts @@ -329,7 +329,7 @@ export function createVisitor( }); let expression: Chain; - if (nonNullItems.length === 0) { + if (!nonNullItems.length) { expression = $(z).attr(identifiers.null).call(); } else if (nonNullItems.length === 1) { expression = nonNullItems[0]!.expression; diff --git a/packages/openapi-ts/src/plugins/zod/v3/toAst/enum.ts b/packages/openapi-ts/src/plugins/zod/v3/toAst/enum.ts index e19648841..542fe32ab 100644 --- a/packages/openapi-ts/src/plugins/zod/v3/toAst/enum.ts +++ b/packages/openapi-ts/src/plugins/zod/v3/toAst/enum.ts @@ -50,7 +50,7 @@ function baseNode(ctx: EnumResolverContext): Chain { const { z } = symbols; const { allStrings, enumMembers, literalMembers } = ctx.nodes.items(ctx); - if (allStrings && enumMembers.length > 0) { + if (allStrings && enumMembers.length) { return $(z) .attr(identifiers.enum) .call($.array(...enumMembers)); diff --git a/packages/openapi-ts/src/plugins/zod/v3/toAst/object.ts b/packages/openapi-ts/src/plugins/zod/v3/toAst/object.ts index 10daa43d1..2a9cc92e5 100644 --- a/packages/openapi-ts/src/plugins/zod/v3/toAst/object.ts +++ b/packages/openapi-ts/src/plugins/zod/v3/toAst/object.ts @@ -25,7 +25,7 @@ function additionalPropertiesNode(ctx: ExtendedContext): Chain | null | undefine if ( !schema.additionalProperties || - (schema.properties && Object.keys(schema.properties).length > 0) + (schema.properties && Object.keys(schema.properties).length) ) { return; } diff --git a/packages/openapi-ts/src/plugins/zod/v3/toAst/tuple.ts b/packages/openapi-ts/src/plugins/zod/v3/toAst/tuple.ts index e8907149d..5d78b4ffc 100644 --- a/packages/openapi-ts/src/plugins/zod/v3/toAst/tuple.ts +++ b/packages/openapi-ts/src/plugins/zod/v3/toAst/tuple.ts @@ -17,7 +17,7 @@ function baseNode(ctx: TupleResolverContext): Chain { const tupleFn = $(z).attr(identifiers.tuple); - if (childResults.length === 0) { + if (!childResults.length) { return tupleFn.call($.array()); } diff --git a/packages/openapi-ts/src/plugins/zod/v3/walker.ts b/packages/openapi-ts/src/plugins/zod/v3/walker.ts index 936fcbe2c..452ec644e 100644 --- a/packages/openapi-ts/src/plugins/zod/v3/walker.ts +++ b/packages/openapi-ts/src/plugins/zod/v3/walker.ts @@ -326,7 +326,7 @@ export function createVisitor( }); let expression: Chain; - if (nonNullItems.length === 0) { + if (!nonNullItems.length) { expression = $(z).attr(identifiers.null).call(); } else if (nonNullItems.length === 1) { expression = nonNullItems[0]!.expression; diff --git a/packages/openapi-ts/src/plugins/zod/v4/toAst/enum.ts b/packages/openapi-ts/src/plugins/zod/v4/toAst/enum.ts index 89f94cd57..715cb9f32 100644 --- a/packages/openapi-ts/src/plugins/zod/v4/toAst/enum.ts +++ b/packages/openapi-ts/src/plugins/zod/v4/toAst/enum.ts @@ -51,7 +51,7 @@ function baseNode(ctx: EnumResolverContext): Chain { const { z } = symbols; const { allStrings, enumMembers, literalMembers } = ctx.nodes.items(ctx); - if (allStrings && enumMembers.length > 0) { + if (allStrings && enumMembers.length) { return $(z) .attr(identifiers.enum) .call($.array(...enumMembers)); diff --git a/packages/openapi-ts/src/plugins/zod/v4/toAst/intersection.ts b/packages/openapi-ts/src/plugins/zod/v4/toAst/intersection.ts index 95f2e15ac..69c03ccc9 100644 --- a/packages/openapi-ts/src/plugins/zod/v4/toAst/intersection.ts +++ b/packages/openapi-ts/src/plugins/zod/v4/toAst/intersection.ts @@ -18,7 +18,7 @@ function baseNode(ctx: IntersectionResolverContext): Chain { const { childResults, symbols } = ctx; const { z } = symbols; - if (childResults.length === 0) { + if (!childResults.length) { return $(z).attr(identifiers.never).call(); } diff --git a/packages/openapi-ts/src/plugins/zod/v4/toAst/object.ts b/packages/openapi-ts/src/plugins/zod/v4/toAst/object.ts index e0a8a74df..1913da739 100644 --- a/packages/openapi-ts/src/plugins/zod/v4/toAst/object.ts +++ b/packages/openapi-ts/src/plugins/zod/v4/toAst/object.ts @@ -29,7 +29,7 @@ function additionalPropertiesNode(ctx: ExtendedContext): Chain | null | undefine if ( !schema.additionalProperties || - (schema.properties && Object.keys(schema.properties).length > 0) + (schema.properties && Object.keys(schema.properties).length) ) { return; } diff --git a/packages/openapi-ts/src/plugins/zod/v4/toAst/tuple.ts b/packages/openapi-ts/src/plugins/zod/v4/toAst/tuple.ts index e8907149d..5d78b4ffc 100644 --- a/packages/openapi-ts/src/plugins/zod/v4/toAst/tuple.ts +++ b/packages/openapi-ts/src/plugins/zod/v4/toAst/tuple.ts @@ -17,7 +17,7 @@ function baseNode(ctx: TupleResolverContext): Chain { const tupleFn = $(z).attr(identifiers.tuple); - if (childResults.length === 0) { + if (!childResults.length) { return tupleFn.call($.array()); } diff --git a/packages/openapi-ts/src/plugins/zod/v4/toAst/union.ts b/packages/openapi-ts/src/plugins/zod/v4/toAst/union.ts index e9e3ef809..1da4c6c51 100644 --- a/packages/openapi-ts/src/plugins/zod/v4/toAst/union.ts +++ b/packages/openapi-ts/src/plugins/zod/v4/toAst/union.ts @@ -15,7 +15,7 @@ function baseNode(ctx: UnionResolverContext): Chain { const { childResults, schemas, symbols } = ctx; const { z } = symbols; - if (childResults.length === 0) { + if (!childResults.length) { return $(z).attr(identifiers.null).call(); } @@ -28,7 +28,7 @@ function baseNode(ctx: UnionResolverContext): Chain { }); let expression: Chain; - if (nonNullItems.length === 0) { + if (!nonNullItems.length) { expression = $(z).attr(identifiers.null).call(); } else if (nonNullItems.length === 1) { expression = nonNullItems[0]!.expression; diff --git a/packages/openapi-ts/src/plugins/zod/v4/walker.ts b/packages/openapi-ts/src/plugins/zod/v4/walker.ts index 7cbae75d5..364bd31c1 100644 --- a/packages/openapi-ts/src/plugins/zod/v4/walker.ts +++ b/packages/openapi-ts/src/plugins/zod/v4/walker.ts @@ -338,7 +338,7 @@ export function createVisitor( }); let expression: Chain; - if (nonNullItems.length === 0) { + if (!nonNullItems.length) { expression = $(z).attr(identifiers.null).call(); } else if (nonNullItems.length === 1) { expression = nonNullItems[0]!.expression; diff --git a/packages/openapi-ts/src/ts-dsl/decl/class.ts b/packages/openapi-ts/src/ts-dsl/decl/class.ts index 7a9c19772..436a7a21b 100644 --- a/packages/openapi-ts/src/ts-dsl/decl/class.ts +++ b/packages/openapi-ts/src/ts-dsl/decl/class.ts @@ -51,7 +51,7 @@ export class ClassTsDsl extends Mixed { /** Returns true if the class has any members. */ get hasBody(): boolean { - return this.body.length > 0; + return Boolean(this.body.length); } /** Adds one or more class members (fields, methods, etc.). */ diff --git a/packages/openapi-ts/src/ts-dsl/decl/func.ts b/packages/openapi-ts/src/ts-dsl/decl/func.ts index cfb03bfb8..06f18e4bd 100644 --- a/packages/openapi-ts/src/ts-dsl/decl/func.ts +++ b/packages/openapi-ts/src/ts-dsl/decl/func.ts @@ -85,7 +85,7 @@ class ImplFuncTsDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } /** Switches the function to an arrow function form. */ @@ -158,7 +158,7 @@ class ImplFuncTsDsl extends Mixed { $validate(): asserts this { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Function ${this.mode} missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-ts/src/ts-dsl/decl/param.ts b/packages/openapi-ts/src/ts-dsl/decl/param.ts index 02f38c31b..e451ddea8 100644 --- a/packages/openapi-ts/src/ts-dsl/decl/param.ts +++ b/packages/openapi-ts/src/ts-dsl/decl/param.ts @@ -41,7 +41,7 @@ export class ParamTsDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } /** Sets the parameter type. */ @@ -64,7 +64,7 @@ export class ParamTsDsl extends Mixed { $validate(): asserts this { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Parameter missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-ts/src/ts-dsl/decl/pattern.ts b/packages/openapi-ts/src/ts-dsl/decl/pattern.ts index 752f37dcb..f4ebbc490 100644 --- a/packages/openapi-ts/src/ts-dsl/decl/pattern.ts +++ b/packages/openapi-ts/src/ts-dsl/decl/pattern.ts @@ -25,7 +25,7 @@ export class PatternTsDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } /** Defines an array pattern (e.g., `[a, b, c]`). */ @@ -85,7 +85,7 @@ export class PatternTsDsl extends Mixed { | { kind: 'object'; values: Record }; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Binding pattern missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-ts/src/ts-dsl/expr/binary.ts b/packages/openapi-ts/src/ts-dsl/expr/binary.ts index 56a7f625a..de03f5b9c 100644 --- a/packages/openapi-ts/src/ts-dsl/expr/binary.ts +++ b/packages/openapi-ts/src/ts-dsl/expr/binary.ts @@ -52,7 +52,7 @@ export class BinaryTsDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } /** Logical AND — `this && expr` */ @@ -152,7 +152,7 @@ export class BinaryTsDsl extends Mixed { _op: Op; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Binary expression missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-ts/src/ts-dsl/expr/postfix.ts b/packages/openapi-ts/src/ts-dsl/expr/postfix.ts index 55a49fcc1..b73147756 100644 --- a/packages/openapi-ts/src/ts-dsl/expr/postfix.ts +++ b/packages/openapi-ts/src/ts-dsl/expr/postfix.ts @@ -28,7 +28,7 @@ export class PostfixTsDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } /** Sets the operator to MinusMinusToken for decrement (`--`). */ @@ -65,7 +65,7 @@ export class PostfixTsDsl extends Mixed { _op: PostfixOp; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Postfix unary expression missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-ts/src/ts-dsl/expr/prefix.ts b/packages/openapi-ts/src/ts-dsl/expr/prefix.ts index 7cf5b5812..615ebc345 100644 --- a/packages/openapi-ts/src/ts-dsl/expr/prefix.ts +++ b/packages/openapi-ts/src/ts-dsl/expr/prefix.ts @@ -28,7 +28,7 @@ export class PrefixTsDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } /** Sets the operand (the expression being prefixed). */ @@ -65,7 +65,7 @@ export class PrefixTsDsl extends Mixed { _op: PrefixOp; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Prefix unary expression missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-ts/src/ts-dsl/expr/prop.ts b/packages/openapi-ts/src/ts-dsl/expr/prop.ts index 4cb4b7b07..308ba82a0 100644 --- a/packages/openapi-ts/src/ts-dsl/expr/prop.ts +++ b/packages/openapi-ts/src/ts-dsl/expr/prop.ts @@ -49,7 +49,7 @@ export class ObjectPropTsDsl extends Mixed { } get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } value(value: Expr | Stmt | ((p: ObjectPropTsDsl) => void)) { @@ -104,7 +104,7 @@ export class ObjectPropTsDsl extends Mixed { kind: ObjectPropKind; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error( `Object property${this._meta.name ? ` "${this._meta.name}"` : ''} missing ${missing.join(' and ')}`, ); diff --git a/packages/openapi-ts/src/ts-dsl/expr/template.ts b/packages/openapi-ts/src/ts-dsl/expr/template.ts index 1dfdb5967..4bbf2cbfa 100644 --- a/packages/openapi-ts/src/ts-dsl/expr/template.ts +++ b/packages/openapi-ts/src/ts-dsl/expr/template.ts @@ -57,7 +57,7 @@ export class TemplateTsDsl extends Mixed { } } - if (normalized.length === 0 || typeof normalized[0] !== 'string') { + if (!normalized.length || typeof normalized[0] !== 'string') { normalized.unshift(''); } @@ -81,7 +81,7 @@ export class TemplateTsDsl extends Mixed { while (normalized.length) { const expr = normalized.shift() as ts.Expression; const next = typeof normalized[0] === 'string' ? (normalized.shift() as string) : ''; - const isLast = normalized.length === 0; + const isLast = !normalized.length; spans.push( ts.factory.createTemplateSpan( expr, diff --git a/packages/openapi-ts/src/ts-dsl/expr/ternary.ts b/packages/openapi-ts/src/ts-dsl/expr/ternary.ts index 6df3f05a1..c6ad2e082 100644 --- a/packages/openapi-ts/src/ts-dsl/expr/ternary.ts +++ b/packages/openapi-ts/src/ts-dsl/expr/ternary.ts @@ -27,7 +27,7 @@ export class TernaryTsDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } condition(condition: string | MaybeTsDsl) { @@ -62,7 +62,7 @@ export class TernaryTsDsl extends Mixed { _then: string | MaybeTsDsl; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Ternary expression missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-ts/src/ts-dsl/mixins/modifiers.ts b/packages/openapi-ts/src/ts-dsl/mixins/modifiers.ts index fefafd038..befd17f04 100644 --- a/packages/openapi-ts/src/ts-dsl/mixins/modifiers.ts +++ b/packages/openapi-ts/src/ts-dsl/mixins/modifiers.ts @@ -111,7 +111,7 @@ export function AbstractMixin>(Base abstract class Abstract extends Mixed { protected abstract(condition?: boolean): this { - const cond = arguments.length === 0 ? true : Boolean(condition); + const cond = !arguments.length ? true : Boolean(condition); return this._m('abstract', cond); } } @@ -137,7 +137,7 @@ export function AsyncMixin>(Base: T abstract class Async extends Mixed { protected async(condition?: boolean): this { - const cond = arguments.length === 0 ? true : Boolean(condition); + const cond = !arguments.length ? true : Boolean(condition); return this._m('async', cond); } } @@ -163,7 +163,7 @@ export function ConstMixin>(Base: T abstract class Const extends Mixed { protected const(condition?: boolean): this { - const cond = arguments.length === 0 ? true : Boolean(condition); + const cond = !arguments.length ? true : Boolean(condition); return this._m('const', cond); } } @@ -189,7 +189,7 @@ export function DeclareMixin>(Base: abstract class Declare extends Mixed { protected declare(condition?: boolean): this { - const cond = arguments.length === 0 ? true : Boolean(condition); + const cond = !arguments.length ? true : Boolean(condition); return this._m('declare', cond); } } @@ -221,7 +221,7 @@ export function DefaultMixin>(Base: * @returns The target object for chaining. */ protected default(condition?: boolean): this { - const cond = arguments.length === 0 ? true : Boolean(condition); + const cond = !arguments.length ? true : Boolean(condition); return this._m('default', cond); } } @@ -253,7 +253,7 @@ export function ExportMixin>(Base: * @returns The target object for chaining. */ protected export(condition?: boolean): this { - const cond = arguments.length === 0 ? true : Boolean(condition); + const cond = !arguments.length ? true : Boolean(condition); this.exported = cond; // TODO: remove this side-effect once planner handles exported flag if (this.symbol) this.symbol.setExported(cond); @@ -282,7 +282,7 @@ export function OverrideMixin>(Base abstract class Override extends Mixed { protected override(condition?: boolean): this { - const cond = arguments.length === 0 ? true : Boolean(condition); + const cond = !arguments.length ? true : Boolean(condition); return this._m('override', cond); } } @@ -308,7 +308,7 @@ export function PrivateMixin>(Base: abstract class Private extends Mixed { protected private(condition?: boolean): this { - const cond = arguments.length === 0 ? true : Boolean(condition); + const cond = !arguments.length ? true : Boolean(condition); return this._m('private', cond); } } @@ -334,7 +334,7 @@ export function ProtectedMixin>(Bas abstract class Protected extends Mixed { protected protected(condition?: boolean): this { - const cond = arguments.length === 0 ? true : Boolean(condition); + const cond = !arguments.length ? true : Boolean(condition); return this._m('protected', cond); } } @@ -360,7 +360,7 @@ export function PublicMixin>(Base: abstract class Public extends Mixed { protected public(condition?: boolean): this { - const cond = arguments.length === 0 ? true : Boolean(condition); + const cond = !arguments.length ? true : Boolean(condition); return this._m('public', cond); } } @@ -386,7 +386,7 @@ export function ReadonlyMixin>(Base abstract class Readonly extends Mixed { protected readonly(condition?: boolean): this { - const cond = arguments.length === 0 ? true : Boolean(condition); + const cond = !arguments.length ? true : Boolean(condition); return this._m('readonly', cond); } } @@ -412,7 +412,7 @@ export function StaticMixin>(Base: abstract class Static extends Mixed { protected static(condition?: boolean): this { - const cond = arguments.length === 0 ? true : Boolean(condition); + const cond = !arguments.length ? true : Boolean(condition); return this._m('static', cond); } } diff --git a/packages/openapi-ts/src/ts-dsl/mixins/optional.ts b/packages/openapi-ts/src/ts-dsl/mixins/optional.ts index 4d8069b1b..0e045035e 100644 --- a/packages/openapi-ts/src/ts-dsl/mixins/optional.ts +++ b/packages/openapi-ts/src/ts-dsl/mixins/optional.ts @@ -20,12 +20,12 @@ export function OptionalMixin>(Base } protected optional(condition?: boolean): this { - this._optional = arguments.length === 0 ? true : Boolean(condition); + this._optional = !arguments.length ? true : Boolean(condition); return this; } protected required(condition?: boolean): this { - this._optional = arguments.length === 0 ? false : !condition; + this._optional = !arguments.length ? false : !condition; return this; } } diff --git a/packages/openapi-ts/src/ts-dsl/stmt/for.ts b/packages/openapi-ts/src/ts-dsl/stmt/for.ts index 233636b47..9e63c21e7 100644 --- a/packages/openapi-ts/src/ts-dsl/stmt/for.ts +++ b/packages/openapi-ts/src/ts-dsl/stmt/for.ts @@ -53,7 +53,7 @@ class ImplForTsDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } /** Enables async iteration (`for await...of`). Can only be called on for...of. */ @@ -147,7 +147,7 @@ class ImplForTsDsl extends Mixed { _variableOrInit: VarTsDsl; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error( `For${this._mode === 'for' ? '' : `...${this._mode}`} statement missing ${missing.join(' and ')}`, ); diff --git a/packages/openapi-ts/src/ts-dsl/stmt/if.ts b/packages/openapi-ts/src/ts-dsl/stmt/if.ts index 982b77661..8d7a1b8f1 100644 --- a/packages/openapi-ts/src/ts-dsl/stmt/if.ts +++ b/packages/openapi-ts/src/ts-dsl/stmt/if.ts @@ -39,7 +39,7 @@ export class IfTsDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } condition(condition: IfCondition): this { @@ -65,14 +65,14 @@ export class IfTsDsl extends Mixed { _condition: IfCondition; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`If statement missing ${missing.join(' and ')}`); } private missingRequiredCalls(): ReadonlyArray { const missing: Array = []; if (!this._condition) missing.push('.condition()'); - if (this._do.length === 0) missing.push('.do()'); + if (!this._do.length) missing.push('.do()'); return missing; } } diff --git a/packages/openapi-ts/src/ts-dsl/stmt/try.ts b/packages/openapi-ts/src/ts-dsl/stmt/try.ts index 414e9b5ac..371c823ac 100644 --- a/packages/openapi-ts/src/ts-dsl/stmt/try.ts +++ b/packages/openapi-ts/src/ts-dsl/stmt/try.ts @@ -56,7 +56,7 @@ export class TryTsDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } catch(...items: Array): this { @@ -97,13 +97,13 @@ export class TryTsDsl extends Mixed { _try: Array; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Try statement missing ${missing.join(' and ')}`); } private missingRequiredCalls(): ReadonlyArray { const missing: Array = []; - if (!this._try || this._try.length === 0) missing.push('.try()'); + if (!this._try || !this._try.length) missing.push('.try()'); return missing; } } diff --git a/packages/openapi-ts/src/ts-dsl/stmt/var.ts b/packages/openapi-ts/src/ts-dsl/stmt/var.ts index 31e6fcef8..766036fc1 100644 --- a/packages/openapi-ts/src/ts-dsl/stmt/var.ts +++ b/packages/openapi-ts/src/ts-dsl/stmt/var.ts @@ -38,7 +38,7 @@ export class VarTsDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } const(): this { @@ -83,7 +83,7 @@ export class VarTsDsl extends Mixed { $validate(): asserts this { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Variable declaration missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-ts/src/ts-dsl/token.ts b/packages/openapi-ts/src/ts-dsl/token.ts index d28721bcc..be710d375 100644 --- a/packages/openapi-ts/src/ts-dsl/token.ts +++ b/packages/openapi-ts/src/ts-dsl/token.ts @@ -55,7 +55,7 @@ export class TokenTsDsl extends TsDsl extends TsDsl): this { @@ -70,7 +70,7 @@ export class TypeAttrTsDsl extends Mixed { _right: Ref; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Type attribute missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-ts/src/ts-dsl/type/expr.ts b/packages/openapi-ts/src/ts-dsl/type/expr.ts index 51bbe8190..7fb780be7 100644 --- a/packages/openapi-ts/src/ts-dsl/type/expr.ts +++ b/packages/openapi-ts/src/ts-dsl/type/expr.ts @@ -41,7 +41,7 @@ export class TypeExprTsDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } /** Accesses a nested type (e.g., `Foo.Bar`). */ @@ -64,7 +64,7 @@ export class TypeExprTsDsl extends Mixed { _exprInput: Ref; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Type expression missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-ts/src/ts-dsl/type/func.ts b/packages/openapi-ts/src/ts-dsl/type/func.ts index ce203b52a..cb8373dd6 100644 --- a/packages/openapi-ts/src/ts-dsl/type/func.ts +++ b/packages/openapi-ts/src/ts-dsl/type/func.ts @@ -19,7 +19,7 @@ export class TypeFuncTsDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } override toAst() { @@ -34,7 +34,7 @@ export class TypeFuncTsDsl extends Mixed { $validate(): asserts this { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Function type missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-ts/src/ts-dsl/type/idx-sig.ts b/packages/openapi-ts/src/ts-dsl/type/idx-sig.ts index 5667e6695..7e3f120b8 100644 --- a/packages/openapi-ts/src/ts-dsl/type/idx-sig.ts +++ b/packages/openapi-ts/src/ts-dsl/type/idx-sig.ts @@ -42,7 +42,7 @@ export class TypeIdxSigTsDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } /** Sets the key type: `[name: T]` */ @@ -80,7 +80,7 @@ export class TypeIdxSigTsDsl extends Mixed { _type: TypeIdxSigType; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; const name = this.name.toString(); throw new Error(`Index signature${name ? ` "${name}"` : ''} missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-ts/src/ts-dsl/type/idx.ts b/packages/openapi-ts/src/ts-dsl/type/idx.ts index 63184f033..d2c89c527 100644 --- a/packages/openapi-ts/src/ts-dsl/type/idx.ts +++ b/packages/openapi-ts/src/ts-dsl/type/idx.ts @@ -33,7 +33,7 @@ export class TypeIdxTsDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } base(base: Base): this { @@ -56,7 +56,7 @@ export class TypeIdxTsDsl extends Mixed { _index: Index; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Indexed access type missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-ts/src/ts-dsl/type/mapped.ts b/packages/openapi-ts/src/ts-dsl/type/mapped.ts index f9e4a3f38..c587ef9fb 100644 --- a/packages/openapi-ts/src/ts-dsl/type/mapped.ts +++ b/packages/openapi-ts/src/ts-dsl/type/mapped.ts @@ -35,7 +35,7 @@ export class TypeMappedTsDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } /** Sets the key constraint: `[K in Constraint]` */ @@ -96,7 +96,7 @@ export class TypeMappedTsDsl extends Mixed { _type: string | MaybeTsDsl; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; const name = this.name.toString(); throw new Error(`Mapped type${name ? ` "${name}"` : ''} missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-ts/src/ts-dsl/type/operator.ts b/packages/openapi-ts/src/ts-dsl/type/operator.ts index 556113a83..ef942b1b4 100644 --- a/packages/openapi-ts/src/ts-dsl/type/operator.ts +++ b/packages/openapi-ts/src/ts-dsl/type/operator.ts @@ -79,7 +79,7 @@ export class TypeOperatorTsDsl extends Mixed { _type: Type; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; throw new Error(`Type operator missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-ts/src/ts-dsl/type/prop.ts b/packages/openapi-ts/src/ts-dsl/type/prop.ts index ec49c1dcb..cd6578295 100644 --- a/packages/openapi-ts/src/ts-dsl/type/prop.ts +++ b/packages/openapi-ts/src/ts-dsl/type/prop.ts @@ -44,7 +44,7 @@ export class TypePropTsDsl extends Mixed { /** Returns true when all required builder calls are present. */ get isValid(): boolean { - return this.missingRequiredCalls().length === 0; + return !this.missingRequiredCalls().length; } /** Sets the property type. */ @@ -69,7 +69,7 @@ export class TypePropTsDsl extends Mixed { _type: Ref; } { const missing = this.missingRequiredCalls(); - if (missing.length === 0) return; + if (!missing.length) return; const name = this.name.toString(); throw new Error(`Type property${name ? ` "${name}"` : ''} missing ${missing.join(' and ')}`); } diff --git a/packages/openapi-ts/src/ts-dsl/type/template.ts b/packages/openapi-ts/src/ts-dsl/type/template.ts index 2471461a9..78f5c0259 100644 --- a/packages/openapi-ts/src/ts-dsl/type/template.ts +++ b/packages/openapi-ts/src/ts-dsl/type/template.ts @@ -49,7 +49,7 @@ export class TypeTemplateTsDsl extends Mixed { } } - if (normalized.length === 0 || typeof normalized[0] !== 'string') { + if (!normalized.length || typeof normalized[0] !== 'string') { normalized.unshift(''); } @@ -73,7 +73,7 @@ export class TypeTemplateTsDsl extends Mixed { while (normalized.length) { const type = normalized.shift() as ts.TypeNode; const next = typeof normalized[0] === 'string' ? (normalized.shift() as string) : ''; - const isLast = normalized.length === 0; + const isLast = !normalized.length; spans.push( ts.factory.createTemplateLiteralTypeSpan( type, diff --git a/packages/openapi-ts/src/ts-dsl/utils/context.ts b/packages/openapi-ts/src/ts-dsl/utils/context.ts index 95bfb58fe..10e1b8de5 100644 --- a/packages/openapi-ts/src/ts-dsl/utils/context.ts +++ b/packages/openapi-ts/src/ts-dsl/utils/context.ts @@ -59,7 +59,7 @@ function accessChainToNode(accessChain: NodeChain): T { function getAccessChainForNode(node: TsDsl): NodeChain { const structuralChain = [...getStructuralChainForNode(node, new Set())]; const accessChain = structuralToAccessChain(structuralChain); - if (accessChain.length === 0) { + if (!accessChain.length) { // I _think_ this should not happen, but it does and this fix works for now. // I assume this will cause issues with imports in some cases, investigate // when it actually happens. @@ -83,7 +83,7 @@ function getStructuralChainForNode(node: TsDsl, visited: Set): NodeChain if (getScope(parent) !== getScope(node)) continue; const chain = getStructuralChainForNode(parent, visited); - if (chain.length > 0) return [...chain, node]; + if (chain.length) return [...chain, node]; } } diff --git a/packages/openapi-ts/src/ts-dsl/utils/render.ts b/packages/openapi-ts/src/ts-dsl/utils/render.ts index 4f083f065..98ecca5cc 100644 --- a/packages/openapi-ts/src/ts-dsl/utils/render.ts +++ b/packages/openapi-ts/src/ts-dsl/utils/render.ts @@ -163,7 +163,7 @@ export class TypeScriptRenderer implements Renderer { group.kind === 'default' ? $.id(group.localName ?? '').toAst() : undefined, group.kind === 'namespace' ? ts.factory.createNamespaceImport($.id(group.localName ?? '').toAst()) - : specifiers.length > 0 + : specifiers.length ? ts.factory.createNamedImports(specifiers) : undefined, ); diff --git a/packages/shared/src/graph/walk.ts b/packages/shared/src/graph/walk.ts index 6292378e5..d9e483000 100644 --- a/packages/shared/src/graph/walk.ts +++ b/packages/shared/src/graph/walk.ts @@ -10,7 +10,7 @@ import type { GetPointerPriorityFn, WalkFn } from './types/walk'; const walkDeclarations: WalkFn = (graph, callback, options) => { const pointers = Array.from(graph.nodes.keys()); - if (options?.preferGroups && options.preferGroups.length > 0) { + if (options?.preferGroups && options.preferGroups.length) { // emit nodes that match each preferred group in order, preserving insertion order const emitted = new Set(); if (options.matchPointerToGroup) { @@ -137,7 +137,7 @@ const walkTopological: WalkFn = (graph, callback, options) => { // prefer specified groups when safe let finalOrder = order; - if (options?.preferGroups && options.preferGroups.length > 0) { + if (options?.preferGroups && options.preferGroups.length) { // build group priority map (lower = earlier) const groupPriority = new Map(); for (let i = 0; i < options.preferGroups.length; i++) { diff --git a/packages/shared/src/openApi/3.0.x/parser/schema.ts b/packages/shared/src/openApi/3.0.x/parser/schema.ts index b74cbd322..3611db415 100644 --- a/packages/shared/src/openApi/3.0.x/parser/schema.ts +++ b/packages/shared/src/openApi/3.0.x/parser/schema.ts @@ -518,7 +518,7 @@ const parseAllOf = ({ oneOf ? () => oneOf.some((o) => '$ref' in o && o.$ref === state.$ref) : undefined, ); - if (values.length === 0) { + if (!values.length) { continue; } @@ -574,7 +574,7 @@ const parseAllOf = ({ }); // Use allValues if we found children, otherwise use the original values - const finalValues = allValues.length > 0 ? allValues : values; + const finalValues = allValues.length ? allValues : values; // Detect the actual type of the discriminator property const propertyType = findDiscriminatorPropertyType({ diff --git a/packages/shared/src/openApi/3.1.x/parser/schema.ts b/packages/shared/src/openApi/3.1.x/parser/schema.ts index 8fbd9ee12..cb5baa305 100644 --- a/packages/shared/src/openApi/3.1.x/parser/schema.ts +++ b/packages/shared/src/openApi/3.1.x/parser/schema.ts @@ -613,7 +613,7 @@ const parseAllOf = ({ oneOf ? () => oneOf.some((o) => '$ref' in o && o.$ref === state.$ref) : undefined, ); - if (values.length === 0) { + if (!values.length) { continue; } @@ -670,7 +670,7 @@ const parseAllOf = ({ }); // Use allValues if we found children, otherwise use the original values - const finalValues = allValues.length > 0 ? allValues : values; + const finalValues = allValues.length ? allValues : values; // Detect the actual type of the discriminator property const propertyType = findDiscriminatorPropertyType({ diff --git a/packages/shared/src/openApi/shared/locations/operation.ts b/packages/shared/src/openApi/shared/locations/operation.ts index dbdb2ed69..3c05b55ee 100644 --- a/packages/shared/src/openApi/shared/locations/operation.ts +++ b/packages/shared/src/openApi/shared/locations/operation.ts @@ -49,7 +49,7 @@ export const OperationStrategy = { path?: OperationPathStrategy; }): OperationStructureStrategy => (operation) => { - const tags = operation.tags && operation.tags.length > 0 ? operation.tags : [config.fallback]; + const tags = operation.tags && operation.tags.length ? operation.tags : [config.fallback]; const path = config.path ?? OperationPath.id(); const pathSegments = path(operation); return tags.map((tag) => [tag, ...pathSegments]); @@ -142,7 +142,7 @@ export const OperationPath = { if (!operation.operationId) return fallback(operation); const delimiters = config?.delimiters ?? /[./]/; const segments = operation.operationId.split(delimiters).filter(Boolean); - return segments.length === 0 ? fallback(operation) : segments; + return !segments.length ? fallback(operation) : segments; }, /** diff --git a/packages/shared/src/openApi/shared/transforms/propertiesRequiredByDefault.ts b/packages/shared/src/openApi/shared/transforms/propertiesRequiredByDefault.ts index 934facffa..3495d799a 100644 --- a/packages/shared/src/openApi/shared/transforms/propertiesRequiredByDefault.ts +++ b/packages/shared/src/openApi/shared/transforms/propertiesRequiredByDefault.ts @@ -82,7 +82,7 @@ export const propertiesRequiredByDefaultTransform = ({ spec }: { spec: unknown } !('required' in nodeInfo.node) ) { const propKeys = Object.keys(nodeInfo.node.properties as Record); - if (propKeys.length > 0) { + if (propKeys.length) { (nodeInfo.node as Record).required = propKeys; } } diff --git a/packages/shared/src/openApi/shared/transforms/schemas.ts b/packages/shared/src/openApi/shared/transforms/schemas.ts index adaf6a070..566c104ff 100644 --- a/packages/shared/src/openApi/shared/transforms/schemas.ts +++ b/packages/shared/src/openApi/shared/transforms/schemas.ts @@ -73,7 +73,7 @@ export const schemaNameTransform = ({ schemasObj[newName] = schema; } - if (Object.keys(renameMap).length > 0) { + if (Object.keys(renameMap).length) { rewriteRefs(spec, renameMap); } }; -- 2.51.2