From 3f022b2decc967b9c1a20ece5f929d21a8b97fd1 Mon Sep 17 00:00:00 2001 From: scanash00 Date: Sat, 17 Jan 2026 23:26:29 -0900 Subject: [PATCH] fix sidebar not opening --- extension/background/service-worker.js | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/extension/background/service-worker.js b/extension/background/service-worker.js index 6bf3dc0..5a29a88 100644 --- a/extension/background/service-worker.js +++ b/extension/background/service-worker.js @@ -39,16 +39,17 @@ function showNotification(title, message) { } } -async function openAnnotationUI(tabId) { +async function openAnnotationUI(tabId, windowId) { if (hasSidePanel) { try { - const tab = await chrome.tabs.get(tabId); - await chrome.sidePanel.setOptions({ - tabId: tabId, - path: "sidepanel/sidepanel.html", - enabled: true, - }); - await chrome.sidePanel.open({ windowId: tab.windowId }); + let targetWindowId = windowId; + + if (!targetWindowId) { + const tab = await chrome.tabs.get(tabId); + targetWindowId = tab.windowId; + } + + await chrome.sidePanel.open({ windowId: targetWindowId }); return true; } catch (err) { console.error("Could not open Chrome side panel:", err); @@ -117,7 +118,7 @@ chrome.action.onClicked.addListener(async () => { chrome.contextMenus.onClicked.addListener(async (info, tab) => { if (info.menuItemId === "margin-open-sidebar") { - await openAnnotationUI(tab.id); + await openAnnotationUI(tab.id, tab.windowId); return; } -- 2.51.2