From c0ed0ac7aae67eee7f0e8091264bdfacd2e0030b Mon Sep 17 00:00:00 2001 From: Luke Bennett Date: Mon, 24 Aug 2026 15:11:35 +1000 Subject: [PATCH] Cover engines.node in the Renovate node rule (#495) --- .github/renovate.json5 | 17 ++++++++++++++--- package.json | 2 +- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/.github/renovate.json5 b/.github/renovate.json5 index 18de5cd3..a0099269 100644 --- a/.github/renovate.json5 +++ b/.github/renovate.json5 @@ -112,15 +112,26 @@ groupName: 'github actions', automerge: false, }, + // The Node major is declared twice: `mise.toml` selects the version this repo runs on, and the + // root `engines.node` warns anyone installing with a package manager instead of mise. Both name a + // major only, so both need `replace` to stay that way. They take a rule each because the managers + // differ — mise reads one, npm the other — and share a `groupName` so a new LTS line moves them in + // a single PR. Covering only mise is what let the top-level `bump` rewrite `24.x` to an exact + // `24.19.0`, and it landed in the non-major group rather than a Node one. { - // mise pins the Node major only, and Renovate's node versioning treats odd majors as unstable, - // so this stays quiet until the next LTS line opens. The top-level `bump` would instead - // rewrite `24` to an exact `24.18.1` and then raise a PR for every Node patch. matchManagers: ['mise'], groupName: 'node', rangeStrategy: 'replace', automerge: false, }, + { + matchManagers: ['npm'], + matchDepTypes: ['engines'], + matchDepNames: ['node'], + groupName: 'node', + rangeStrategy: 'replace', + automerge: false, + }, { // Moving the pinned pnpm version changes how every install resolves, including the quarantine // and trust policy checks. diff --git a/package.json b/package.json index 45a5a5f9..42549dff 100644 --- a/package.json +++ b/package.json @@ -41,7 +41,7 @@ "vite-plus": "catalog:" }, "engines": { - "node": "24.19.0" + "node": "24.x" }, "packageManager": "pnpm@11.22.0+sha512.1ff870c4c6133dfd88fb2afc46dd13d47f09c9794b438c6fdb47ca98caf3bc16381ee0be93a091b8e3824cf01f889f46d7d9e20910fb0be1ab0fb5baa80dd621" } -- 2.51.2