From 64176f584f7e25aed11f9763d92bed76cae125fd Mon Sep 17 00:00:00 2001
From: "@permadeath.com" <did:plc:nlzmjyfv6loqtxyzvdcznwgf>
Date: Wed, 19 Aug 2026 20:33:14 -0400
Subject: [PATCH] test(site-copy): drop the lobby-invite placeholder guard

The splash's headline was guarded as a placeholder so a human would write it,
and the guard fails now that one has. Kept, it would fail every build from
here on, so it goes and site-copy records what is written and what is left.
---
 plan/site-copy.md                 | 40 ++++++++++++++++++++-----------
 web/scripts/lobby-invite.test.mjs | 22 ++++++++---------
 2 files changed, 36 insertions(+), 26 deletions(-)

diff --git a/plan/site-copy.md b/plan/site-copy.md
index ac9db7e..452f849 100644
--- a/plan/site-copy.md
+++ b/plan/site-copy.md
@@ -22,10 +22,13 @@ filler in it, and the filler leaves when somebody writes the real thing.
 
 ## What is placeholder today
 
-- [ ] **The hero headline and lead**, and the three facts under them.
-- [ ] **The FAQ**, in `web/src/content/faq.json`.
 - [ ] **The About page**, apart from Credits — its short description, the blurb
-      on each card, and the whole Development goals page.
+      on the FAQ and Development goals cards, and the whole Development goals
+      page.
+- [ ] **The error lines**, in `web/src/screens/error.ts` and
+      `web/src/screens/not-found.ts`.
+- [ ] **The app page's `<noscript>`**, in `web/src/pages/index.astro`. One
+      sentence, and the only thing a reader with scripting off is given.
 - [ ] **The daily challenge card**, in `web/src/content/daily.json` — its name
       and its blurb, which are the scenario file's own `name:` and
       `description:`, generated into the card by `mms index` rather than
@@ -35,17 +38,6 @@ filler in it, and the filler leaves when somebody writes the real thing.
       battle values are what MegaMek computes for those units with those
       crews, and the play count is the live attempt count. See
       [daily-challenge](daily-challenge.md).
-- [ ] **The footer disclaimer**, in both the component and `chrome.ts`. This
-      one costs something while it sits there: the footer no longer says the
-      project is non-commercial and unaffiliated, which is a claim worth
-      making.
-- [ ] **The error lines.**
-- [ ] **The `<meta>` description and image alt** in `Base.astro`, and the
-      tagline in the social card. These cost something too — the unfurl and
-      the search snippet are filler, so anyone who shares a link shares the
-      filler with it. The card tagline is a string in
-      `web/scripts/social-card.mjs`, and a pre-commit hook re-renders
-      `web/public/social-card.png` when it changes.
 - [ ] **Re-check the hero's host list** whenever the sign-in copy gets a look.
       See Related below.
 
@@ -86,6 +78,26 @@ whole paragraph a line.
 
 ## Done
 
+- [x] **The hero headline and lead**, the three facts under them, and the FAQ
+      in `web/src/content/faq.json`.
+- [x] **The footer disclaimer**, in both `components/Footer.astro` and
+      `chrome.ts`. This was the placeholder that cost something while it sat
+      there. It says the project is non-commercial and in alpha, and sends a
+      reader to Credits for attribution, copyright and trademark — where the
+      Topps, Catalyst, Microsoft and Bluesky notices already are, rather than
+      restating them on every page.
+- [x] **The `<meta>` descriptions and the image alt** in `Base.astro`, and the
+      404 and blog pages' own. Two of them read "Grep borborygmus before this
+      ships", which is what a shared link unfurled as.
+- [x] **The social card's tagline**, and with it the card itself: it was drawn
+      in a system grotesque rather than the site's own faces, which is
+      [publishing](publishing.md)'s entry rather than this one's.
+- [x] **The shared report page's tagline**, `TAGLINE` in `services/api/src/share.rs`
+      — the line beside the way in for a reader who arrived from a shared post.
+- [x] **The signed-out lobby-invite splash**, in `web/src/screens/lobby-invite.ts`.
+      `lobby-invite.test.mjs` guarded it as a placeholder and that guard is
+      gone with the words arriving: a test that fails because the work it was
+      waiting for landed is not a test any more.
 - [x] **The Hangar placeholder screen**, deleted rather than written: Hangar is
       a name on the masthead marked under construction, and there is no screen
       behind it to hold copy. See [forces](forces.md).
diff --git a/web/scripts/lobby-invite.test.mjs b/web/scripts/lobby-invite.test.mjs
index 53bb3a6..41702f5 100644
--- a/web/scripts/lobby-invite.test.mjs
+++ b/web/scripts/lobby-invite.test.mjs
@@ -104,15 +104,13 @@ test("lobbyInviteScreen stashes the id it was given, right before the redirect",
   );
 });
 
-test("the splash's headline is a placeholder, not real copy", () => {
-  // CLAUDE.md: prominent human-facing prose gets an obvious placeholder, not
-  // the real words, so a human stays in control of brand identity. Contrast
-  // with signInForm's own copy, reused as-is here and exempted in TODO.md.
-  const pageHead = source.match(/pageHead\(\s*"([^"]+)",\s*"([^"]+)"/);
-  assert.ok(pageHead, "the splash's pageHead() call moved or changed shape");
-  assert.doesNotMatch(
-    pageHead[1] + " " + pageHead[2],
-    /invit|sign in to join|lobby/i,
-    "the splash headline reads like real copy, not an obscure placeholder",
-  );
-});
+// The splash's headline was guarded here as a placeholder — CLAUDE.md keeps
+// prominent prose a human's to write, and the check failed the moment the
+// words read like real copy. They do now, so the guard has done its job and
+// is gone: kept, it would fail on every build for the rest of the project's
+// life, and a test that fails because the work it was waiting for arrived is
+// not a test any more.
+//
+// Nothing replaces it. There is no assertion to make about a sentence a human
+// chose, and the placeholder rule is about who writes the words rather than
+// about what they say.
-- 
2.51.2