From f25ade7675cc356babba5ce05030f64e37f4e1df Mon Sep 17 00:00:00 2001
From: Trezy <tre@trezy.com>
Date: Thu, 14 May 2026 11:39:45 -0500
Subject: [PATCH] fix: chunk bulk inserts for sqlite, use rows_affected for
 counts, faster cancel checks, users page a11y

Signed-off-by: Trezy <tre@trezy.com>
---
 src/admin/backfill.rs                         | 55 +++++++++++--------
 web/src/app/dashboard/settings/users/page.tsx | 17 +++++-
 2 files changed, 46 insertions(+), 26 deletions(-)

diff --git a/src/admin/backfill.rs b/src/admin/backfill.rs
index 7534db5..238b796 100644
--- a/src/admin/backfill.rs
+++ b/src/admin/backfill.rs
@@ -266,32 +266,41 @@ async fn discover_repos_from_relay(
         let page_count = body.repos.len();
 
         if !body.repos.is_empty() {
-            let base_sql = "INSERT INTO backfill_repos (job_id, did) VALUES ";
-            let placeholders: Vec<String> = body
-                .repos
-                .iter()
-                .enumerate()
-                .map(|(i, _)| {
-                    if state.db_backend == crate::db::DatabaseBackend::Postgres {
-                        format!("(${}, ${})", i * 2 + 1, i * 2 + 2)
-                    } else {
-                        "(?, ?)".to_string()
-                    }
-                })
-                .collect();
-            let sql = format!(
-                "{base_sql}{} ON CONFLICT DO NOTHING",
-                placeholders.join(", ")
-            );
+            // SQLite has a 999 bound-parameter limit; each row uses 2 params
+            let chunk_size = if state.db_backend == crate::db::DatabaseBackend::Sqlite {
+                499
+            } else {
+                1000
+            };
+
+            for chunk in body.repos.chunks(chunk_size) {
+                let base_sql = "INSERT INTO backfill_repos (job_id, did) VALUES ";
+                let placeholders: Vec<String> = chunk
+                    .iter()
+                    .enumerate()
+                    .map(|(i, _)| {
+                        if state.db_backend == crate::db::DatabaseBackend::Postgres {
+                            format!("(${}, ${})", i * 2 + 1, i * 2 + 2)
+                        } else {
+                            "(?, ?)".to_string()
+                        }
+                    })
+                    .collect();
+                let sql = format!(
+                    "{base_sql}{} ON CONFLICT DO NOTHING",
+                    placeholders.join(", ")
+                );
 
-            let mut query = sqlx::query(&sql);
-            for repo in &body.repos {
-                query = query.bind(job_id).bind(&repo.did);
+                let mut query = sqlx::query(&sql);
+                for repo in chunk {
+                    query = query.bind(job_id).bind(&repo.did);
+                }
+                if let Ok(result) = query.execute(&state.db).await {
+                    running_total += result.rows_affected() as i32;
+                }
             }
-            let _ = query.execute(&state.db).await;
         }
 
-        running_total += page_count as i32;
         update_job_counter(state, job_id, "total_repos", running_total).await;
 
         if is_cancelled(state, job_id).await {
@@ -491,7 +500,7 @@ async fn run_fetching_phase(state: &AppState, job_id: &str, collections: &[Strin
 
                             let repos = processed_repos.fetch_add(1, Ordering::Relaxed) + 1;
 
-                            if repos % 100 == 0 {
+                            if repos % 10 == 0 {
                                 let records = total_records.load(Ordering::Relaxed);
                                 let backend = state.db_backend;
                                 let sql = adapt_sql(
diff --git a/web/src/app/dashboard/settings/users/page.tsx b/web/src/app/dashboard/settings/users/page.tsx
index 6bb9f43..81e7d3d 100644
--- a/web/src/app/dashboard/settings/users/page.tsx
+++ b/web/src/app/dashboard/settings/users/page.tsx
@@ -53,7 +53,6 @@ import {
   SheetFooter,
   SheetHeader,
   SheetTitle,
-  SheetDescription,
 } from "@/components/ui/sheet";
 
 type BskyProfile = {
@@ -282,7 +281,19 @@ export default function UsersPage() {
                 </TableRow>
               )}
               {users.map((user) => (
-                <TableRow key={user.id} className="cursor-pointer hover:bg-muted/50" onClick={() => setSelectedUserId(user.id)}>
+                <TableRow
+                  key={user.id}
+                  className="cursor-pointer hover:bg-muted/50 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring"
+                  tabIndex={0}
+                  role="button"
+                  onClick={() => setSelectedUserId(user.id)}
+                  onKeyDown={(e) => {
+                    if (e.key === "Enter" || e.key === " ") {
+                      e.preventDefault();
+                      setSelectedUserId(user.id);
+                    }
+                  }}
+                >
                   <TableCell className="text-sm">
                     <div className="flex items-center gap-2">
                       <div className="flex flex-col">
@@ -433,7 +444,7 @@ export default function UsersPage() {
                     <hr className="mx-4" />
 
                     <div className="relative px-4">
-                      <Search className="absolute left-6.5 top-2.5 size-4 text-muted-foreground" />
+                      <Search className="absolute left-[1.625rem] top-2.5 size-4 text-muted-foreground" />
                       <Input
                         placeholder="Search permissions..."
                         value={permSearch}
-- 
2.51.2