From 9d5e1b60ce3649b43f9e546f6e02590c163d4d8f Mon Sep 17 00:00:00 2001
From: Jared Pereira <jared@awarm.space>
Date: Wed, 15 Apr 2026 23:18:47 -0400
Subject: [PATCH] small fixes

---
 app/(home-pages)/tag/[tag]/page.tsx           |   6 +-
 .../dashboard/settings/PostSettings.tsx       |   2 -
 .../dashboard/settings/PubDomainSettings.tsx  | 100 +++++++++---------
 .../dashboard/settings/SettingsContent.tsx    |   3 +-
 .../dashboard/settings/deletePublication.ts   |   5 +-
 .../[publication]/theme-settings/page.tsx     |  23 ++--
 components/Domains/PublicationDomains.tsx     |   2 +-
 components/Tab.tsx                            |   1 +
 .../ThemeManager/Pickers/HexKeyboard.tsx      |   3 +-
 9 files changed, 71 insertions(+), 74 deletions(-)

diff --git a/app/(home-pages)/tag/[tag]/page.tsx b/app/(home-pages)/tag/[tag]/page.tsx
index 29edf137..84c6a9e8 100644
--- a/app/(home-pages)/tag/[tag]/page.tsx
+++ b/app/(home-pages)/tag/[tag]/page.tsx
@@ -1,8 +1,6 @@
 import { DashboardLayout } from "components/PageLayouts/DashboardLayout";
-import { Tag } from "components/Tags";
 import { PostListing } from "components/PostListing";
 import { getDocumentsByTag } from "./getDocumentsByTag";
-import { TagTiny } from "components/Icons/TagTiny";
 import { Metadata } from "next";
 
 export async function generateMetadata(props: {
@@ -46,7 +44,7 @@ const TagContent = (props: {
 
       <div className="pt-4 flex flex-col gap-4">
         {props.posts.length === 0 ? (
-          <EmptyState tag={props.tag} />
+          <NoPostsForTag tag={props.tag} />
         ) : (
           <>
             <div className="text-tertiary text-sm px-3">
@@ -62,7 +60,7 @@ const TagContent = (props: {
   );
 };
 
-const EmptyState = (props: { tag: string }) => {
+const NoPostsForTag = (props: { tag: string }) => {
   return (
     <div className="flex flex-col gap-2 items-center justify-center p-8 text-center">
       <div className="text-tertiary">
diff --git a/app/lish/[did]/[publication]/dashboard/settings/PostSettings.tsx b/app/lish/[did]/[publication]/dashboard/settings/PostSettings.tsx
index 23ecf50a..94e4962f 100644
--- a/app/lish/[did]/[publication]/dashboard/settings/PostSettings.tsx
+++ b/app/lish/[did]/[publication]/dashboard/settings/PostSettings.tsx
@@ -1,6 +1,5 @@
 import { Toggle } from "components/Toggle";
 import { DashboardContainer } from "./SettingsContent";
-import { useCardBorderHidden } from "components/Pages/useCardBorderHidden";
 
 export function PostSettings(props: {
   showComments: boolean;
@@ -14,7 +13,6 @@ export function PostSettings(props: {
   showInDiscover: boolean;
   setShowInDiscover: (v: boolean) => void;
 }) {
-  let cardBorderHidden = useCardBorderHidden();
   return (
     <>
       <DashboardContainer section="Discovery">
diff --git a/app/lish/[did]/[publication]/dashboard/settings/PubDomainSettings.tsx b/app/lish/[did]/[publication]/dashboard/settings/PubDomainSettings.tsx
index 46e1ff3f..78ac94f5 100644
--- a/app/lish/[did]/[publication]/dashboard/settings/PubDomainSettings.tsx
+++ b/app/lish/[did]/[publication]/dashboard/settings/PubDomainSettings.tsx
@@ -270,55 +270,59 @@ function UnassignedDomainRow(props: {
 
   async function doAssign() {
     setLoading(true);
-    mutateIdentityData(mutateIdentity, (draft) => {
-      let domain = draft.custom_domains.find(
-        (d) => d.domain === props.domainData.domain,
-      );
-      if (domain) {
-        domain.custom_domain_routes = [];
-        let pub = draft.publications?.find(
-          (p) => p.uri === props.publication_uri,
+    try {
+      mutateIdentityData(mutateIdentity, (draft) => {
+        let domain = draft.custom_domains.find(
+          (d) => d.domain === props.domainData.domain,
         );
-        domain.publication_domains = [
-          {
-            publication: props.publication_uri,
-            domain: props.domainData.domain,
-            identity: "",
-            created_at: new Date().toISOString(),
-            publications: pub ? { name: pub.name } : null,
-          },
-        ];
-      }
-    });
-    props.mutatePubData(
-      (current) => {
-        if (!current) return current;
-        let pub = current.publication;
-        if (!pub) return current;
-        return {
-          ...current,
-          publication: {
-            ...pub,
-            publication_domains: [
-              ...(pub.publication_domains || []),
-              {
-                publication: props.publication_uri,
-                domain: props.domainData.domain,
-                created_at: new Date().toISOString(),
-                identity: "",
-              },
-            ],
-          },
-        };
-      },
-      { revalidate: false },
-    );
-    setConfirming(false);
-    props.onAssigned();
-    await assignDomainToPublication({
-      domain: props.domainData.domain,
-      publication_uri: props.publication_uri,
-    });
+        if (domain) {
+          domain.custom_domain_routes = [];
+          let pub = draft.publications?.find(
+            (p) => p.uri === props.publication_uri,
+          );
+          domain.publication_domains = [
+            {
+              publication: props.publication_uri,
+              domain: props.domainData.domain,
+              identity: "",
+              created_at: new Date().toISOString(),
+              publications: pub ? { name: pub.name } : null,
+            },
+          ];
+        }
+      });
+      props.mutatePubData(
+        (current) => {
+          if (!current) return current;
+          let pub = current.publication;
+          if (!pub) return current;
+          return {
+            ...current,
+            publication: {
+              ...pub,
+              publication_domains: [
+                ...(pub.publication_domains || []),
+                {
+                  publication: props.publication_uri,
+                  domain: props.domainData.domain,
+                  created_at: new Date().toISOString(),
+                  identity: "",
+                },
+              ],
+            },
+          };
+        },
+        { revalidate: false },
+      );
+      setConfirming(false);
+      props.onAssigned();
+      await assignDomainToPublication({
+        domain: props.domainData.domain,
+        publication_uri: props.publication_uri,
+      });
+    } finally {
+      setLoading(false);
+    }
   }
 
   return (
diff --git a/app/lish/[did]/[publication]/dashboard/settings/SettingsContent.tsx b/app/lish/[did]/[publication]/dashboard/settings/SettingsContent.tsx
index f64bb893..7127f352 100644
--- a/app/lish/[did]/[publication]/dashboard/settings/SettingsContent.tsx
+++ b/app/lish/[did]/[publication]/dashboard/settings/SettingsContent.tsx
@@ -34,7 +34,6 @@ export function SettingsContent(props: { showPageBackground: boolean }) {
   let { publication: pubData } = data || {};
   let isPro = useIsPro();
   let canSeePro = useCanSeePro();
-  let cardBorderHidden = useCardBorderHidden();
   let record = useNormalizedPublicationRecord();
   let [loading, setLoading] = useState(false);
   let toast = useToaster();
@@ -269,7 +268,7 @@ export const DashboardContainer = (props: {
   let cardBorderHidden = useCardBorderHidden();
   return (
     <div
-      className={`container flex flex-col rounded-lg! gap-2 p-3 sm:px-4 ${!cardBorderHidden ? "" : "bg-trasparent!"} ${props.className}`}
+      className={`container flex flex-col rounded-lg! gap-2 p-3 sm:px-4 ${!cardBorderHidden ? "" : "bg-transparent!"} ${props.className}`}
     >
       {props.section && (
         <>
diff --git a/app/lish/[did]/[publication]/dashboard/settings/deletePublication.ts b/app/lish/[did]/[publication]/dashboard/settings/deletePublication.ts
index 9a1af465..2c4e2467 100644
--- a/app/lish/[did]/[publication]/dashboard/settings/deletePublication.ts
+++ b/app/lish/[did]/[publication]/dashboard/settings/deletePublication.ts
@@ -109,7 +109,10 @@ export async function deletePublication(
 
   // Delete document rows before publication rows — publication cascade would leave orphaned docs.
   if (documentUris.length > 0) {
-    supabaseServerClient.from("documents").delete().in("uri", documentUris);
+    await supabaseServerClient
+      .from("documents")
+      .delete()
+      .in("uri", documentUris);
   }
   await supabaseServerClient
     .from("publications")
diff --git a/app/lish/[did]/[publication]/theme-settings/page.tsx b/app/lish/[did]/[publication]/theme-settings/page.tsx
index 3aa3b7e2..caffe8fd 100644
--- a/app/lish/[did]/[publication]/theme-settings/page.tsx
+++ b/app/lish/[did]/[publication]/theme-settings/page.tsx
@@ -2,7 +2,6 @@ import { supabaseServerClient } from "supabase/serverClient";
 import { getIdentityData } from "actions/getIdentityData";
 import { get_publication_data } from "app/api/rpc/[command]/get_publication_data";
 import { PublicationSWRDataProvider } from "../dashboard/PublicationSWRProvider";
-import { PublicationThemeProviderDashboard } from "components/ThemeManager/PublicationThemeProvider";
 import { AtUri } from "@atproto/syntax";
 import { NotFoundLayout } from "components/PageLayouts/NotFoundLayout";
 import { normalizePublicationRecord } from "src/utils/normalizeRecords";
@@ -39,19 +38,15 @@ export default async function ThemeSettingsPage(props: {
     return <ThemeNotFound />;
   let uri = new AtUri(publication.uri);
 
-  try {
-    return (
-      <PublicationSWRDataProvider
-        publication_did={did}
-        publication_rkey={uri.rkey}
-        publication_data={publication_data}
-      >
-        <ThemeSettingsContent />
-      </PublicationSWRDataProvider>
-    );
-  } catch (e) {
-    return <pre>{JSON.stringify(e, undefined, 2)}</pre>;
-  }
+  return (
+    <PublicationSWRDataProvider
+      publication_did={did}
+      publication_rkey={uri.rkey}
+      publication_data={publication_data}
+    >
+      <ThemeSettingsContent />
+    </PublicationSWRDataProvider>
+  );
 }
 
 const ThemeNotFound = () => {
diff --git a/components/Domains/PublicationDomains.tsx b/components/Domains/PublicationDomains.tsx
index c04dccb7..3cfa3881 100644
--- a/components/Domains/PublicationDomains.tsx
+++ b/components/Domains/PublicationDomains.tsx
@@ -44,7 +44,7 @@ export function PublicationDomains(props: {
 
   return (
     <div>
-      Domains
+      <h4>Domains</h4>
       <div className="flex flex-col gap-1 py-1">
         <h4 className="">This Publication's Domains</h4>
         <div className="text-xs text-tertiary -mb-1 ">DEFAULT</div>
diff --git a/components/Tab.tsx b/components/Tab.tsx
index d970b659..1677f477 100644
--- a/components/Tab.tsx
+++ b/components/Tab.tsx
@@ -15,6 +15,7 @@ export const Tab = (props: {
       onClick={() => props.onSelect()}
       onMouseEnter={props.onMouseEnter}
       onPointerDown={props.onPointerDown}
+      aria-label={props.icon ? props.name : undefined}
     >
       {props.icon ? props.icon : props.name}
       {props.href && <ExternalLinkTiny />}
diff --git a/components/ThemeManager/Pickers/HexKeyboard.tsx b/components/ThemeManager/Pickers/HexKeyboard.tsx
index dd6f3847..72eebf15 100644
--- a/components/ThemeManager/Pickers/HexKeyboard.tsx
+++ b/components/ThemeManager/Pickers/HexKeyboard.tsx
@@ -110,7 +110,6 @@ export const HexKeyboard = (props: {
   let handleCopy = () => {
     navigator.clipboard.writeText(draft);
     let rect = copyButtonRef.current?.getBoundingClientRect();
-    console.log(draft);
     smoker({
       position: {
         x: rect ? rect.left + rect.width / 2 : 0,
@@ -159,7 +158,7 @@ export const HexKeyboard = (props: {
             flex items-center
             rounded-md border px-2 py-1 text-sm font-mono
              text-[#595959]!
-            ${isValidPartialHex ? "border-[#CCCCCC]}" : "border-red-400"}
+            ${isValidPartialHex ? "border-[#CCCCCC]" : "border-red-400"}
           `}
         >
           <span className="select-all">{draft}</span>
-- 
2.51.2