From 8cf7d84c62da03bffec4667a307690a97ebf5b90 Mon Sep 17 00:00:00 2001 From: Grace Kind Date: Sat, 10 Oct 2026 01:17:05 -0500 Subject: [PATCH] Remove more text assertions in tests --- package.json | 2 +- src/js/components/create-list-dialog.js | 7 +- src/js/components/edit-list-details-dialog.js | 7 +- src/js/components/edit-profile-dialog.js | 7 +- src/js/components/hidden-replies-section.js | 1 + src/js/components/moderation-warning.js | 1 + src/js/components/new-chat-dialog.js | 6 +- src/js/components/pinned-feeds-pane.js | 1 + src/js/components/post-composer.js | 6 +- .../components/starter-pack-wizard-dialog.js | 5 + src/js/components/tab-bar.js | 1 + src/js/modals/whoCanReply.modal.js | 35 ++++- src/js/templates/labelerSettings.template.js | 4 +- src/js/templates/largePost.template.js | 2 + .../templates/moderationWarning.template.js | 1 + .../templates/mutedParentToggle.template.js | 15 +- src/js/templates/postActionBar.template.js | 1 + src/js/templates/postEmbed.template.js | 4 +- src/js/templates/sidebar.template.js | 2 + src/js/templates/smallPost.template.js | 2 + src/js/templates/whoCanReplyBadge.template.js | 6 +- src/js/toasts.js | 1 + src/js/views/chat.view.js | 7 +- src/js/views/chatRequests.view.js | 4 +- src/js/views/communityPluginListing.view.js | 10 +- src/js/views/communityPlugins.view.js | 5 +- src/js/views/feeds.view.js | 4 +- src/js/views/groupChatDetails.view.js | 1 + src/js/views/home.view.js | 2 +- src/js/views/installedPlugins.view.js | 8 + src/js/views/login.view.js | 4 +- src/js/views/notifications.view.js | 38 ++++- src/js/views/postLikes.view.js | 2 +- src/js/views/postQuotes.view.js | 2 +- src/js/views/postReposts.view.js | 2 +- src/js/views/postThread.view.js | 11 +- src/js/views/profile.view.js | 13 +- src/js/views/profileFollowers.view.js | 2 +- src/js/views/profileFollowing.view.js | 2 +- src/js/views/profileKnownFollowers.view.js | 2 +- src/js/views/search.view.js | 2 + src/js/views/settings.view.js | 6 +- src/js/views/settings/advanced.view.js | 1 + src/js/views/settings/blockedAccounts.view.js | 2 +- src/js/views/settings/mutedAccounts.view.js | 2 +- src/js/views/settings/mutedWords.view.js | 34 +++-- src/js/views/starterPackDetail.view.js | 1 + tests/e2e/specs/concerns/blockedPosts.test.js | 18 +-- .../concerns/listDialogsEdgeCases.test.js | 6 +- .../specs/concerns/pinnedFeedsPane.test.js | 10 +- .../concerns/postComposerEdgeCases.test.js | 5 - tests/e2e/specs/concerns/postEmbeds.test.js | 1 - tests/e2e/specs/flows/blockUser.test.js | 12 +- tests/e2e/specs/flows/bookmarkPost.test.js | 2 +- .../e2e/specs/flows/chatRequestAccept.test.js | 21 ++- tests/e2e/specs/flows/createGroupChat.test.js | 3 - tests/e2e/specs/flows/createPost.test.js | 4 +- .../e2e/specs/flows/createStarterPack.test.js | 2 +- tests/e2e/specs/flows/deletePost.test.js | 13 +- tests/e2e/specs/flows/editProfile.test.js | 7 +- tests/e2e/specs/flows/editStarterPack.test.js | 2 +- tests/e2e/specs/flows/editThreadgate.test.js | 14 +- tests/e2e/specs/flows/goLive.test.js | 2 - tests/e2e/specs/flows/hidePost.test.js | 2 +- .../specs/flows/installRemotePlugin.test.js | 6 +- tests/e2e/specs/flows/joinLinkEmbed.test.js | 14 +- tests/e2e/specs/flows/leaveGroupChat.test.js | 4 +- .../e2e/specs/flows/muteConversation.test.js | 14 +- .../specs/flows/newChatFromChatList.test.js | 9 +- tests/e2e/specs/flows/pinFeed.test.js | 32 ++-- tests/e2e/specs/flows/quotePost.test.js | 2 +- tests/e2e/specs/views/bookmarks.view.test.js | 8 +- tests/e2e/specs/views/chat.view.test.js | 52 +++---- tests/e2e/specs/views/chatDetail.view.test.js | 16 +- .../e2e/specs/views/chatRequests.view.test.js | 23 ++- .../views/communityPluginListing.view.test.js | 22 ++- .../specs/views/communityPlugins.view.test.js | 9 +- tests/e2e/specs/views/feeds.view.test.js | 86 +++++++---- .../specs/views/groupChatDetails.view.test.js | 4 +- tests/e2e/specs/views/hashtag.view.test.js | 4 +- tests/e2e/specs/views/home.view.test.js | 51 +++---- .../specs/views/installedPlugins.view.test.js | 41 ++--- tests/e2e/specs/views/listDetail.view.test.js | 4 - tests/e2e/specs/views/lists.view.test.js | 16 +- tests/e2e/specs/views/login.view.test.js | 18 ++- tests/e2e/specs/views/notFound.view.test.js | 6 +- .../specs/views/notifications.view.test.js | 97 ++++++------ tests/e2e/specs/views/postLikes.view.test.js | 28 ++-- tests/e2e/specs/views/postQuotes.view.test.js | 35 ++--- .../e2e/specs/views/postReposts.view.test.js | 28 ++-- tests/e2e/specs/views/postThread.view.test.js | 79 +++++----- tests/e2e/specs/views/profile.view.test.js | 141 +++++++++--------- .../specs/views/profileFollowers.view.test.js | 7 +- .../specs/views/profileFollowing.view.test.js | 7 +- .../views/profileKnownFollowers.view.test.js | 14 +- tests/e2e/specs/views/search.view.test.js | 15 +- tests/e2e/specs/views/settings.view.test.js | 11 +- .../views/settings/advanced.view.test.js | 27 ++-- .../views/settings/mutedWords.view.test.js | 71 +++++---- .../views/starterPackDetail.view.test.js | 2 +- .../components/edit-profile-dialog.test.js | 21 +-- .../components/hidden-replies-section.test.js | 4 +- .../components/image-alt-text-dialog.test.js | 1 - .../manage-list-members-dialog.test.js | 7 +- .../components/moderation-warning.test.js | 19 +-- .../components/muted-parent-toggle.test.js | 7 +- .../specs/components/new-chat-dialog.test.js | 52 ++----- .../specs/components/post-composer.test.js | 51 ++++--- tests/unit/specs/modals/welcome.modal.test.js | 5 +- .../specs/modals/whoCanReply.modal.test.js | 18 ++- .../automatedAccountBadge.template.test.js | 6 - .../templates/blockedPost.template.test.js | 9 +- .../labelerSettings.template.test.js | 8 +- .../templates/largePost.template.test.js | 14 +- .../templates/notFoundPost.template.test.js | 9 +- .../templates/postActionBar.template.test.js | 6 +- .../specs/templates/postFeed.template.test.js | 1 - .../templates/profileList.template.test.js | 1 - .../specs/templates/sidebar.template.test.js | 22 ++- .../templates/smallPost.template.test.js | 11 +- .../starterPackList.template.test.js | 2 +- .../unavailablePost.template.test.js | 9 +- .../whoCanReplyBadge.template.test.js | 32 ++-- 123 files changed, 938 insertions(+), 788 deletions(-) diff --git a/package.json b/package.json index 668d82a8..f31e53be 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "impro", - "version": "0.20.94", + "version": "0.20.95", "type": "module", "scripts": { "start": "rm -rf \"${BUILD_DIR:-build}\" && NODE_ENV=development eleventy --serve", diff --git a/src/js/components/create-list-dialog.js b/src/js/components/create-list-dialog.js index c16ad59d..aafef98f 100644 --- a/src/js/components/create-list-dialog.js +++ b/src/js/components/create-list-dialog.js @@ -295,7 +295,12 @@ class CreateListDialog extends Component { ${this._error - ? html`
${this._error}
` + ? html`
+ ${this._error} +
` : ""} `} diff --git a/src/js/components/edit-list-details-dialog.js b/src/js/components/edit-list-details-dialog.js index 157679d8..2a82a6e7 100644 --- a/src/js/components/edit-list-details-dialog.js +++ b/src/js/components/edit-list-details-dialog.js @@ -282,7 +282,12 @@ class EditListDetailsDialog extends Component { ${this._error - ? html`
${this._error}
` + ? html`
+ ${this._error} +
` : ""} `} diff --git a/src/js/components/edit-profile-dialog.js b/src/js/components/edit-profile-dialog.js index 17bd374a..912022a4 100644 --- a/src/js/components/edit-profile-dialog.js +++ b/src/js/components/edit-profile-dialog.js @@ -333,7 +333,12 @@ class EditProfileDialog extends Component { ${this._error - ? html`
${this._error}
` + ? html`
+ ${this._error} +
` : ""} `} diff --git a/src/js/components/hidden-replies-section.js b/src/js/components/hidden-replies-section.js index 18660293..e27c31f1 100644 --- a/src/js/components/hidden-replies-section.js +++ b/src/js/components/hidden-replies-section.js @@ -26,6 +26,7 @@ class HiddenRepliesSection extends Component { >
Labeled by diff --git a/src/js/components/new-chat-dialog.js b/src/js/components/new-chat-dialog.js index ea7d9fec..fd2bf0df 100644 --- a/src/js/components/new-chat-dialog.js +++ b/src/js/components/new-chat-dialog.js @@ -365,7 +365,11 @@ function chatStepTemplate({ onInput: onSearchInput, onClear: onClearSearch, })} -
+
${chatStepResultsTemplate({ query, currentUserDid, diff --git a/src/js/components/pinned-feeds-pane.js b/src/js/components/pinned-feeds-pane.js index 4f3a0641..114736f0 100644 --- a/src/js/components/pinned-feeds-pane.js +++ b/src/js/components/pinned-feeds-pane.js @@ -28,6 +28,7 @@ function pinnedItemTemplate({ item, isCurrent, onSelect }) { return html` ${!isReady - ? html`
+ ? html`
${!isError ? html`` : ""} ${progressLabel}
` diff --git a/src/js/components/starter-pack-wizard-dialog.js b/src/js/components/starter-pack-wizard-dialog.js index f53dd62e..a3f7170a 100644 --- a/src/js/components/starter-pack-wizard-dialog.js +++ b/src/js/components/starter-pack-wizard-dialog.js @@ -192,6 +192,7 @@ function detailsStepTemplate({
`; } diff --git a/src/js/templates/sidebar.template.js b/src/js/templates/sidebar.template.js index a15746c8..ee11ce2c 100644 --- a/src/js/templates/sidebar.template.js +++ b/src/js/templates/sidebar.template.js @@ -318,6 +318,7 @@ export function sidebarTemplate({ data-testid="sidebar-profile-stats" > · ${children}${children} rule.type === "everybody"); let label; let icon; + let replySetting; if (isEverybody) { label = "Everybody can reply"; + replySetting = "everybody"; icon = html``; } else if (settings.some((rule) => rule.type === "nobody")) { label = "Replies disabled"; + replySetting = "nobody"; icon = html``; } else { label = "Some people can reply"; + replySetting = "limited"; icon = html``; } return html` @@ -24,7 +28,7 @@ export function whoCanReplyBadgeTemplate({ post, linkStyle = false, onClick }) { type="button" class="who-can-reply-badge ${linkStyle ? "who-can-reply-badge-link" : ""}" data-testid="who-can-reply-badge" - data-teststate=${linkStyle ? "link" : "plain"} + data-teststate=${replySetting} @click=${(event) => { event.stopPropagation(); onClick(post); diff --git a/src/js/toasts.js b/src/js/toasts.js index 3095ba05..1cd65f8d 100644 --- a/src/js/toasts.js +++ b/src/js/toasts.js @@ -123,6 +123,7 @@ export function showToast( const toast = document.createElement("div"); toast.classList.add("toast", style); toast.dataset.testid = "toast"; + toast.dataset.teststate = style; const resolvedIconTemplate = iconTemplate ?? STYLE_ICONS[style] ?? STYLE_ICONS.default; render( diff --git a/src/js/views/chat.view.js b/src/js/views/chat.view.js index ab189855..6f103630 100644 --- a/src/js/views/chat.view.js +++ b/src/js/views/chat.view.js @@ -164,7 +164,10 @@ export default async function chatView({ renderItem: (convo) => convoItemTemplate({ convo, currentUser }), hasMore, onLoadMore: loadConvoList, - emptyTemplate: html`
+ emptyTemplate: html`
No conversations yet!