From eee77c6f5ee3c2011282ef9baa0943b903f9fb0a Mon Sep 17 00:00:00 2001 From: Alex van de Sandt Date: Thu, 7 May 2026 09:19:04 -0500 Subject: [PATCH] Remove unused OkResponseError variant --- src/codec.rs | 5 +---- src/command/ok_response.rs | 10 +++------- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/src/codec.rs b/src/codec.rs index 3acf16b..1c31a8c 100644 --- a/src/codec.rs +++ b/src/codec.rs @@ -294,10 +294,7 @@ mod tests { let result = decode(b"CMD,FOO\r") .deserialize::() .unwrap_err(); - assert_matches!( - result, - ResponseError::InvalidFields(OkResponseError::UnexpectedValue) - ); + assert_matches!(result, ResponseError::InvalidFields(OkResponseError)); } fn decode(raw: &[u8]) -> RawResponse { diff --git a/src/command/ok_response.rs b/src/command/ok_response.rs index df2b236..f6595a6 100644 --- a/src/command/ok_response.rs +++ b/src/command/ok_response.rs @@ -3,12 +3,8 @@ use tokio_util::bytes::Bytes; use crate::command::Response; #[derive(Debug, thiserror::Error)] -pub enum OkResponseError { - #[error("expected `OK`")] - UnexpectedValue, - #[error("expected one response field")] - WrongNumberOfFields, -} +#[error("expected `OK`")] +pub struct OkResponseError; #[derive(Clone, Copy, Debug)] pub struct OkResponse; @@ -18,7 +14,7 @@ impl Response for OkResponse { fn deserialize(raw_values: &[Bytes]) -> Result { if raw_values[0] != b"OK".as_ref() { - return Err(OkResponseError::UnexpectedValue); + return Err(OkResponseError); } Ok(Self) -- 2.51.2