From 14308f4ca90ee30d1bfafcffae9fb152e49f35e4 Mon Sep 17 00:00:00 2001 From: Guido X Jansen Date: Thu, 19 Feb 2026 21:15:51 +0100 Subject: [PATCH] fix(ci): extend SESSION_SECRET to meet 32-char minimum (#34) * fix(ci): extend SESSION_SECRET to meet 32-char minimum The API validates SESSION_SECRET >= 32 characters. The CI value "ci_session_secret_not_real" was only 26 characters, causing the API container to crash on startup during smoke tests. * fix(ci): use loopback IP and valid OAuth client ID for smoke tests AT Protocol OAuth validation (RFC 8252) requires: - Loopback IP (127.0.0.1) instead of "localhost" for redirect URIs - HTTPS protocol for client_id - Path component in client_id (e.g. /client-metadata.json) * fix(ci): use real domain for OAuth client_id AT Protocol OAuth spec requires client_id to be: - HTTPS with a real domain (not IP, not loopback) - Include a path component Use ci-smoke.barazo.forum subdomain (doesn't need to resolve, only format-validated by the API on startup). --- .github/workflows/build-smoke-test.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build-smoke-test.yml b/.github/workflows/build-smoke-test.yml index f66da76..15f74c6 100644 --- a/.github/workflows/build-smoke-test.yml +++ b/.github/workflows/build-smoke-test.yml @@ -23,15 +23,15 @@ jobs: VALKEY_PASSWORD: ci_smoke_test DATABASE_URL: postgresql://barazo:ci_smoke_test@postgres:5432/barazo TAP_ADMIN_PASSWORD: ci_smoke_test - SESSION_SECRET: ci_session_secret_not_real + SESSION_SECRET: ci_session_secret_not_real_extend_to_32 RELAY_URL: wss://bsky.network COMMUNITY_DID: did:plc:ci-smoke-test COMMUNITY_NAME: CI Smoke Test COMMUNITY_DOMAIN: ":80" COMMUNITY_MODE: single - OAUTH_CLIENT_ID: http://localhost - OAUTH_REDIRECT_URI: http://localhost/api/auth/callback - NEXT_PUBLIC_SITE_URL: http://localhost + OAUTH_CLIENT_ID: https://ci-smoke.barazo.forum/client-metadata.json + OAUTH_REDIRECT_URI: http://127.0.0.1/api/auth/callback + NEXT_PUBLIC_SITE_URL: http://127.0.0.1 BARAZO_API_VERSION: latest BARAZO_WEB_VERSION: latest @@ -103,7 +103,7 @@ jobs: - name: Run smoke tests if: steps.check-images.outputs.available == 'true' - run: ./scripts/smoke-test.sh http://localhost + run: ./scripts/smoke-test.sh http://127.0.0.1 - name: Dump logs on failure if: failure() -- 2.51.2