From ce81a470eb12d8d17d80d048e822bda896e5f615 Mon Sep 17 00:00:00 2001
From: FoxxMD <FoxxMD@users.noreply.github.com>
Date: Fri, 25 Sep 2026 09:26:13 -0400
Subject: [PATCH] fix: guard against undefined variables in api endpoints

---
 src/backend/server/api.ts  |  2 +-
 src/backend/server/auth.ts | 10 ++++++----
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/backend/server/api.ts b/src/backend/server/api.ts
index 58802357..2f133027 100644
--- a/src/backend/server/api.ts
+++ b/src/backend/server/api.ts
@@ -505,7 +505,7 @@ Note: this is only supported by some components.`
             pMap(res.data, async (x) => await queueFunc(x), {concurrency: 5});
             more = res.data.length === res.meta.limit;
             if(more) {
-                currentFilters.offset! += res.meta.limit
+                currentFilters.offset = (currentFilters.offset ?? 0) + res.meta.limit
             }
         }
     });
diff --git a/src/backend/server/auth.ts b/src/backend/server/auth.ts
index 1e85a49f..26524d06 100644
--- a/src/backend/server/auth.ts
+++ b/src/backend/server/auth.ts
@@ -100,13 +100,15 @@ export const setupAuthRoutes = (app: Express, router: ReturnType<typeof createTy
         } else if(req.url.includes('ytmusic')) {
             const entity: YTMusicSource | undefined = scrobbleSources.getByName(name) as (YTMusicSource | undefined);
             if(entity === undefined) {
-                logger.error(`No YTMUsic source with name ${state} was found`);
+                logger.error(`No YTMUsic source with name ${name} was found`);
+                res.status(404).send(`No YTMusic source with name ${name} was found`);
+                return;
             }
-            const result = await entity!.handleAuthCodeCallback(req.query as Record<string, any>);
+            const result = await entity.handleAuthCodeCallback(req.query as Record<string, any>);
             let responseContent = 'OK';
             if(result === true) {
-                entity!.authFailure = false;
-                entity!.poll().catch((e) => logger.error(e));
+                entity.authFailure = false;
+                entity.poll().catch((e) => logger.error(e));
             } else {
                 responseContent = result;
             }
-- 
2.51.2