From b4e85ce8448d89f88c2daccabbe55a7ef24d2b2b Mon Sep 17 00:00:00 2001
From: FoxxMD <FoxxMD@users.noreply.github.com>
Date: Fri, 18 Sep 2026 17:03:51 +0000
Subject: [PATCH] fix(transform): Improve defaults for rocksky transformer

---
 src/backend/common/transforms/rocksky/RockskyTransformer.ts | 6 +++---
 .../common/transforms/rocksky/RockskyTransformerUtil.ts     | 6 ++++--
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/backend/common/transforms/rocksky/RockskyTransformer.ts b/src/backend/common/transforms/rocksky/RockskyTransformer.ts
index 43b96adb..04ec2b95 100644
--- a/src/backend/common/transforms/rocksky/RockskyTransformer.ts
+++ b/src/backend/common/transforms/rocksky/RockskyTransformer.ts
@@ -22,7 +22,7 @@ import { hasRequiredScrobbleFields, hasScrobbleConfidenceFields, type SongViewDe
 import { RockskyError, type SongMatchView } from "@rocksky/sdk";
 import { RockskyClientPool } from "../../vendor/rocksky/RockskyClientWrapped.ts";
 import type { RockskyTransformerConfig, RockskyTransformerData } from "../../vendor/rocksky/interfaces.ts";
-import { type SearchType, searchType } from "./RockskyTransformerUtil.ts";
+import { DEFAULT_ROCKSKY_SEARCH_ORDER, type SearchType, searchType } from "./RockskyTransformerUtil.ts";
 
 export const DEFAULT_SEARCHTYPE_ORDER: SearchType[] = ['isrc','basic'];
 
@@ -60,7 +60,7 @@ export const parseStageConfig = (data: RockskyTransformerData | undefined = {},
     };
 
     if(searchWhenMissing !== undefined) {
-        config.searchWhenMissing = searchWhenMissing.map(x => rockskyMissingFields.parse(x.toLocaleLowerCase().trim()));
+        config.searchWhenMissing = DEFAULT_ROCKSKY_MISSING_TYPES;
     }
 
     logger.debug(`Will search if missing: ${config.searchWhenMissing.join(', ')} | Match if (default) score is >= ${config.score}`);
@@ -212,7 +212,7 @@ export default class RockskyTransformer extends AtomicPartsTransformer<ExternalM
         
         const {
             // preserve order of search from before searchOrder
-            searchOrder = this.defaults.searchOrder ?? ['isrc', 'basic'],
+            searchOrder = this.defaults.searchOrder ?? DEFAULT_ROCKSKY_SEARCH_ORDER,
             score = this.defaults.score ?? 90,
             allowNoMatch = true,
         } = stageConfig;
diff --git a/src/backend/common/transforms/rocksky/RockskyTransformerUtil.ts b/src/backend/common/transforms/rocksky/RockskyTransformerUtil.ts
index 5f27420b..ccdc0a53 100644
--- a/src/backend/common/transforms/rocksky/RockskyTransformerUtil.ts
+++ b/src/backend/common/transforms/rocksky/RockskyTransformerUtil.ts
@@ -45,6 +45,8 @@ export const configFromEnv = (logger: MaybeLogger = new MaybeLogger()) => {
     return rsConfig;
 }
 
+export const DEFAULT_ROCKSKY_SEARCH_ORDER: SearchType[] = ["isrc","basic"] 
+
 export const DEFAULTS_NATIVE: RockskyTransformerData = {
     "searchArtistMethod": "native",
     "searchOrder": ["artist"]
@@ -57,11 +59,11 @@ export const DEFAULTS_FIELDS_BIAS = {
 };
 
 export const DEFAULTS_PRESET: RockskyTransformerData = {
-    "searchOrder": ["isrc", "basic"]
+    "searchOrder": DEFAULT_ROCKSKY_SEARCH_ORDER
 };
 
 export const DEFAULTS_ID: RockskyTransformerData = {
-    "searchOrder": ["isrc", "mbid", "basicorids", "basic"]
+    "searchOrder": ["isrc", "mbid", "basic"]
 };
 
 export const PRESETS: Record<string, RockskyTransformerData> = {
-- 
2.51.2