diff --git a/src/backend/sources/ScrobbleSources.ts b/src/backend/sources/ScrobbleSources.ts index d5ebf85f..d0e4021e 100644 --- a/src/backend/sources/ScrobbleSources.ts +++ b/src/backend/sources/ScrobbleSources.ts @@ -124,7 +124,7 @@ export default class ScrobbleSources { throw new Error('config.json could not be parsed', { cause: e }); } - let sourceDefaults: SourceDefaults = {}; + let sourceDefaults: SourceDefaults; if (configFile !== undefined) { let aioConfig: AIOSourceRelaxedConfig; try { @@ -166,6 +166,8 @@ export default class ScrobbleSources { continue; } } + } else { + sourceDefaults = this.buildSourceDefaults(); } const envKeys = Object.keys(process.env).map(x => x.toUpperCase()); diff --git a/src/backend/tests/config/config.test.ts b/src/backend/tests/config/config.test.ts index a23cbdcf..dabc7163 100644 --- a/src/backend/tests/config/config.test.ts +++ b/src/backend/tests/config/config.test.ts @@ -7,7 +7,7 @@ import path from "path"; import ScrobbleClients from '../../scrobblers/ScrobbleClients.ts'; import ScrobbleSources from '../../sources/ScrobbleSources.ts'; import EventEmitter from "events"; -import {loggerDebug, loggerTest} from '@foxxmd/logging'; +import {loggerTest} from '@foxxmd/logging'; import { clientTypes } from "../../../core/Atomic.ts"; import { projectRootDir } from "../../common/infrastructure/Atomic.ts"; import { sourceTypes } from "../../../core/Atomic.ts"; @@ -143,7 +143,7 @@ describe('Sample Configs', function () { configDir: process.cwd(), version: 'test' }, - loggerDebug); + loggerTest); await clients.buildClientsFromConfig(); expect(clients.clients).length(1); }); @@ -169,6 +169,7 @@ describe('Global ENVs with Config', function () { it('Parses default scrobble duration', async function () { process.env.SOURCE_SCROBBLE_DURATION = '20'; + process.env.MPRIS_ID = 'test'; process.env.MPRIS_ENABLE = 'true'; const emitter = new EventEmitter(); @@ -185,6 +186,7 @@ describe('Global ENVs with Config', function () { it('Parses default scrobble precentage', async function () { process.env.SOURCE_SCROBBLE_PERCENT = '20'; + process.env.MPRIS_ID = 'test'; process.env.MPRIS_ENABLE = 'true'; const emitter = new EventEmitter();