From 0e249b13a988da545d4d2c6237b87c35f91a3d93 Mon Sep 17 00:00:00 2001 From: FoxxMD Date: Mon, 3 Aug 2026 18:25:12 +0000 Subject: [PATCH] fix(source): Fix player cleanup for ingress sources This bool check was backward. The scheduled task should no-op for polling sources and run cleanup for ingress sources #652 --- src/backend/sources/MemorySource.ts | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/backend/sources/MemorySource.ts b/src/backend/sources/MemorySource.ts index d0f28f75..d601e086 100644 --- a/src/backend/sources/MemorySource.ts +++ b/src/backend/sources/MemorySource.ts @@ -61,7 +61,7 @@ export default class MemorySource extends AbstractSource { // player cleanup on *schedule* is needed when the Source is non-polling (ingress) // because if the source stops sending updates then processRecentPlays() was never called so we never remove old players this.scheduler.addSimpleIntervalJob(new SimpleIntervalJob({ seconds: 15 }, new AsyncTask('Player Cleanup', (): Promise => { - if (!this.canPoll) { + if (this.canPoll) { return Promise.resolve(); } return PromisePool @@ -93,12 +93,6 @@ export default class MemorySource extends AbstractSource { this[Symbol.dispose](); } - cleanupPlayers = () => { - for (const key of this.players.keys()) { - this.cleanupPlayer(key); - } - } - cleanupPlayer = async (key: string): Promise => { const player = this.players.get(key); if(player === undefined) { -- 2.51.2