From c493b301f8b62c60fa09a7af61bec11a943cab05 Mon Sep 17 00:00:00 2001
From: Cassidy James Blaede <c@ssidyjam.es>
Date: Wed, 2 Sep 2026 22:00:58 -0600
Subject: [PATCH] RSS: refetch feed when the URL changes

The card read `item.cardData.href` only once inside `onMount`, so setting
the feed URL from Source settings after the card was already mounted left
`feedUrl` stuck at `''` and showed "Add an RSS feed URL" forever. Replacing
the one-shot mount fetch with a reactive `$effect` makes the card load the
feed as soon as the URL changes, which also keeps the edit previewer in
sync.
---
 .../content/RSSFeedCard/RSSFeedCard.svelte    | 34 +++++++++++--------
 1 file changed, 19 insertions(+), 15 deletions(-)

diff --git a/apps/web/src/lib/cards/content/RSSFeedCard/RSSFeedCard.svelte b/apps/web/src/lib/cards/content/RSSFeedCard/RSSFeedCard.svelte
index 8394e27..b7a0035 100644
--- a/apps/web/src/lib/cards/content/RSSFeedCard/RSSFeedCard.svelte
+++ b/apps/web/src/lib/cards/content/RSSFeedCard/RSSFeedCard.svelte
@@ -1,5 +1,4 @@
 <script lang="ts">
-	import { onMount } from 'svelte';
 	import { getAdditionalUserData, getCanEdit } from '$lib/website/data/context';
 	import type { ContentComponentProps } from '../../types';
 	import DateTime from '../StandardSiteDocumentListCard/DateTime.svelte';
@@ -10,30 +9,35 @@
 	let { item }: ContentComponentProps = $props();
 
 	const data = getAdditionalUserData();
+	// `undefined` => still initializing (show loading); `''` => no feed configured
 	let feedUrl = $state<string | undefined>(undefined);
 	let feed = $state<RssFeedItem[] | undefined>();
 	const canEdit = getCanEdit();
 
-	onMount(async () => {
-		feedUrl = normalizeFeedUrl((item.cardData.href as string | undefined) ?? '') ?? '';
-		// feedUrl === undefined => still initializing (show loading)
-		if (feedUrl === '') return;
+	$effect(() => {
+		const current = normalizeFeedUrl((item.cardData.href as string | undefined) ?? '') ?? '';
+		if (current === feedUrl) return;
+		feedUrl = current;
+		feed = undefined;
+		if (current === '') return;
 
-		const preloaded = (data[item.cardType] as Record<string, RssFeedItem[]> | undefined)?.[feedUrl];
+		const preloaded = (data[item.cardType] as Record<string, RssFeedItem[]> | undefined)?.[current];
 		if (preloaded) {
 			feed = preloaded;
 			return;
 		}
 
-		try {
-			feed = await fetchRssFeed(feedUrl);
-			data[item.cardType] = {
-				...((data[item.cardType] as Record<string, RssFeedItem[]> | undefined) ?? {}),
-				[feedUrl]: feed
-			};
-		} catch {
-			feed = [];
-		}
+		fetchRssFeed(current)
+			.then((items) => {
+				feed = items;
+				data[item.cardType] = {
+					...((data[item.cardType] as Record<string, RssFeedItem[]> | undefined) ?? {}),
+					[current]: items
+				};
+			})
+			.catch(() => {
+				feed = [];
+			});
 	});
 </script>
 
-- 
2.51.2