diff --git a/Core/Importers/MusicBeeTagHierarchyImporter.cs b/Core/Importers/MusicBeeTagHierarchyImporter.cs index b4557d8..d8ce00b 100644 --- a/Core/Importers/MusicBeeTagHierarchyImporter.cs +++ b/Core/Importers/MusicBeeTagHierarchyImporter.cs @@ -4,23 +4,10 @@ using TagHierarchyManager.Models; namespace TagHierarchyManager.Importers; -/// TODO Manual intervention for ambiguous duplicate-name tags during import. -/// Identity is name-based merging by default. When the same tag name appears -/// under disjoint parent sets within a single file, the user may have meant -/// distinct tags (e.g. Atmosphere/Spiritual the mood vs Religion/Spiritual the -/// genre) rather than one merged tag. Current behaviour merges silently. -/// -/// Scope when implementing: -/// - Detect ambiguity at end of parsing, before database writing. -/// - One-shot UI prompt to resolve each case. -/// - No cross-import persistence — each import is a fresh database. -/// - No automatic merging of tags with identical names, or with parents detected as being identical. - /// /// Implements an importer for converting a MusicBee tag hierarchy template to a Dictionary of /// s. /// -/// TODO add manual intervention for tags with duplicate names. public class MusicBeeTagHierarchyImporter : Importer { private const int IndentSize = 4; // MusicBee is strict about having an indent size of 4 spaces. @@ -142,7 +129,6 @@ public class MusicBeeTagHierarchyImporter : Importer private static void ValidateHierarchyData(string tagHierarchyData) { - // TODO change on the fly instead of erroring out? if (tagHierarchyData.Contains('\t')) throw new ArgumentException(ErrorMessages.ImporterMusicBeeTabsDetected); if (tagHierarchyData.StartsWith(' ')) diff --git a/UI/ViewModels/ImportDialogViewModel.cs b/UI/ViewModels/ImportDialogViewModel.cs index 97f2a25..ad736c3 100644 --- a/UI/ViewModels/ImportDialogViewModel.cs +++ b/UI/ViewModels/ImportDialogViewModel.cs @@ -11,7 +11,6 @@ using TagHierarchyManager.UI.Views; namespace TagHierarchyManager.UI.ViewModels; -// todo handle manual interventions public partial class ImportDialogViewModel(MainWindowViewModel mainWindow, DialogService dialogService) : ViewModelBase { [ObservableProperty]