From d23f5cebf4f0bdb40c7ace0727e24e816ab1b307 Mon Sep 17 00:00:00 2001 From: oppiliappan Date: Tue, 27 Jan 2026 09:26:22 +0000 Subject: [PATCH] cherry-pickable: add logging to pages Signed-off-by: oppiliappan --- appview/pages/pages.go | 36 ++++++++++++++++++++++++++++++++---- 1 file changed, 32 insertions(+), 4 deletions(-) diff --git a/appview/pages/pages.go b/appview/pages/pages.go index 0557aa00..635585f8 100644 --- a/appview/pages/pages.go +++ b/appview/pages/pages.go @@ -190,10 +190,17 @@ func (p *Pages) parseLoginBase(top string) (*template.Template, error) { func (p *Pages) executePlain(name string, w io.Writer, params any) error { tpl, err := p.parse(name) if err != nil { + p.logger.Error("failed to parse template", "err", err) return err } - return tpl.Execute(w, params) + err = tpl.Execute(w, params) + if err != nil { + p.logger.Error("failed to execute template", "err", err) + return err + } + + return nil } func (p *Pages) executeLogin(name string, w io.Writer, params any) error { @@ -208,28 +215,49 @@ func (p *Pages) executeLogin(name string, w io.Writer, params any) error { func (p *Pages) execute(name string, w io.Writer, params any) error { tpl, err := p.parseBase(name) if err != nil { + p.logger.Error("failed to parse template", "err", err) return err } - return tpl.ExecuteTemplate(w, "layouts/base", params) + err = tpl.ExecuteTemplate(w, "layouts/base", params) + if err != nil { + p.logger.Error("failed to execute template", "err", err) + return err + } + + return nil } func (p *Pages) executeRepo(name string, w io.Writer, params any) error { tpl, err := p.parseRepoBase(name) if err != nil { + p.logger.Error("failed to parse template", "err", err) return err } - return tpl.ExecuteTemplate(w, "layouts/base", params) + err = tpl.ExecuteTemplate(w, "layouts/base", params) + if err != nil { + p.logger.Error("failed to execute template", "err", err) + return err + } + + return nil } func (p *Pages) executeProfile(name string, w io.Writer, params any) error { tpl, err := p.parseProfileBase(name) if err != nil { + p.logger.Error("failed to parse template", "err", err) return err } - return tpl.ExecuteTemplate(w, "layouts/base", params) + err = tpl.ExecuteTemplate(w, "layouts/base", params) + if err != nil { + p.logger.Error("failed to execute template", "err", err) + return err + } + + return nil } type DollyParams struct { -- 2.51.2