From 0e5694dce74013f2136502557322047748484bf2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C3=ADas=20Insaurralde?= Date: Thu, 23 Apr 2026 09:59:14 -0300 Subject: [PATCH] appview/settings: replace log.Printf with structured logging MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Matías Insaurralde --- appview/settings/settings.go | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/appview/settings/settings.go b/appview/settings/settings.go index ea4ca427..6a078884 100644 --- a/appview/settings/settings.go +++ b/appview/settings/settings.go @@ -6,7 +6,6 @@ import ( "errors" "fmt" "html" - "log" "log/slog" "net/http" "net/url" @@ -262,7 +261,7 @@ func (s *Settings) profileSettings(w http.ResponseWriter, r *http.Request) { punchcardPreferences, err := db.GetPunchcardPreference(s.Db, user.Did) if err != nil { - log.Printf("failed to get users punchcard preferences: %s", err) + s.Logger.Error("failed to get punchcard preferences", "err", err) } isTnglSh, err := s.isTnglShUser(r.Context(), syntax.DID(user.Did)) @@ -751,7 +750,7 @@ func (s *Settings) elevateForHandle(w http.ResponseWriter, r *http.Request) { "/settings/profile?handle=1", ) if err != nil { - log.Printf("failed to start elevated auth flow: %s", err) + s.Logger.Error("failed to start elevated auth flow", "err", err) http.Redirect(w, r, "/settings/profile", http.StatusSeeOther) return } @@ -791,7 +790,7 @@ func (s *Settings) updateHandle(w http.ResponseWriter, r *http.Request) { client, err := s.OAuth.AuthorizedClient(r) if err != nil { - log.Printf("failed to get authorized client: %s", err) + s.Logger.Error("failed to get authorized client", "err", err) s.Pages.Notice(w, "handle-error", "Failed to authorize. Try logging in again.") return } @@ -808,7 +807,7 @@ func (s *Settings) updateHandle(w http.ResponseWriter, r *http.Request) { "/settings/profile?handle=1", ) if elevErr != nil { - log.Printf("failed to start elevated auth flow: %s", elevErr) + s.Logger.Error("failed to start elevated auth flow", "err", elevErr) s.Pages.Notice(w, "handle-error", "Failed to start re-authorization. Try again later.") return } @@ -817,7 +816,7 @@ func (s *Settings) updateHandle(w http.ResponseWriter, r *http.Request) { return } - log.Printf("failed to update handle: %s", err) + s.Logger.Error("failed to update handle", "err", err) msg := err.Error() var apiErr *atclient.APIError if errors.As(err, &apiErr) && apiErr.Message != "" { -- 2.51.2