From 589aeeacace73f7d0da4d4508bc0b8a524955160 Mon Sep 17 00:00:00 2001
From: David Bushell <david@dbushell.com>
Date: Mon, 9 Mar 2026 06:05:03 +0000
Subject: [PATCH] fix dialog types

---
 src/lib/dialog.svelte.ts                | 17 ++++++-----------
 src/routes/bookmarks/[did=did]/+page.ts |  1 -
 2 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/src/lib/dialog.svelte.ts b/src/lib/dialog.svelte.ts
index dd02b3e..e16c76d 100644
--- a/src/lib/dialog.svelte.ts
+++ b/src/lib/dialog.svelte.ts
@@ -1,32 +1,27 @@
 export let pointer: { ref: HTMLElement | null } = $state({ ref: null });
 
-export const openDialog = (dialog?: HTMLDialogElement) => {
-  if (dialog === undefined) {
+export const openDialog = (dialog?: HTMLDialogElement | null) => {
+  if ((dialog instanceof HTMLDialogElement) === false) {
     return;
   }
-
   dialog.showModal();
-
+  // Move back to main document
   dialog.addEventListener("close", () => {
     if (pointer.ref) {
       document.querySelector("attic-app")?.append(pointer.ref);
       pointer.ref.showPopover();
     }
   }, { once: true });
-
+  // Move to top-layer
   if (pointer.ref) {
     dialog.append(pointer.ref);
     pointer.ref.showPopover();
   }
 };
 
-export const closeDialog = (dialog?: HTMLDialogElement) => {
-  if (dialog === undefined) {
+export const closeDialog = (dialog?: HTMLDialogElement | null) => {
+  if ((dialog instanceof HTMLDialogElement) === false) {
     return;
   }
   dialog.close();
-  // if (pointer.ref) {
-  //   document.querySelector("attic-app")?.append(pointer.ref);
-  //   pointer.ref.showPopover();
-  // }
 };
diff --git a/src/routes/bookmarks/[did=did]/+page.ts b/src/routes/bookmarks/[did=did]/+page.ts
index 5860904..7490e6e 100644
--- a/src/routes/bookmarks/[did=did]/+page.ts
+++ b/src/routes/bookmarks/[did=did]/+page.ts
@@ -10,7 +10,6 @@ import type { PageLoad } from "./$types";
 
 export const load: PageLoad = async ({ params, data, fetch }) => {
   const pds = await resolvePDS(params.did);
-
   if (pds === null) {
     error(404);
   }
-- 
2.51.2