diff --git a/src/modules/feeds/domain/FeedActivity.ts b/src/modules/feeds/domain/FeedActivity.ts index ebe4d9d2..f709a285 100644 --- a/src/modules/feeds/domain/FeedActivity.ts +++ b/src/modules/feeds/domain/FeedActivity.ts @@ -51,10 +51,7 @@ export class FeedActivity extends Entity { // Type guards for metadata get cardCollected(): boolean { - return ( - this.props.type.value === ActivityTypeEnum.CARD_ADDED_TO_LIBRARY || - this.props.type.value === ActivityTypeEnum.CARD_ADDED_TO_COLLECTION - ); + return this.props.type.value === ActivityTypeEnum.CARD_COLLECTED; } private constructor(props: ActivityProps, id?: UniqueEntityID) { diff --git a/src/modules/feeds/domain/services/FeedService.ts b/src/modules/feeds/domain/services/FeedService.ts index 498df68c..54bf9688 100644 --- a/src/modules/feeds/domain/services/FeedService.ts +++ b/src/modules/feeds/domain/services/FeedService.ts @@ -16,42 +16,10 @@ export class FeedServiceError extends Error { export class FeedService implements DomainService { constructor(private feedRepository: IFeedRepository) {} - async addCardAddedToLibraryActivity( + async addCardCollectedActivity( actorId: CuratorId, cardId: CardId, - ): Promise> { - try { - const activityResult = FeedActivity.createCardCollected(actorId, cardId); - - if (activityResult.isErr()) { - return err(new FeedServiceError(activityResult.error.message)); - } - - const activity = activityResult.value; - const saveResult = await this.feedRepository.addActivity(activity); - - if (saveResult.isErr()) { - return err( - new FeedServiceError( - `Failed to save activity: ${saveResult.error.message}`, - ), - ); - } - - return ok(activity); - } catch (error) { - return err( - new FeedServiceError( - `Unexpected error: ${error instanceof Error ? error.message : 'Unknown error'}`, - ), - ); - } - } - - async addCardAddedToCollectionActivity( - actorId: CuratorId, - cardId: CardId, - collectionIds: CollectionId[], + collectionIds?: CollectionId[], ): Promise> { try { const activityResult = FeedActivity.createCardCollected( diff --git a/src/modules/feeds/domain/value-objects/ActivityType.ts b/src/modules/feeds/domain/value-objects/ActivityType.ts index ee30cd02..95fbac6c 100644 --- a/src/modules/feeds/domain/value-objects/ActivityType.ts +++ b/src/modules/feeds/domain/value-objects/ActivityType.ts @@ -2,8 +2,7 @@ import { ValueObject } from '../../../../shared/domain/ValueObject'; import { Result, ok, err } from '../../../../shared/core/Result'; export enum ActivityTypeEnum { - CARD_ADDED_TO_LIBRARY = 'CARD_ADDED_TO_LIBRARY', - CARD_ADDED_TO_COLLECTION = 'CARD_ADDED_TO_COLLECTION', + CARD_COLLECTED = 'CARD_COLLECTED', } interface ActivityTypeProps { @@ -26,11 +25,7 @@ export class ActivityType extends ValueObject { return ok(new ActivityType({ value: type })); } - public static cardAddedToLibrary(): Result { - return this.create(ActivityTypeEnum.CARD_ADDED_TO_LIBRARY); - } - - public static cardAddedToCollection(): Result { - return this.create(ActivityTypeEnum.CARD_ADDED_TO_COLLECTION); + public static cardCollected(): Result { + return this.create(ActivityTypeEnum.CARD_COLLECTED); } }