From c7e443e710845b3c51f0e9a21607e81d3b90d671 Mon Sep 17 00:00:00 2001
From: Wesley Finck <wesleyfinck@gmail.com>
Date: Thu, 6 Nov 2025 14:45:39 -0500
Subject: [PATCH] refactor: use normalized URL value across use cases

Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <aider@aider.chat>
---
 .../useCases/commands/AddUrlToLibraryUseCase.ts   |  4 ++--
 .../queries/GetCollectionsForUrlUseCase.ts        |  2 +-
 .../useCases/queries/GetLibrariesForUrlUseCase.ts | 15 +++++++++------
 .../useCases/queries/GetNoteCardsForUrlUseCase.ts | 15 +++++++++------
 .../useCases/queries/GetUrlMetadataUseCase.ts     |  2 +-
 5 files changed, 22 insertions(+), 16 deletions(-)

diff --git a/src/modules/cards/application/useCases/commands/AddUrlToLibraryUseCase.ts b/src/modules/cards/application/useCases/commands/AddUrlToLibraryUseCase.ts
index 54cab9e3..8620cde4 100644
--- a/src/modules/cards/application/useCases/commands/AddUrlToLibraryUseCase.ts
+++ b/src/modules/cards/application/useCases/commands/AddUrlToLibraryUseCase.ts
@@ -107,7 +107,7 @@ export class AddUrlToLibraryUseCase extends BaseUseCase<
         // Create URL card
         const urlCardInput: IUrlCardInput = {
           type: CardTypeEnum.URL,
-          url: request.url,
+          url: url.value,
           metadata: metadataResult.value,
         };
 
@@ -192,7 +192,7 @@ export class AddUrlToLibraryUseCase extends BaseUseCase<
             type: CardTypeEnum.NOTE,
             text: request.note,
             parentCardId: urlCard.cardId.getStringValue(),
-            url: request.url,
+            url: url.value,
           };
 
           const noteCardResult = CardFactory.create({
diff --git a/src/modules/cards/application/useCases/queries/GetCollectionsForUrlUseCase.ts b/src/modules/cards/application/useCases/queries/GetCollectionsForUrlUseCase.ts
index 58a048e3..20c2f26f 100644
--- a/src/modules/cards/application/useCases/queries/GetCollectionsForUrlUseCase.ts
+++ b/src/modules/cards/application/useCases/queries/GetCollectionsForUrlUseCase.ts
@@ -60,7 +60,7 @@ export class GetCollectionsForUrlUseCase
     try {
       // Execute query to get collections containing cards with this URL (raw data with authorId)
       const result = await this.collectionQueryRepo.getCollectionsWithUrl(
-        query.url,
+        urlResult.value.value,
         {
           page,
           limit,
diff --git a/src/modules/cards/application/useCases/queries/GetLibrariesForUrlUseCase.ts b/src/modules/cards/application/useCases/queries/GetLibrariesForUrlUseCase.ts
index 25b39cfe..e26fcbd0 100644
--- a/src/modules/cards/application/useCases/queries/GetLibrariesForUrlUseCase.ts
+++ b/src/modules/cards/application/useCases/queries/GetLibrariesForUrlUseCase.ts
@@ -68,12 +68,15 @@ export class GetLibrariesForUrlUseCase
 
     try {
       // Execute query to get libraries with full card data
-      const result = await this.cardQueryRepo.getLibrariesForUrl(query.url, {
-        page,
-        limit,
-        sortBy,
-        sortOrder,
-      });
+      const result = await this.cardQueryRepo.getLibrariesForUrl(
+        urlResult.value.value,
+        {
+          page,
+          limit,
+          sortBy,
+          sortOrder,
+        },
+      );
 
       // Enrich with user profiles
       const uniqueUserIds = Array.from(
diff --git a/src/modules/cards/application/useCases/queries/GetNoteCardsForUrlUseCase.ts b/src/modules/cards/application/useCases/queries/GetNoteCardsForUrlUseCase.ts
index 5ec5548d..4b9c7d2c 100644
--- a/src/modules/cards/application/useCases/queries/GetNoteCardsForUrlUseCase.ts
+++ b/src/modules/cards/application/useCases/queries/GetNoteCardsForUrlUseCase.ts
@@ -58,12 +58,15 @@ export class GetNoteCardsForUrlUseCase
 
     try {
       // Execute query to get note cards for the URL (raw data with authorId)
-      const result = await this.cardQueryRepo.getNoteCardsForUrl(query.url, {
-        page,
-        limit,
-        sortBy,
-        sortOrder,
-      });
+      const result = await this.cardQueryRepo.getNoteCardsForUrl(
+        urlResult.value.value,
+        {
+          page,
+          limit,
+          sortBy,
+          sortOrder,
+        },
+      );
 
       // Enrich with author profiles
       const uniqueAuthorIds = Array.from(
diff --git a/src/modules/cards/application/useCases/queries/GetUrlMetadataUseCase.ts b/src/modules/cards/application/useCases/queries/GetUrlMetadataUseCase.ts
index da750c15..cb8cc129 100644
--- a/src/modules/cards/application/useCases/queries/GetUrlMetadataUseCase.ts
+++ b/src/modules/cards/application/useCases/queries/GetUrlMetadataUseCase.ts
@@ -62,7 +62,7 @@ export class GetUrlMetadataUseCase
 
       return ok({
         metadata: {
-          url: metadata.url,
+          url: url.value,
           title: metadata.title,
           description: metadata.description,
           author: metadata.author,
-- 
2.51.2