From 29543c331b274d63497d31e23cc1c748fec00c93 Mon Sep 17 00:00:00 2001
From: Julien WITTOUCK <julien.wittouck@gmail.com>
Date: Fri, 22 Aug 2025 11:08:34 +0200
Subject: [PATCH] =?UTF-8?q?=E2=9C=85=20:=20add=20tests=20for=20classroom?=
 =?UTF-8?q?=20archiving=20by=20role?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- add mvc tests ensuring only teachers can archive classrooms
  - verify teachers are redirected on success
  - ensure students receive a 403 forbidden response
  - validate service.archiveClassroom is not called for student role
- provide coverage for role-based access control on archive endpoint
---
 .../classrooms/ClassroomController.java       |  8 +++++++
 .../resources/templates/classrooms/view.html  | 24 ++++++++++++-------
 .../ClassroomControllerMVCTest.java           | 20 ++++++++++++++++
 3 files changed, 44 insertions(+), 8 deletions(-)

diff --git a/src/main/java/fr/univ_lille/gitlab/classrooms/classrooms/ClassroomController.java b/src/main/java/fr/univ_lille/gitlab/classrooms/classrooms/ClassroomController.java
index c824aac..f0af524 100644
--- a/src/main/java/fr/univ_lille/gitlab/classrooms/classrooms/ClassroomController.java
+++ b/src/main/java/fr/univ_lille/gitlab/classrooms/classrooms/ClassroomController.java
@@ -86,4 +86,12 @@ class ClassroomController {
         return "classrooms/joined";
     }
 
+    @GetMapping("/{classroomId}/archive")
+    String archiveClassroom(@PathVariable UUID classroomId) {
+        var classroom = this.classroomService.getClassroom(classroomId)
+                .orElseThrow(() -> new ResponseStatusException(HttpStatus.NOT_FOUND));
+
+        this.classroomService.archiveClassroom(classroom);
+        return "redirect:/";
+    }
 }
diff --git a/src/main/resources/templates/classrooms/view.html b/src/main/resources/templates/classrooms/view.html
index c120ebc..88435bb 100644
--- a/src/main/resources/templates/classrooms/view.html
+++ b/src/main/resources/templates/classrooms/view.html
@@ -27,14 +27,22 @@
             <h5 th:text="${classroom.name}">
                 Classroom name
             </h5>
-            <a type="button"
-               th:if="${gitlabGroupUrl}"
-               th:href="${gitlabGroupUrl}"
-               target="_blank"
-               class="btn-primary">
-                <img src="/icons/gitlab-logo-200.svg" class="h-6 w-6 mr-1.5" alt="gitlab icon"/>
-                Open in GitLab
-            </a>
+            <div class="flex flex-row gap-2">
+                <a type="button"
+                   th:if="${gitlabGroupUrl}"
+                   th:href="${gitlabGroupUrl}"
+                   target="_blank"
+                   class="btn-primary">
+                    <img src="/icons/gitlab-logo-200.svg" class="h-6 w-6 mr-1.5" alt="gitlab icon"/>
+                    Open in GitLab
+                </a>
+                <a type="button"
+                   th:href="@{/classrooms/{classroomId}/archive(classroomId=${classroom.id})}"
+                   class="btn-secondary"
+                   onclick="return confirm('Are you sure you want to archive this classroom?');">
+                    Archive Classroom
+                </a>
+            </div>
 
         </div>
         <div class="mt-5 flex lg:ml-4 lg:mt-0">
diff --git a/src/test/java/fr/univ_lille/gitlab/classrooms/classrooms/ClassroomControllerMVCTest.java b/src/test/java/fr/univ_lille/gitlab/classrooms/classrooms/ClassroomControllerMVCTest.java
index bea48bd..c38c5b3 100644
--- a/src/test/java/fr/univ_lille/gitlab/classrooms/classrooms/ClassroomControllerMVCTest.java
+++ b/src/test/java/fr/univ_lille/gitlab/classrooms/classrooms/ClassroomControllerMVCTest.java
@@ -187,4 +187,24 @@ class ClassroomControllerMVCTest {
         verify(classroomService).joinClassroom(any(), any());
     }
 
+    @Test
+    @WithMockTeacher
+    void archiveClassroom_shouldArchiveAndRedirect_forTeacher() throws Exception {
+        mockMvc.perform(get("/classrooms/" + classroomId + "/archive"))
+                .andDo(print())
+                .andExpect(status().is3xxRedirection())
+                .andExpect(redirectedUrl("/"));
+
+        verify(classroomService).archiveClassroom(any());
+    }
+
+    @Test
+    @WithMockStudent
+    void archiveClassroom_shouldBeForbidden_forStudent() throws Exception {
+        mockMvc.perform(get("/classrooms/" + classroomId + "/archive"))
+                .andDo(print())
+                .andExpect(status().isForbidden());
+
+        verify(classroomService, never()).archiveClassroom(any());
+    }
 }
-- 
2.51.2