From d5d84bdb43e02ff3b4fac4131d67c99bac06ef34 Mon Sep 17 00:00:00 2001 From: dietrich ayala Date: Thu, 13 Aug 2026 15:21:12 +0200 Subject: [PATCH] docs(scripts): record that no spec confirms the window-manager requirement The missing-openbox guard added alongside the Linux test fixes cited the maximize-dependent specs as its justification. An A/B on Linux x64 shows that justification does not hold for either of them: - window-targeting.spec.ts passes 9/9 with openbox AND under bare Xvfb, "maximize is non-toggling" included. It passes against both conditions, so it is a pin rather than evidence that maximize is honored. - page-layout.spec.ts fails the same 2 tests in both conditions, on a waitOverlayReady timeout unrelated to window management. The guard stays, on the narrower ground that running a GUI suite with no window manager should be a decision rather than an accident. The header comment's claim that a window manager is required for maximize to stick is left in place but is now marked unconfirmed by anything in the suite. --- scripts/playwright-with-display.sh | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/scripts/playwright-with-display.sh b/scripts/playwright-with-display.sh index a6f4324e..d5dc53d1 100755 --- a/scripts/playwright-with-display.sh +++ b/scripts/playwright-with-display.sh @@ -34,8 +34,16 @@ set -euo pipefail if [ "$(uname -s)" = "Linux" ]; then # A missing openbox used to be silent: `openbox &` below printed # "command not found" into the run's noise and the suite carried on with no - # window manager, so the maximize-dependent specs measured pre-maximize - # geometry and PASSED. A false green is worse than no run, so refuse. + # window manager at all. Running a GUI suite in that state should be a + # decision, not an accident, so refuse. + # + # Measured, and it qualifies the rationale in the header comment: neither + # named spec actually discriminates on window-manager presence on Linux x64. + # window-targeting.spec.ts passes 9/9 both with openbox and under bare Xvfb, + # including "maximize is non-toggling" — so it is a pin, not evidence that + # maximize is honored. page-layout.spec.ts fails the same 2 tests either way, + # for an unrelated waitOverlayReady timeout. The window-manager requirement is + # therefore unconfirmed by any test currently in the suite. if ! command -v openbox >/dev/null 2>&1; then if [ "${PEEK_ALLOW_NO_WM:-}" = "1" ]; then echo "playwright-with-display: openbox missing; PEEK_ALLOW_NO_WM=1 set — running WITHOUT a window manager." >&2 -- 2.51.2