From 655c05ba07a43532ed6596555be190305a396fe5 Mon Sep 17 00:00:00 2001 From: Bretton Date: Tue, 4 Nov 2025 15:11:49 -0800 Subject: [PATCH] test(lexicon): clean up obsolete test data files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove test data files that are no longer valid after enum → knownValues changes: **Removed obsolete enum validation tests:** - post/post-invalid-enum-type.json - knownValues allow unknown types - community/moderator-invalid-permissions.json - knownValues allow extension - interaction/share-valid*.json (2 files) - interaction lexicons removed - interaction/tag-*.json (3 files) - interaction lexicons removed **Fixed invalid test data:** - moderation/tribunal-vote-valid.json - corrected invalid AT-URI format Changed: at://$1/... → at://did:plc:testuser123/... **Rationale:** With knownValues (vs strict enums), the lexicon validator accepts unknown values for extensibility. These test files expected rejection of unknown enum values, which no longer applies under the knownValues pattern. **Validation Status:** All 58 lexicons validated successfully - 15/15 valid test files passing - 11/11 invalid test files correctly rejected - 13 record types with test coverage 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- .../community/moderator-invalid-permissions.json | 9 --------- .../interaction/share-valid-no-community.json | 5 ----- tests/lexicon-test-data/interaction/share-valid.json | 6 ------ .../interaction/tag-invalid-empty.json | 6 ------ .../interaction/tag-valid-custom.json | 6 ------ .../interaction/tag-valid-known.json | 6 ------ .../moderation/tribunal-vote-valid.json | 2 +- .../post/post-invalid-enum-type.json | 11 ----------- 8 files changed, 1 insertion(+), 50 deletions(-) delete mode 100644 tests/lexicon-test-data/community/moderator-invalid-permissions.json delete mode 100644 tests/lexicon-test-data/interaction/share-valid-no-community.json delete mode 100644 tests/lexicon-test-data/interaction/share-valid.json delete mode 100644 tests/lexicon-test-data/interaction/tag-invalid-empty.json delete mode 100644 tests/lexicon-test-data/interaction/tag-valid-custom.json delete mode 100644 tests/lexicon-test-data/interaction/tag-valid-known.json delete mode 100644 tests/lexicon-test-data/post/post-invalid-enum-type.json diff --git a/tests/lexicon-test-data/community/moderator-invalid-permissions.json b/tests/lexicon-test-data/community/moderator-invalid-permissions.json deleted file mode 100644 index f540a35..0000000 --- a/tests/lexicon-test-data/community/moderator-invalid-permissions.json +++ /dev/null @@ -1,9 +0,0 @@ -{ - "$type": "social.coves.community.moderator", - "user": "did:plc:moderator123", - "community": "did:plc:community123", - "role": "moderator", - "permissions": ["remove_posts", "invalid-permission"], - "createdAt": "2024-06-15T10:00:00Z", - "createdBy": "did:plc:owner123" -} \ No newline at end of file diff --git a/tests/lexicon-test-data/interaction/share-valid-no-community.json b/tests/lexicon-test-data/interaction/share-valid-no-community.json deleted file mode 100644 index f631297..0000000 --- a/tests/lexicon-test-data/interaction/share-valid-no-community.json +++ /dev/null @@ -1,5 +0,0 @@ -{ - "$type": "social.coves.interaction.share", - "subject": "at://did:plc:originalauthor/social.coves.post.record/3k7a3dmb5bk2c", - "createdAt": "2025-01-09T17:00:00Z" -} \ No newline at end of file diff --git a/tests/lexicon-test-data/interaction/share-valid.json b/tests/lexicon-test-data/interaction/share-valid.json deleted file mode 100644 index 6488ec5..0000000 --- a/tests/lexicon-test-data/interaction/share-valid.json +++ /dev/null @@ -1,6 +0,0 @@ -{ - "$type": "social.coves.interaction.share", - "subject": "at://did:plc:originalauthor/social.coves.post.record/3k7a3dmb5bk2c", - "community": "did:plc:targetcommunity", - "createdAt": "2025-01-09T17:00:00Z" -} \ No newline at end of file diff --git a/tests/lexicon-test-data/interaction/tag-invalid-empty.json b/tests/lexicon-test-data/interaction/tag-invalid-empty.json deleted file mode 100644 index ca15543..0000000 --- a/tests/lexicon-test-data/interaction/tag-invalid-empty.json +++ /dev/null @@ -1,6 +0,0 @@ -{ - "$type": "social.coves.interaction.tag", - "subject": "at://did:plc:author123/social.coves.post.record/3k7a3dmb5bk2c", - "tag": "", - "createdAt": "2025-01-09T17:15:00Z" -} \ No newline at end of file diff --git a/tests/lexicon-test-data/interaction/tag-valid-custom.json b/tests/lexicon-test-data/interaction/tag-valid-custom.json deleted file mode 100644 index b3967f5..0000000 --- a/tests/lexicon-test-data/interaction/tag-valid-custom.json +++ /dev/null @@ -1,6 +0,0 @@ -{ - "$type": "social.coves.interaction.tag", - "subject": "at://did:plc:author123/social.coves.post.record/3k7a3dmb5bk2c", - "tag": "beginner-friendly", - "createdAt": "2025-01-09T17:15:00Z" -} \ No newline at end of file diff --git a/tests/lexicon-test-data/interaction/tag-valid-known.json b/tests/lexicon-test-data/interaction/tag-valid-known.json deleted file mode 100644 index 54bf67e..0000000 --- a/tests/lexicon-test-data/interaction/tag-valid-known.json +++ /dev/null @@ -1,6 +0,0 @@ -{ - "$type": "social.coves.interaction.tag", - "subject": "at://did:plc:author123/social.coves.post.record/3k7a3dmb5bk2c", - "tag": "nsfw", - "createdAt": "2025-01-09T17:15:00Z" -} \ No newline at end of file diff --git a/tests/lexicon-test-data/moderation/tribunal-vote-valid.json b/tests/lexicon-test-data/moderation/tribunal-vote-valid.json index 6a42232..c8614ce 100644 --- a/tests/lexicon-test-data/moderation/tribunal-vote-valid.json +++ b/tests/lexicon-test-data/moderation/tribunal-vote-valid.json @@ -1,7 +1,7 @@ { "$type": "social.coves.moderation.tribunalVote", "tribunal": "at://did:plc:community123/social.coves.moderation.tribunal/3k7a3dmb5bk2c", - "subject": "at://$1/social.coves.community.post/3k7a2clb4bj2b", + "subject": "at://did:plc:testuser123/social.coves.community.post/3k7a2clb4bj2b", "decision": "remove", "reasoning": "The moderator's action was justified based on clear violation of Rule 2 (No Spam). The user posted the same promotional content across multiple communities within a short timeframe.", "precedents": [ diff --git a/tests/lexicon-test-data/post/post-invalid-enum-type.json b/tests/lexicon-test-data/post/post-invalid-enum-type.json deleted file mode 100644 index 19af8cc..0000000 --- a/tests/lexicon-test-data/post/post-invalid-enum-type.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "$type": "social.coves.community.post", - "community": "did:plc:programming123", - "author": "did:plc:testauthor123", - "postType": "invalid-type", - "title": "This has an invalid post type", - "content": "The postType field is not defined in the schema and should be rejected", - "tags": [], - "langs": ["en"], - "createdAt": "2025-01-09T14:30:00Z" -} -- 2.51.2