{"entries":[{"lastCommit":{"author":{"email":"brettmay0212@gmail.com","name":"Bretton","when":"2026-09-28T19:24:13.000000-07:00"},"committer":{"email":"brettmay0212@gmail.com","name":"Bretton","when":"2026-09-28T19:24:13.000000-07:00"},"hash":"224dc43ff4bb2e1dc90d0be7064f0a8e93d80584","message":"fix(config): stop flutter test from reaching the production AppView\n\nHost-side `flutter test` defines no flavor or ENVIRONMENT, so\nEnvironmentConfig.current fell through to production and any test\nholding a real CovesApiService (e.g. tokenlessApiService()) sent live\nrequests to https://coves.social, bsky.social and plc.directory. A\nmissed mock did not fail; it silently reached the internet.\n\nHost `flutter test` (FLUTTER_TEST set, non-release) now resolves to a\nnew EnvironmentConfig.test whose API, handle resolver and PLC URLs are\nthe closed loopback port http://127.0.0.1:1, so a stray request is\nrefused immediately. webUrl stays https://coves.social because it only\nbuilds share links and is never requested. Explicit defines and flavor\nstill take priority; the app's default remains production.\n\nChanges:\n- EnvironmentConfig: new Environment.test / EnvironmentConfig.test;\n priority logic moved into a pure @visibleForTesting resolve() that\n `current` (now computed once) delegates to.\n- Non-empty unrecognized ENVIRONMENT / ENV / flavor values throw\n StateError instead of silently building production (e.g. the typo\n ENVIRONMENT=dev). Release lanes and launch configs use only accepted\n values.\n- Test-environment detection is gated on !kReleaseMode, so release\n builds can never select it.\n- integration_test/media_validation_test.dart asserts isLocal before\n starting the app and documents --dart-define=ENVIRONMENT=local; on a\n device FLUTTER_TEST is never set, so it previously ran against\n production.\n- Tests: repro test gating on createCovesDio().options.baseUrl before\n sending a real request; resolver priority and throw tests; persisted\n Environment names pinned (they are secure-storage session keys);\n auth fixtures use coves_session_test; share tests assert webUrl\n instead of isProduction.\n- Docs: environment docs scoped to host-side flutter test; test helper\n docs explain the widget binding's synthetic 400; QA_LOOP.md env\n guidance corrected.\n\nVerified: flutter test 2243 passing with zero https://coves.social/xrpc\nlines; flutter analyze clean. Not verified: media_validation integration\ntest on a simulator.\n\nReviewed with /second-opinion (8 reviewers) and a codex round-2 pass.\nFixes backlog issue 2026-09-22-mobile-tests-reach-production-appview;\nfollow-ups filed as 2026-09-28-mobile-{missed-mocks-fail-safe-not-loud,\nhost-tests-can-select-live-environment,streamable-service-hardcoded-url,\nandroid-release-allows-cleartext}.\n\nCo-Authored-By: Claude Opus 5.5 \n","tree":"e8720f04ca58cd9f440ca78e8999461e31ce7e44"},"mode":"0040000","name":"config","size":0},{"lastCommit":{"author":{"email":"brettmay0212@gmail.com","name":"Bretton","when":"2026-09-05T22:42:52.000000-07:00"},"committer":{"email":"brettmay0212@gmail.com","name":"Bretton","when":"2026-09-05T22:42:52.000000-07:00"},"hash":"30fecbd7b6d8eeae1cc1e68a2cae81afff56ed98","message":"chore(deps): refresh stable dependencies and enforce release gates\n\nRefresh Flutter dependencies and pin reproducible development/release tooling.\nKeep secure storage on v10 for migration safety and retain the supported AGP 8\ncombination for stable flutter_web_auth_2 v5.\n\nChanges:\n- Remove unused share_plus and upgrade stable runtime/development packages.\n- Pin Flutter, Ruby, Maestro, Lefthook, Fastlane, and CocoaPods with locks.\n- Resolve iOS auth/cropper plugins through Swift Package Manager.\n- Use Bundler binstubs and strict analysis, format, and test-report release gates.\n- Handle Dio transform timeouts without retrying writes or dropping sessions.\n- Preserve legal gates when routing native OAuth callbacks.\n- Preserve main's confirmed-logout semantics and its regression coverage.\n- Correct disposed comment-provider cleanup to preserve unexpected errors.\n- Clear analyzer debt and apply the pinned Dart formatter across source/tests.\n- Replace skipped auth coverage and add router, release, and native regressions.\n\nValidation: clean analyzer/formatter, 1,642 unit/widget tests with zero skips,\nRuby release/helper regressions. Dependency candidate signed AAB and App Store\nIPA verified before integrating main's separately tested logout change.\nReal Android/iOS emulator login, cancellation, restart retention, refresh/native\nstorage and crop save/cancel checks passed. Physical devices were not tested.\n\nDeferred central issues:\n- 2026-09-05-mobile-content-deep-links-not-registered (p2).\n- 2026-09-05-mobile-oauth-custom-scheme-session-interception (p1).\n- 2026-09-05-local-pds-safari-oauth-csp-upgrade (p2).\n- 2026-09-05-android-cropper-return-anr-under-load (needs-info, p2).\n\nThe temporary local PDS CSP/cookie diagnostic edits were restored. Public\ncontent-link support and callback credential protection remain separate work.\n\nReview: earlier multi-model review plus final local review. The user explicitly\naccepted the earlier review and waived an additional external review.\n","tree":"c585343061e9221880ce8d9d5cac3450a8db77a6"},"mode":"0040000","name":"constants","size":0},{"lastCommit":{"author":{"email":"brettmay0212@gmail.com","name":"Bretton","when":"2026-09-27T22:55:14.000000-07:00"},"committer":{"email":"brettmay0212@gmail.com","name":"Bretton","when":"2026-09-27T22:55:14.000000-07:00"},"hash":"a9f5c008e362d20180c25b7d8cece6d98269f2b0","message":"perf: cut cold-start requests, reuse connections, and trim rebuilds\n\nLaunch fetched data for tabs the user wasn't looking at, each Coves\nclient held its own connection pool that dropped idle sockets after 3s,\npagination waited until the loading footer, images decoded at source\nresolution, and one vote or feed load rebuilt every card on screen.\n\nChanges:\n- Build shell tabs on first visit instead of all five at launch.\n- Run auth, EULA and guidelines init concurrently, and start a restored\n session's feed fetch in bootstrap; the feed screen reuses an in-flight\n or recent (30s) page-one load via MultiFeedProvider.loadInitialFeeds.\n- Share one connection pool (15s idle timeout) across the API, vote,\n comment and auth clients (lib/services/coves_http.dart).\n- Request the next page ~1.5 viewports before the end.\n- Decode avatars, link thumbnails, video posters and banners at display\n size (lib/utils/image_decode_size.dart).\n- Narrow feed pages and vote rows to Selectors over their own state.\n- Fetch a community and its feed in parallel.\n- Reload the home feed when a rejected restored session is recovered,\n on either refresh path (AuthProvider.restoredSessionRecoveryCount), so\n a stale token's anonymous Discover page can't clear the user's votes.\n- Re-run the community viewport-fill check after the community loads.\n- Guard post-detail comment load-more after a failure (footer Retry)\n and throttle it with PaginationScrollListener.\n- Tests for initial-load reuse, session recovery, the scroll trigger,\n decode sizing, the community fill check and comment load-more.\n\nThe 15s idle timeout was checked on a physical device: voting right\nafter a Wi-Fi to cellular switch succeeded 5 out of 5 times.\n\nCo-Authored-By: Claude Opus 5.5 (1M context) \n","tree":"db63c39f836ac536ccebaef5eb55bb85420b9722"},"mode":"0100644","name":"main.dart","size":15943},{"lastCommit":{"author":{"email":"brettmay0212@gmail.com","name":"Bretton","when":"2026-09-30T22:21:38.000000-07:00"},"committer":{"email":"brettmay0212@gmail.com","name":"Bretton","when":"2026-09-30T22:21:38.000000-07:00"},"hash":"cd6d434bd8b622a8c4712ed443106577fc80ee4b","message":"fix(models): keep the Bluesky card when embed fields are wrong-typed\n\nWrong-typed fields in a Bluesky embed raised TypeError from raw `as` casts.\nThe lenient parse handlers catch only FormatException, so the TypeError\nescaped to PostEmbed's `on Object` backstop and the whole quote embed became\nUnknownPostEmbed. One malformed optional field cost the entire card. The\nbackend does not send these shapes today; this is hardening at the system\nboundary.\n\nIssue: 2026-09-22-mobile-bluesky-embed-typeerror-drops-card\n\nChanges:\n- BlueskyPostResult: a non-map `embed`, non-map `quotedPost`, or non-string\n `message` now degrades to null instead of throwing; a map-shaped but\n malformed quotedPost is still parsed strictly\n- BlueskyExternalEmbed: wrong-typed title/description/thumb raise\n FormatException, so the existing handler drops only the link card\n- Author parsing validates did/handle with FormatException and drops\n wrong-typed displayName/avatar to null, instead of AuthorView.fromJson casts\n- BlueskyPostEmbed: a non-map `resolved` leaves resolved null (unavailable\n card) rather than dropping the embed\n- PostEmbed: update the `on Object` comment to describe it as a backstop\n- Tests: 13 new model tests in bluesky_post_test.dart; post_embed_test.dart\n re-pins the non-map `resolved` case to QuotePostEmbed with resolved null\n\nReview: full /second-opinion round 1 found 2 Important issues (non-map\n`resolved` cast, AuthorView raw casts), both fixed; codex round 2 clean.\n\nCo-Authored-By: Claude Opus 5.5 \n","tree":"3589e7587861df69c371112eef2fabb1e30ec3e1"},"mode":"0040000","name":"models","size":0},{"lastCommit":{"author":{"email":"brettmay0212@gmail.com","name":"Bretton","when":"2026-09-30T22:25:26.000000-07:00"},"committer":{"email":"brettmay0212@gmail.com","name":"Bretton","when":"2026-09-30T22:25:26.000000-07:00"},"hash":"ddb5db50d3164cb99fa0141b6993ad9a21b79632","message":"fix(post-detail): handle reply-load failures without crashes or wrong messages\n\nReply loading on the post detail and focused thread screens could fail\nbadly. A malformed comment AT-URI made loadMoreReplies throw ArgumentError,\nwhich the screens' `on Exception` catches missed, so it escaped as an\nuncaught async error. A whole-tree refresh landing mid-fetch made\nloadMoreReplies return a stale-discard null, which comment focus reported\nas \"Couldn't find that comment. It may have been deleted.\"\n\nBacklog issue: 2026-09-24-post-detail-reply-load-error-handling.\n\nChanges:\n- CommentsProvider.loadMoreReplies throws a typed\n MalformedCommentUriException for a URI with no rkey, so the screens'\n existing `on Exception` branches handle it; no `on ArgumentError`\n catches remain, so RangeError/IndexError still reach Sentry\n- In-flight reply fetches record their tree generation; a caller arriving\n after a refresh starts a fresh fetch instead of joining the stale one,\n and only the owning fetch removes its in-flight entry\n- Post detail compares treeGeneration across the focus fetch and re-arms\n the focus against the refreshed tree instead of reporting \"deleted\"\n- Focused thread screen reports malformed reply-load URIs instead of\n throwing, for both load-more and its entry fetch\n- Widget tests for post detail and focused thread reply-load errors;\n provider tests for the generation-tagged in-flight entries\n- Maestro: standalone c6_comment_focus_missing and\n c7_comment_focus_malformed flows (fired by an adb deep link first),\n noted in .maestro/config.yaml\n\nReview: full /second-opinion round 1 found 2 Important issues (catches\ntoo broad, in-flight identity check untested), both fixed; codex round 2\nclean. Device: passed on emulator 2026-09-29 (load-more, focused-thread\nchain, comment focus in tree and via subtree fetch, malformed ?comment=).\n\"Failed to load replies\" was not exercised because it needs a backend\nfailure.\n\nDeferred: a misanchored subtree response is still a silent null;\nfocused-thread hydration treats a stale-discard null as success; a\nmalformed ?comment= deep link isn't validated at the route; a stale fetch\nfailing with ApiException after a refresh still says \"deleted\"; a\nmalformed parentUri in createComment makes verification sleep through\nevery retry delay.\n\nCo-Authored-By: Claude Opus 5.5 \n","tree":"ea2aae7df19670e9ce74f84f303af74bfb8c1eab"},"mode":"0040000","name":"providers","size":0},{"lastCommit":{"author":{"email":"brettmay0212@gmail.com","name":"Bretton","when":"2026-09-30T22:27:42.000000-07:00"},"committer":{"email":"brettmay0212@gmail.com","name":"Bretton","when":"2026-09-30T22:27:42.000000-07:00"},"hash":"800113c93965b5471d4c266062b37392182cdd20","message":"fix(communities): cap community names at 16 for the PDS handle limit\n\nThe Create Community form allowed names up to 63 characters, the DNS label\nlimit, but the name becomes the c- first label of the community\nhandle, and the stock PDS caps that label at 18 characters. A device check\nshowed names of 17 or more characters pass client validation, then fail at\nthe PDS with \"InvalidHandle: Handle too long\", which the AppView surfaces as\na generic 500 (\"Failed to create community: An internal error occurred\").\nThe user decided the client limit is 18 - len(\"c-\") = 16.\n\nFixes claude-skills issue 2026-08-08-mobile-community-name-length-ignores-c-prefix.\nBackend counterpart (AppView returns 500 for an over-long name instead of a\nvalidation error): 2026-09-29-community-name-over-pds-handle-limit-returns-500.\n\nChanges:\n- CommunityNameValidator: add handlePrefix (\"c-\") and\n pdsHandleLabelMaxLength (18); maxLength is now their difference, 16\n- Create Community handle preview builds from handlePrefix\n- Tests pin the limit with literals: 16 accepted, 17 rejected with\n \"Name must be 16 characters or less\" (validator, form widget, and the\n admin panel characterization test)\n- New Maestro flow d5_create_community_name_length, run right after d1 in\n .maestro/config.yaml since it reuses d1's signed-in admin session; it\n uses the cold-launch retry the other flows use\n\nVerified: flutter analyze clean, flutter test 2297 passed, d5 passed 2/2 on\nemulator-5554 against the local backend.\n\nCo-Authored-By: Claude Opus 5.5 \n","tree":"53e161950f015f91b031e282cd1466c18b167510"},"mode":"0040000","name":"screens","size":0},{"lastCommit":{"author":{"email":"brettmay0212@gmail.com","name":"Bretton","when":"2026-09-30T22:23:15.000000-07:00"},"committer":{"email":"brettmay0212@gmail.com","name":"Bretton","when":"2026-09-30T22:23:15.000000-07:00"},"hash":"8e0a748820484c354271f387aeef5d4cf2ee477f","message":"fix(profile): seed community subscriptions from profile posts\n\nProfile post pages hydrated only viewer votes from each loaded page and\nignored post.community.viewer.subscribed, unlike every other feed\nsurface. The profile provider now calls hydrateFeed, so profile posts\nseed votes and community subscriptions the same way the discover,\nfor-you and community feeds do.\n\nNo production effect yet: the AppView does not send `viewer` on a\npost's communityRef (coves internal/core/posts/post.go; the lexicon\ncommunityRef has no viewer field), so the subscription seeding does\nnothing until the AppView adds it. The acceptance tests prove the\nbehavior with synthetic fixtures that include viewer.subscribed.\nWhether the AppView should send it is a separate product decision.\n\nChanges:\n- UserProfileProvider: _hydratePostVotes becomes _hydratePostViewerState\n and calls hydrateFeed on the controller's deduplicated new items\n- ViewerStateHydrator: delete hydrateFeedVotesOnly (divergence D1);\n hydrateFeed docs now list profile posts as site 3\n- Doc comments in the provider and profile_screen.dart state that the\n subscription half is a no-op until the AppView sends viewer\n- Characterization test C6 inverted to assert subscriptions are seeded;\n new C6b pins load-more seeding and that a cursor-drift duplicate\n cannot overwrite an earlier snapshot\n- Remove the hydrateFeedVotesOnly unit test\n\nIssue: claude-skills/issues/2026-08-08-mobile-profile-posts-skip-subscription-hydration.md\n\nCo-Authored-By: Claude Opus 5.5 \n","tree":"14421dcabcecfdb4aa741d003803776abc776bb7"},"mode":"0040000","name":"services","size":0},{"lastCommit":{"author":{"email":"brettmay0212@gmail.com","name":"Bretton","when":"2026-09-30T22:27:42.000000-07:00"},"committer":{"email":"brettmay0212@gmail.com","name":"Bretton","when":"2026-09-30T22:27:42.000000-07:00"},"hash":"800113c93965b5471d4c266062b37392182cdd20","message":"fix(communities): cap community names at 16 for the PDS handle limit\n\nThe Create Community form allowed names up to 63 characters, the DNS label\nlimit, but the name becomes the c- first label of the community\nhandle, and the stock PDS caps that label at 18 characters. A device check\nshowed names of 17 or more characters pass client validation, then fail at\nthe PDS with \"InvalidHandle: Handle too long\", which the AppView surfaces as\na generic 500 (\"Failed to create community: An internal error occurred\").\nThe user decided the client limit is 18 - len(\"c-\") = 16.\n\nFixes claude-skills issue 2026-08-08-mobile-community-name-length-ignores-c-prefix.\nBackend counterpart (AppView returns 500 for an over-long name instead of a\nvalidation error): 2026-09-29-community-name-over-pds-handle-limit-returns-500.\n\nChanges:\n- CommunityNameValidator: add handlePrefix (\"c-\") and\n pdsHandleLabelMaxLength (18); maxLength is now their difference, 16\n- Create Community handle preview builds from handlePrefix\n- Tests pin the limit with literals: 16 accepted, 17 rejected with\n \"Name must be 16 characters or less\" (validator, form widget, and the\n admin panel characterization test)\n- New Maestro flow d5_create_community_name_length, run right after d1 in\n .maestro/config.yaml since it reuses d1's signed-in admin session; it\n uses the cold-launch retry the other flows use\n\nVerified: flutter analyze clean, flutter test 2297 passed, d5 passed 2/2 on\nemulator-5554 against the local backend.\n\nCo-Authored-By: Claude Opus 5.5 \n","tree":"53e161950f015f91b031e282cd1466c18b167510"},"mode":"0040000","name":"utils","size":0},{"lastCommit":{"author":{"email":"brettmay0212@gmail.com","name":"Bretton","when":"2026-09-28T20:39:50.000000-07:00"},"committer":{"email":"brettmay0212@gmail.com","name":"Bretton","when":"2026-09-28T20:39:50.000000-07:00"},"hash":"2103b81e10122ab1b4dc97f88eb650c97d01b31d","message":"feat(compose): replace FacetDetector with a backend-exact link composer\n\nThe old FacetDetector was a partial copy of the atproto reference link\ndetector. It turned a keyboard-capitalized `Https://x.com` into the uri\n`https://Https://x.com`, linked \"e.g\" and \"node.js\", cut the closing\nparen off Wikipedia URLs, kept trailing quotes in the uri, and could emit\nlinks the backend rejects, failing the whole post. Mobile has no markup\nsyntax (the web's markdown is a Lemmy relic), so the composer only turns\nbare http(s) URLs into link facets.\n\ncomposeRichText(text) returns the trimmed content plus link facets whose\nUTF-8 byte ranges are measured against that exact string, and both\ncompose screens send what it returns. Its rules match the web composer\n(minus markdown) and mirror the backend's link-URI acceptance, so a\ncandidate the backend would refuse stays plain text instead of failing\nthe post.\n\nChanges:\n- lib/utils/rich_text_composer.dart (new): composeRichText /\n ComposedRichText (private constructor).\n - Scheme matched case-insensitively and emitted lowercase.\n - Scheme-less domains never link (web parity).\n - The URL must start at a code-point word boundary.\n - Whitespace, <, > and backtick end the URL.\n - Trailing . , ! ? ; : ) \" ' are trimmed, keeping a ) that balances\n the URL. The trim runs in linear time.\n- Backend acceptance mirrored from coves internal/validation/uri.go\n encodeAuthority and maxURILength:\n - The authority after the last '@' must be printable ASCII.\n - The uri must be at most 8192 bytes after percent-encoding.\n - At most 200 accepted facets.\n- lib/utils/utf8_offsets.dart (new): one O(1) UTF-16 <-> UTF-8 offset\n table, with 3 bytes for an unpaired surrogate like dart:convert. Shared\n by the composer and RichTextRenderer, replacing the renderer's private\n converter and FacetDetector's per-call re-encode.\n- RichTextRenderer skips a backend facet whose offset splits a multi-byte\n character.\n- maxFacetsPerRecord in lib/models/facet.dart is the single facet cap.\n- reply_screen and create_post_screen send the composed content and\n facets. The optimistic post uses the same content that was sent.\n- Deleted lib/utils/facet_detector.dart and its tests.\n- Tests: utf8_offsets_test, rich_text_composer_test (21 tests),\n renderer multi-byte characterization, and reply/create-post\n submission tests.\n\nBehavior change: bare domains (example.com) and URLs with non-ASCII\nhosts no longer become links. Non-ASCII paths still link.\n\nReviewed with /second-opinion (7 reviewers) and a /second-opinion mini\nround 2 after the fix round. Web divergences are filed as\nissues/2026-09-28-frontend-bare-url-autolink-diverges-from-backend-and-mobile.md.\n\nCo-Authored-By: Claude Opus 5.5 (1M context) \n","tree":"b164c0c7903f075e6e3e9f821ebe0eb9b5ed6949"},"mode":"0040000","name":"widgets","size":0}],"lastCommit":{"author":{"email":"brettmay0212@gmail.com","name":"Bretton","when":"2026-09-30T22:27:42.000000-07:00"},"committer":{"email":"brettmay0212@gmail.com","name":"Bretton","when":"2026-09-30T22:27:42.000000-07:00"},"hash":"800113c93965b5471d4c266062b37392182cdd20","message":"fix(communities): cap community names at 16 for the PDS handle limit\n\nThe Create Community form allowed names up to 63 characters, the DNS label\nlimit, but the name becomes the c- first label of the community\nhandle, and the stock PDS caps that label at 18 characters. A device check\nshowed names of 17 or more characters pass client validation, then fail at\nthe PDS with \"InvalidHandle: Handle too long\", which the AppView surfaces as\na generic 500 (\"Failed to create community: An internal error occurred\").\nThe user decided the client limit is 18 - len(\"c-\") = 16.\n\nFixes claude-skills issue 2026-08-08-mobile-community-name-length-ignores-c-prefix.\nBackend counterpart (AppView returns 500 for an over-long name instead of a\nvalidation error): 2026-09-29-community-name-over-pds-handle-limit-returns-500.\n\nChanges:\n- CommunityNameValidator: add handlePrefix (\"c-\") and\n pdsHandleLabelMaxLength (18); maxLength is now their difference, 16\n- Create Community handle preview builds from handlePrefix\n- Tests pin the limit with literals: 16 accepted, 17 rejected with\n \"Name must be 16 characters or less\" (validator, form widget, and the\n admin panel characterization test)\n- New Maestro flow d5_create_community_name_length, run right after d1 in\n .maestro/config.yaml since it reuses d1's signed-in admin session; it\n uses the cold-launch retry the other flows use\n\nVerified: flutter analyze clean, flutter test 2297 passed, d5 passed 2/2 on\nemulator-5554 against the local backend.\n\nCo-Authored-By: Claude Opus 5.5 \n","tree":"53e161950f015f91b031e282cd1466c18b167510"}}