From 766de62c1d863de749314e76d16f599a148fb1ea Mon Sep 17 00:00:00 2001
From: eti <eti@eti.tf>
Date: Thu, 20 Aug 2026 21:02:17 +0200
Subject: [PATCH] web: move story fixtures out of the component tree

Signed-off-by: eti <eti@eti.tf>
---
 web/eslint.config.js                          | 19 ++++++++++++++++++-
 .../comments.ts}                              |  2 +-
 .../mock.ts => fixtures/pipelines.ts}         |  6 +++---
 .../timeline/mock.ts => fixtures/timeline.ts} |  0
 .../components/comment/Comment.stories.svelte |  2 +-
 .../comment/CommentCard.stories.svelte        |  2 +-
 .../comment/CommentEditor.stories.svelte      |  2 +-
 .../comment/CommentList.stories.svelte        |  2 +-
 .../repo/CommitHeader.stories.svelte          |  2 +-
 .../components/repo/CommitList.stories.svelte |  6 ++++--
 .../repo/CommitLogView.stories.svelte         |  2 +-
 .../repo/RepoIndexView.stories.svelte         |  2 +-
 .../pipelines/PipelineCard.stories.svelte     |  2 +-
 .../pipelines/PipelineList.stories.svelte     |  2 +-
 .../PipelineWorkflows.stories.svelte          |  2 +-
 .../pipelines/WorkflowLogs.stories.svelte     |  2 +-
 .../pipelines/WorkflowSidebar.stories.svelte  |  2 +-
 .../pipelines/WorkflowView.stories.svelte     |  7 ++++++-
 .../pulls/PullReviewComment.stories.svelte    |  2 +-
 .../timeline/Timeline.stories.svelte          |  2 +-
 .../timeline/TimelineView.stories.svelte      |  2 +-
 .../timeline/TrendingRepos.stories.svelte     |  2 +-
 web/svelte.config.js                          |  4 +++-
 23 files changed, 51 insertions(+), 25 deletions(-)
 rename web/src/{lib/components/comment/sampleComments.ts => fixtures/comments.ts} (98%)
 rename web/src/{lib/components/repo/pipelines/mock.ts => fixtures/pipelines.ts} (97%)
 rename web/src/{lib/components/timeline/mock.ts => fixtures/timeline.ts} (100%)

diff --git a/web/eslint.config.js b/web/eslint.config.js
index 905166cd..57b65d08 100644
--- a/web/eslint.config.js
+++ b/web/eslint.config.js
@@ -56,6 +56,23 @@ export default defineConfig(
 		}
 	},
 	{
-		rules: {}
+		// fixtures feed stories and nothing else. without this the app can import
+		// them and ship sample data, which is how the notifications page got its
+		// mock feed
+		files: ["**/*.svelte", "**/*.svelte.ts", "**/*.svelte.js", "**/*.ts", "**/*.js"],
+		ignores: ["**/*.stories.svelte"],
+		rules: {
+			"no-restricted-imports": [
+				"error",
+				{
+					patterns: [
+						{
+							group: ["$fixtures", "$fixtures/*", "**/src/fixtures", "**/src/fixtures/*"],
+							message: "fixtures are storybook input: import them from a *.stories.svelte file."
+						}
+					]
+				}
+			]
+		}
 	}
 );
diff --git a/web/src/lib/components/comment/sampleComments.ts b/web/src/fixtures/comments.ts
similarity index 98%
rename from web/src/lib/components/comment/sampleComments.ts
rename to web/src/fixtures/comments.ts
index c1a07be3..9241a5d4 100644
--- a/web/src/lib/components/comment/sampleComments.ts
+++ b/web/src/fixtures/comments.ts
@@ -1,7 +1,7 @@
 // real comment data pulled from tangled.org/tangled.org/core/issues/245, used across
 // the comment stories so the fixtures live in one place.
 import type { MarkupContext } from "$lib/markup";
-import type { CommentThread, CommentView } from "./comments";
+import type { CommentThread, CommentView } from "$lib/components/comment/comments";
 
 export const sampleMarkup: MarkupContext = {
 	repo: "tangled.org/core",
diff --git a/web/src/lib/components/repo/pipelines/mock.ts b/web/src/fixtures/pipelines.ts
similarity index 97%
rename from web/src/lib/components/repo/pipelines/mock.ts
rename to web/src/fixtures/pipelines.ts
index a290ecac..4dbd7c03 100644
--- a/web/src/lib/components/repo/pipelines/mock.ts
+++ b/web/src/fixtures/pipelines.ts
@@ -1,9 +1,9 @@
-// fixture pipelines for the stories and the commit list, the pipelines tab
-// reads from a spindle now
+// fixture pipelines for the pipeline and commit-list stories. the app reads real
+// runs from a spindle, so nothing here ever reaches the bundle
 
 import type { PipelineSummary } from "$lib/components/repo/types";
 import type { LogControl, LogFrame } from "$lib/api/spindleLogs";
-import { createLogAccumulator, type LogStep } from "./logs";
+import { createLogAccumulator, type LogStep } from "$lib/components/repo/pipelines/logs";
 
 const minutes = (n: number) => n * 60_000;
 
diff --git a/web/src/lib/components/timeline/mock.ts b/web/src/fixtures/timeline.ts
similarity index 100%
rename from web/src/lib/components/timeline/mock.ts
rename to web/src/fixtures/timeline.ts
diff --git a/web/src/lib/components/comment/Comment.stories.svelte b/web/src/lib/components/comment/Comment.stories.svelte
index 1516af70..898b1157 100644
--- a/web/src/lib/components/comment/Comment.stories.svelte
+++ b/web/src/lib/components/comment/Comment.stories.svelte
@@ -1,7 +1,7 @@
 <script module lang="ts">
 	import { defineMeta } from "@storybook/addon-svelte-csf";
 	import Comment from "./Comment.svelte";
-	import { sampleComments } from "./sampleComments";
+	import { sampleComments } from "$fixtures/comments";
 
 	const { byjp, samuel } = sampleComments;
 
diff --git a/web/src/lib/components/comment/CommentCard.stories.svelte b/web/src/lib/components/comment/CommentCard.stories.svelte
index bd3edae6..916256df 100644
--- a/web/src/lib/components/comment/CommentCard.stories.svelte
+++ b/web/src/lib/components/comment/CommentCard.stories.svelte
@@ -9,7 +9,7 @@
 		sampleSubjectUri,
 		sampleThread,
 		soloThread
-	} from "./sampleComments";
+	} from "$fixtures/comments";
 
 	// a thread the logged-in user owns, so the edit affordance shows
 	const myThread = { self: sampleComments.mine, replies: [] };
diff --git a/web/src/lib/components/comment/CommentEditor.stories.svelte b/web/src/lib/components/comment/CommentEditor.stories.svelte
index 1cb51874..99db8b35 100644
--- a/web/src/lib/components/comment/CommentEditor.stories.svelte
+++ b/web/src/lib/components/comment/CommentEditor.stories.svelte
@@ -9,7 +9,7 @@
 		sampleMarkup,
 		sampleSubjectCid,
 		sampleSubjectUri
-	} from "./sampleComments";
+	} from "$fixtures/comments";
 
 	const { mine } = sampleComments;
 
diff --git a/web/src/lib/components/comment/CommentList.stories.svelte b/web/src/lib/components/comment/CommentList.stories.svelte
index 28b47c89..a12cb13a 100644
--- a/web/src/lib/components/comment/CommentList.stories.svelte
+++ b/web/src/lib/components/comment/CommentList.stories.svelte
@@ -10,7 +10,7 @@
 		sampleSubjectCid,
 		sampleSubjectUri,
 		sampleThreads
-	} from "./sampleComments";
+	} from "$fixtures/comments";
 
 	const { Story } = defineMeta({
 		title: "Comment/CommentList",
diff --git a/web/src/lib/components/repo/CommitHeader.stories.svelte b/web/src/lib/components/repo/CommitHeader.stories.svelte
index 8494c336..3a76fa63 100644
--- a/web/src/lib/components/repo/CommitHeader.stories.svelte
+++ b/web/src/lib/components/repo/CommitHeader.stories.svelte
@@ -3,7 +3,7 @@
 	import { expect } from "storybook/test";
 	import type { CommitDetail } from "$lib/api/repo";
 	import CommitHeader from "./CommitHeader.svelte";
-	import { pipelinesByCommitHash } from "./pipelines/mock";
+	import { pipelinesByCommitHash } from "$fixtures/pipelines";
 
 	const fullCommit: CommitDetail = {
 		hash: "0123456789abcdef0123456789abcdef01234567",
diff --git a/web/src/lib/components/repo/CommitList.stories.svelte b/web/src/lib/components/repo/CommitList.stories.svelte
index 0c22fc72..980294b0 100644
--- a/web/src/lib/components/repo/CommitList.stories.svelte
+++ b/web/src/lib/components/repo/CommitList.stories.svelte
@@ -2,7 +2,7 @@
 	import { defineMeta, type StoryContext } from "@storybook/addon-svelte-csf";
 	import { expect } from "storybook/test";
 	import CommitList from "./CommitList.svelte";
-	import { pipelinesByCommitHash } from "./pipelines/mock";
+	import { pipelinesByCommitHash } from "$fixtures/pipelines";
 	import type { CommitSummary } from "./types";
 
 	const commits: CommitSummary[] = [
@@ -49,7 +49,9 @@
 			tagsByCommit: {
 				"0123456789abcdef0123456789abcdef01234567": ["v1.0.0"]
 			},
-			pipelineStatuses: Promise.resolve(pipelinesByCommitHash(commits.map((commit) => commit.hash)))
+			pipelineStatuses: Promise.resolve(
+				pipelinesByCommitHash(commits.map((commit) => commit.hash))
+			)
 		}
 	});
 </script>
diff --git a/web/src/lib/components/repo/CommitLogView.stories.svelte b/web/src/lib/components/repo/CommitLogView.stories.svelte
index 0a1367d7..aba07d08 100644
--- a/web/src/lib/components/repo/CommitLogView.stories.svelte
+++ b/web/src/lib/components/repo/CommitLogView.stories.svelte
@@ -2,7 +2,7 @@
 	import { defineMeta, type StoryContext } from "@storybook/addon-svelte-csf";
 	import { expect, fn, userEvent } from "storybook/test";
 	import CommitLogView from "./CommitLogView.svelte";
-	import { pipelinesByCommitHash } from "./pipelines/mock";
+	import { pipelinesByCommitHash } from "$fixtures/pipelines";
 	import type { CommitSummary } from "./types";
 
 	const commit = (index: number): CommitSummary => ({
diff --git a/web/src/lib/components/repo/RepoIndexView.stories.svelte b/web/src/lib/components/repo/RepoIndexView.stories.svelte
index bdc64943..35b79d7c 100644
--- a/web/src/lib/components/repo/RepoIndexView.stories.svelte
+++ b/web/src/lib/components/repo/RepoIndexView.stories.svelte
@@ -1,7 +1,7 @@
 <script module lang="ts">
 	import { defineMeta } from "@storybook/addon-svelte-csf";
 	import type { loadRepoIndex } from "$lib/api/repoIndex";
-	import { pipelinesByCommitHash } from "./pipelines/mock";
+	import { pipelinesByCommitHash } from "$fixtures/pipelines";
 	import RepoIndexView from "./RepoIndexView.svelte";
 	import type { RepoInfo } from "./types";
 
diff --git a/web/src/lib/components/repo/pipelines/PipelineCard.stories.svelte b/web/src/lib/components/repo/pipelines/PipelineCard.stories.svelte
index 6e5dec0f..cb7b47e9 100644
--- a/web/src/lib/components/repo/pipelines/PipelineCard.stories.svelte
+++ b/web/src/lib/components/repo/pipelines/PipelineCard.stories.svelte
@@ -1,7 +1,7 @@
 <script module lang="ts">
 	import { defineMeta } from "@storybook/addon-svelte-csf";
 	import PipelineCard from "./PipelineCard.svelte";
-	import { pipelines } from "./mock";
+	import { pipelines } from "$fixtures/pipelines";
 
 	const [running, mixed, passed, waiting, timedOut, cancelled] = pipelines;
 
diff --git a/web/src/lib/components/repo/pipelines/PipelineList.stories.svelte b/web/src/lib/components/repo/pipelines/PipelineList.stories.svelte
index 09071da5..6336376f 100644
--- a/web/src/lib/components/repo/pipelines/PipelineList.stories.svelte
+++ b/web/src/lib/components/repo/pipelines/PipelineList.stories.svelte
@@ -1,7 +1,7 @@
 <script module lang="ts">
 	import { defineMeta } from "@storybook/addon-svelte-csf";
 	import PipelineList from "./PipelineList.svelte";
-	import { pipelines } from "./mock";
+	import { pipelines } from "$fixtures/pipelines";
 
 	const ownerDid = "did:plc:owner";
 
diff --git a/web/src/lib/components/repo/pipelines/PipelineWorkflows.stories.svelte b/web/src/lib/components/repo/pipelines/PipelineWorkflows.stories.svelte
index cb556149..c8354133 100644
--- a/web/src/lib/components/repo/pipelines/PipelineWorkflows.stories.svelte
+++ b/web/src/lib/components/repo/pipelines/PipelineWorkflows.stories.svelte
@@ -1,7 +1,7 @@
 <script module lang="ts">
 	import { defineMeta } from "@storybook/addon-svelte-csf";
 	import PipelineWorkflows from "./PipelineWorkflows.svelte";
-	import { pipelines } from "./mock";
+	import { pipelines } from "$fixtures/pipelines";
 
 	const [running, mixed, passed, waiting, timedOut, cancelled] = pipelines;
 
diff --git a/web/src/lib/components/repo/pipelines/WorkflowLogs.stories.svelte b/web/src/lib/components/repo/pipelines/WorkflowLogs.stories.svelte
index de90b9fd..176c187b 100644
--- a/web/src/lib/components/repo/pipelines/WorkflowLogs.stories.svelte
+++ b/web/src/lib/components/repo/pipelines/WorkflowLogs.stories.svelte
@@ -6,7 +6,7 @@
 		longWorkflowLog,
 		runningWorkflowLog,
 		workflowLog
-	} from "./mock";
+	} from "$fixtures/pipelines";
 
 	const { Story } = defineMeta({
 		title: "Repo/Pipelines/WorkflowLogs",
diff --git a/web/src/lib/components/repo/pipelines/WorkflowSidebar.stories.svelte b/web/src/lib/components/repo/pipelines/WorkflowSidebar.stories.svelte
index dc1b6aac..19b4adf0 100644
--- a/web/src/lib/components/repo/pipelines/WorkflowSidebar.stories.svelte
+++ b/web/src/lib/components/repo/pipelines/WorkflowSidebar.stories.svelte
@@ -1,7 +1,7 @@
 <script module lang="ts">
 	import { defineMeta } from "@storybook/addon-svelte-csf";
 	import WorkflowSidebar from "./WorkflowSidebar.svelte";
-	import { pipelines } from "./mock";
+	import { pipelines } from "$fixtures/pipelines";
 
 	const run = pipelines[0];
 
diff --git a/web/src/lib/components/repo/pipelines/WorkflowView.stories.svelte b/web/src/lib/components/repo/pipelines/WorkflowView.stories.svelte
index c6129b61..9a499cf4 100644
--- a/web/src/lib/components/repo/pipelines/WorkflowView.stories.svelte
+++ b/web/src/lib/components/repo/pipelines/WorkflowView.stories.svelte
@@ -2,7 +2,12 @@
 	import { defineMeta } from "@storybook/addon-svelte-csf";
 	import type { WorkflowSummary } from "$lib/components/repo/types";
 	import WorkflowView from "./WorkflowView.svelte";
-	import { longWorkflowLog, pipelines, runningWorkflowLog, workflowLog } from "./mock";
+	import {
+		longWorkflowLog,
+		pipelines,
+		runningWorkflowLog,
+		workflowLog
+	} from "$fixtures/pipelines";
 
 	const [running, mixed, passed] = pipelines;
 
diff --git a/web/src/lib/components/repo/pulls/PullReviewComment.stories.svelte b/web/src/lib/components/repo/pulls/PullReviewComment.stories.svelte
index 81239fac..1a033f74 100644
--- a/web/src/lib/components/repo/pulls/PullReviewComment.stories.svelte
+++ b/web/src/lib/components/repo/pulls/PullReviewComment.stories.svelte
@@ -1,7 +1,7 @@
 <script module lang="ts">
 	import { defineMeta } from "@storybook/addon-svelte-csf";
 	import ReviewComment from "./PullReviewComment.svelte";
-	import { sampleComments } from "$lib/components/comment/sampleComments";
+	import { sampleComments } from "$fixtures/comments";
 
 	const { byjp, samuel } = sampleComments;
 
diff --git a/web/src/lib/components/timeline/Timeline.stories.svelte b/web/src/lib/components/timeline/Timeline.stories.svelte
index ab430561..e3c3a2ad 100644
--- a/web/src/lib/components/timeline/Timeline.stories.svelte
+++ b/web/src/lib/components/timeline/Timeline.stories.svelte
@@ -1,6 +1,6 @@
 <script module lang="ts">
 	import { defineMeta } from "@storybook/addon-svelte-csf";
-	import { feed } from "./mock";
+	import { feed } from "$fixtures/timeline";
 	import Timeline from "./Timeline.svelte";
 
 	const { Story } = defineMeta({
diff --git a/web/src/lib/components/timeline/TimelineView.stories.svelte b/web/src/lib/components/timeline/TimelineView.stories.svelte
index 32b55253..533a8c11 100644
--- a/web/src/lib/components/timeline/TimelineView.stories.svelte
+++ b/web/src/lib/components/timeline/TimelineView.stories.svelte
@@ -1,6 +1,6 @@
 <script module lang="ts">
 	import { defineMeta } from "@storybook/addon-svelte-csf";
-	import { feed, trending } from "./mock";
+	import { feed, trending } from "$fixtures/timeline";
 	import TimelineView from "./TimelineView.svelte";
 
 	const { Story } = defineMeta({
diff --git a/web/src/lib/components/timeline/TrendingRepos.stories.svelte b/web/src/lib/components/timeline/TrendingRepos.stories.svelte
index a8102256..f0b5e34b 100644
--- a/web/src/lib/components/timeline/TrendingRepos.stories.svelte
+++ b/web/src/lib/components/timeline/TrendingRepos.stories.svelte
@@ -1,6 +1,6 @@
 <script module lang="ts">
 	import { defineMeta } from "@storybook/addon-svelte-csf";
-	import { trending } from "./mock";
+	import { trending } from "$fixtures/timeline";
 	import TrendingRepos from "./TrendingRepos.svelte";
 
 	const { Story } = defineMeta({
diff --git a/web/svelte.config.js b/web/svelte.config.js
index 72c87461..fd561101 100644
--- a/web/svelte.config.js
+++ b/web/svelte.config.js
@@ -10,7 +10,9 @@ const config = {
 		runes: ({ filename }) => (filename.split(/[/\\]/).includes("node_modules") ? undefined : true)
 	},
 	kit: {
-		adapter: useCloudflareAdapter ? cloudflareAdapter({ config: "wrangler.dev.jsonc" }) : adapter()
+		adapter: useCloudflareAdapter ? cloudflareAdapter({ config: "wrangler.dev.jsonc" }) : adapter(),
+		// storybook input, not app code. eslint keeps the app from importing it
+		alias: { $fixtures: "src/fixtures" }
 	}
 };
 
-- 
2.51.2