diff --git a/appview/pages/pages.go b/appview/pages/pages.go index d0988ee2..9f8e5747 100644 --- a/appview/pages/pages.go +++ b/appview/pages/pages.go @@ -1225,15 +1225,34 @@ func (p *Pages) IssueCommentBodyFragment(w io.Writer, params IssueCommentBodyPar } type RepoNewPullParams struct { - LoggedInUser *oauth.MultiAccountUser - RepoInfo repoinfo.RepoInfo - Branches []types.Branch - Strategy string - SourceBranch string - TargetBranch string - Title string - Body string - Active string + LoggedInUser *oauth.MultiAccountUser + RepoInfo repoinfo.RepoInfo + Branches []types.Branch + SourceBranches []types.Branch + ForkBranches []types.Branch + Forks []models.Repo + Source Source + SourceBranch string + TargetBranch string + Fork string + Patch string + Title string + Body string + IsStacked bool + Comparison *types.RepoFormatPatchResponse + Diff *types.NiceDiff + PerCommitDiffs []*types.NiceDiff + DiffOpts types.DiffOpts + StackDiffOpts []types.DiffOpts + EmailToDid map[string]string + MergeCheck *types.MergeCheckResponse + StackTitles map[string]string + StackBodies map[string]string + PrefillError string + Active string + LabelDefs map[string]*models.LabelDefinition + LabelState models.LabelState + StackLabelStates map[string]models.LabelState } func (p *Pages) RepoNewPull(w io.Writer, params RepoNewPullParams) error { @@ -1241,6 +1260,14 @@ func (p *Pages) RepoNewPull(w io.Writer, params RepoNewPullParams) error { return p.executeRepo("repo/pulls/new", w, params) } +func (p *Pages) PullWizardHostFragment(w io.Writer, params RepoNewPullParams) error { + return p.executePlain("repo/pulls/fragments/pullWizardHost", w, params) +} + +func (p *Pages) MarkdownPreviewFragment(w io.Writer, body string) error { + return p.executePlain("fragments/markdownPreview", w, body) +} + type RepoPullsParams struct { LoggedInUser *oauth.MultiAccountUser RepoInfo repoinfo.RepoInfo @@ -1335,44 +1362,6 @@ func (p *Pages) RepoPullInterdiffPage(w io.Writer, params RepoPullInterdiffParam return p.execute("repo/pulls/interdiff", w, params) } -type PullPatchUploadParams struct { - RepoInfo repoinfo.RepoInfo -} - -func (p *Pages) PullPatchUploadFragment(w io.Writer, params PullPatchUploadParams) error { - return p.executePlain("repo/pulls/fragments/pullPatchUpload", w, params) -} - -type PullCompareBranchesParams struct { - RepoInfo repoinfo.RepoInfo - Branches []types.Branch - SourceBranch string -} - -func (p *Pages) PullCompareBranchesFragment(w io.Writer, params PullCompareBranchesParams) error { - return p.executePlain("repo/pulls/fragments/pullCompareBranches", w, params) -} - -type PullCompareForkParams struct { - RepoInfo repoinfo.RepoInfo - Forks []models.Repo - Selected string -} - -func (p *Pages) PullCompareForkFragment(w io.Writer, params PullCompareForkParams) error { - return p.executePlain("repo/pulls/fragments/pullCompareForks", w, params) -} - -type PullCompareForkBranchesParams struct { - RepoInfo repoinfo.RepoInfo - SourceBranches []types.Branch - TargetBranches []types.Branch -} - -func (p *Pages) PullCompareForkBranchesFragment(w io.Writer, params PullCompareForkBranchesParams) error { - return p.executePlain("repo/pulls/fragments/pullCompareForksBranches", w, params) -} - type PullResubmitParams struct { LoggedInUser *oauth.MultiAccountUser RepoInfo repoinfo.RepoInfo diff --git a/appview/pages/pulls_wizard.go b/appview/pages/pulls_wizard.go new file mode 100644 index 00000000..1e0ab432 --- /dev/null +++ b/appview/pages/pulls_wizard.go @@ -0,0 +1,24 @@ +package pages + +import "strings" + +type Source string + +const ( + SourcePatch Source = "patch" + SourceBranch Source = "branch" + SourceFork Source = "fork" +) + +func ParseSource(s string) (Source, bool) { + switch strings.ToLower(s) { + case string(SourcePatch): + return SourcePatch, true + case string(SourceFork): + return SourceFork, true + case string(SourceBranch): + return SourceBranch, true + default: + return "", false + } +} diff --git a/appview/pages/templates/fragments/markdownPreview.html b/appview/pages/templates/fragments/markdownPreview.html new file mode 100644 index 00000000..b65f13b3 --- /dev/null +++ b/appview/pages/templates/fragments/markdownPreview.html @@ -0,0 +1,9 @@ +{{ define "fragments/markdownPreview" }} + {{ if . }} +
+ {{ . | markdown }} +
+ {{ else }} +
Nothing to preview.
+ {{ end }} +{{ end }} diff --git a/appview/pages/templates/repo/fragments/compareAllowPull.html b/appview/pages/templates/repo/fragments/compareAllowPull.html index 870a3a9e..9cdf9374 100644 --- a/appview/pages/templates/repo/fragments/compareAllowPull.html +++ b/appview/pages/templates/repo/fragments/compareAllowPull.html @@ -9,7 +9,7 @@ discussed.

- {{ $newPullUrl := printf "/%s/pulls/new?strategy=branch&targetBranch=%s&sourceBranch=%s" .RepoInfo.FullName .Base .Head }} + {{ $newPullUrl := printf "/%s/pulls/new?source=branch&sourceBranch=%s&targetBranch=%s" .RepoInfo.FullName (urlquery .Head) (urlquery .Base) }}
diff --git a/appview/pages/templates/repo/fragments/diff.html b/appview/pages/templates/repo/fragments/diff.html index ecc77798..6985a132 100644 --- a/appview/pages/templates/repo/fragments/diff.html +++ b/appview/pages/templates/repo/fragments/diff.html @@ -101,10 +101,11 @@ {{ define "diffLayout" }} {{ $diff := index . 0 }} {{ $opts := index . 1 }} + {{ $padBottom := gt (len .) 2 }}
-