From 684e939d0747576c9e21739623a61de4938cb00d Mon Sep 17 00:00:00 2001
From: oppiliappan <me@oppi.li>
Date: Wed, 16 Jul 2025 12:29:41 +0100
Subject: [PATCH] appview: ingest pipeline records only for repos with spindles
 configured

also fixes a small UI bug with pipeline symbols on stacked PRs

Signed-off-by: oppiliappan <me@oppi.li>
---
 .../pulls/fragments/summarizedPullHeader.html    |  2 +-
 appview/state/knotstream.go                      | 16 ++++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/appview/pages/templates/repo/pulls/fragments/summarizedPullHeader.html b/appview/pages/templates/repo/pulls/fragments/summarizedPullHeader.html
index 964dc98..dd2c786 100644
--- a/appview/pages/templates/repo/pulls/fragments/summarizedPullHeader.html
+++ b/appview/pages/templates/repo/pulls/fragments/summarizedPullHeader.html
@@ -17,7 +17,7 @@
         {{ $latestRound := .LastRoundNumber }}
         {{ $lastSubmission := index .Submissions $latestRound }}
         {{ $commentCount := len $lastSubmission.Comments }}
-        {{ if $pipeline }}
+        {{ if and $pipeline $pipeline.Id }}
           <div class="inline-flex items-center gap-2">
             {{ template "repo/pipelines/fragments/pipelineSymbol" $pipeline }}
             <span class="mx-2 before:content-['·'] before:select-none"></span>
diff --git a/appview/state/knotstream.go b/appview/state/knotstream.go
index e5b490c..9616a49 100644
--- a/appview/state/knotstream.go
+++ b/appview/state/knotstream.go
@@ -140,6 +140,22 @@ func ingestPipeline(d *db.DB, source ec.Source, msg ec.Message) error {
 		return fmt.Errorf("empty repo: nsid %s, rkey %s", msg.Nsid, msg.Rkey)
 	}
 
+	// does this repo have a spindle configured?
+	repos, err := db.GetRepos(
+		d,
+		db.FilterEq("did", record.TriggerMetadata.Repo.Did),
+		db.FilterEq("name", record.TriggerMetadata.Repo.Repo),
+	)
+	if err != nil {
+		return fmt.Errorf("failed to look for repo in DB: nsid %s, rkey %s, %w", msg.Nsid, msg.Rkey, err)
+	}
+	if len(repos) != 1 {
+		return fmt.Errorf("incorrect number of repos returned: %d (expected 1)", len(repos))
+	}
+	if repos[0].Spindle == "" {
+		return fmt.Errorf("repo does not have a spindle configured yet: nsid %s, rkey %s", msg.Nsid, msg.Rkey)
+	}
+
 	// trigger info
 	var trigger db.Trigger
 	var sha string
-- 
2.51.2