From 25e33e5c8ea43a9c66d1111daed88b27e25017ea Mon Sep 17 00:00:00 2001 From: "prompt.ac/@jeffrey" Date: Tue, 14 Apr 2026 16:19:08 -0700 Subject: [PATCH] native: remove duplicate '# CONFIG_PINCTRL is not set' blocking JSL pinctrl MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The G7 post-flash diagnostic confirmed the jasperlake-pinctrl driver is NOT in /sys/bus/platform/drivers — only cherryview-pinctrl and meteorlake-pinctrl loaded. Explains why speakers stayed silent despite the GPIOLIB fix: without the JSL-specific pinctrl, no SoC GPIOs are registered, so the MAX98360A amp's SD_MODE enable gpiod_get() silently returned NULL and the amp never powered on. Root cause: my earlier commit ADDED CONFIG_PINCTRL=y + a long list of CONFIG_PINCTRL_* entries AFTER the existing `# CONFIG_PINCTRL is not set` line, leaving both in the config. kconfig's olddefconfig handling of duplicates is version-dependent — some Intel-family symbols got through (cherryview, meteorlake) while jasperlake didn't. Delete the stale `# not set` so there's one consistent answer. Co-Authored-By: Claude Opus 4.6 (1M context) --- fedac/native/kernel/config-minimal | 1 - 1 file changed, 1 deletion(-) diff --git a/fedac/native/kernel/config-minimal b/fedac/native/kernel/config-minimal index 82f773a6c..7486088ca 100644 --- a/fedac/native/kernel/config-minimal +++ b/fedac/native/kernel/config-minimal @@ -2238,7 +2238,6 @@ CONFIG_PTP_1588_CLOCK_OPTIONAL=y # CONFIG_PTP_1588_CLOCK_MOCK is not set # end of PTP clock support -# CONFIG_PINCTRL is not set # GPIO framework + Intel pinctrl drivers for Jasper Lake / Tiger Lake / Alder # Lake / Meteor Lake. Required for MAX98360A speaker amp (its SD_MODE enable # is a GPIO — without GPIOLIB the amp stays powered down and speakers are -- 2.51.2